[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://mopd/{templates}



Christian Perrier wrote:
> Your review should be sent as an answer to this mail.
[...]

>  Template: mopd/bad_interface
[...]
> +Type: error
> +_Description: Non existing interface for mopd
                 Nonexistent
> + The MOP daemon configuration already exists as /etc/mopd.conf.
> + .
> + However, that configuration file specifies '${cur_iface}' as listening
> + interface but it currently does not exist.

Not bad, but a mildly redundant use of "however" and "but"; maybe:

    However, that configuration file specifies '${cur_iface}' as listening
    interface, which currently does not exist.

[...]
> I am not happy at all with the package description, but I can't find
> anything. I have no idea what MOPD is....and I'm afraid that the
> package description doesn't help for this...:-)

A mop daemon makes me think of Disney's "Fantasia". 

[...]
> Package: mopd
> Architecture: any
> Depends: ${shlibs:Depends}, debconf | debconf-2.0
> Description: The Maintenance Operations Protocol (MOP) loader daemon
               ^^^
It doesn't need this definite article (or probably the repeat of the
acronym).

>  The MOP daemon services MOP load requests on one or all Ethernet interfaces.
>  Normally, a filename (uppercase and ending in .SYS) is included in the load 
>  request.

Searching for this text online I see versions that imply I could
usefully add a bit extra on the end:

  Description: Maintenance Operations Protocol loader daemon
   This daemon services load requests on one or all Ethernet interfaces using
   the DEC Maintenance Operations Protocol. Normally, a filename (uppercase
   and ending in .SYS) is included in the load request; this is looked for in
   /tftpboot/mop by default and may be used as a netboot image.

Unless of course I'm getting the wrong end of the stick...
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
--- ../mopd.old/debian/templates	2009-01-02 20:14:37.000000000 +0000
+++ debian/templates	2009-01-02 21:04:48.000000000 +0000
@@ -1,20 +1,26 @@
 Template: mopd/other_interface
 Type: string
-_Description: Enter an interface:
+_Description: Interface for mopd:
  Please enter the interface you would like to run mopd on.
 
 Template: mopd/bad_interface
-Type: note
-_Description: mopd's currently configured interface is unavailable
- A configuration exists in /etc/mopd.conf.  The interface indicated in that
- file '${cur_iface}' does not appear to be available.  Please resolve the
+Type: error
+_Description: Nonexistent interface for mopd
+ The MOP daemon configuration already exists as /etc/mopd.conf.
+ .
+ However, that configuration file specifies '${cur_iface}' as listening
+ interface, which currently does not exist.
+ .
+ You should resolve this
  situation by manually editing the configuration file appropriately. Until
  this issue is resolved it is likely that mopd will not function correctly.
 
 Template: mopd/interface
 Type: select
-_Choices: other, all, ${choices}
-_Description: Interface:
+#flag:translate!:3
+__Choices: other, all, ${choices}
+_Description: Interface for mopd:
  Please choose the interface you would like to run mopd on, or select
- 'other' if the interface is not in this list, select 'all' if you would
- like mopd to listen on all interfaces.
+ 'other' if the interface is not in this list.
+ .
+ If you want mopd to listen on all interfaces, please choose 'all'.
--- ../mopd.old/debian/control	2009-01-02 20:14:38.000000000 +0000
+++ debian/control	2009-01-02 21:03:03.000000000 +0000
@@ -8,7 +8,8 @@
 Package: mopd
 Architecture: any
 Depends: ${shlibs:Depends}, debconf | debconf-2.0
-Description: The Maintenance Operations Protocol (MOP) loader daemon
- The MOP daemon services MOP load requests on one or all Ethernet interfaces.
- Normally, a filename (uppercase and ending in .SYS) is included in the load 
- request.
+Description: Maintenance Operations Protocol loader daemon
+ This daemon services load requests on one or all Ethernet interfaces using
+ the DEC Maintenance Operations Protocol. Normally, a filename (uppercase
+ and ending in .SYS) is included in the load request; this is looked for in
+ /tftpboot/mop by default and may be used as a netboot image.
Template: mopd/other_interface
Type: string
_Description: Interface for mopd:
 Please enter the interface you would like to run mopd on.

Template: mopd/bad_interface
Type: error
_Description: Nonexistent interface for mopd
 The MOP daemon configuration already exists as /etc/mopd.conf.
 .
 However, that configuration file specifies '${cur_iface}' as listening
 interface, which currently does not exist.
 .
 You should resolve this
 situation by manually editing the configuration file appropriately. Until
 this issue is resolved it is likely that mopd will not function correctly.

Template: mopd/interface
Type: select
#flag:translate!:3
__Choices: other, all, ${choices}
_Description: Interface for mopd:
 Please choose the interface you would like to run mopd on, or select
 'other' if the interface is not in this list.
 .
 If you want mopd to listen on all interfaces, please choose 'all'.
Source: mopd
Section: net
Priority: extra
Maintainer: Christine Caulfield <christine.caulfield@googlemail.com>
Build-Depends: debhelper (>= 4.1.16), libelfg0-dev
Standards-Version: 3.5.6.0

Package: mopd
Architecture: any
Depends: ${shlibs:Depends}, debconf | debconf-2.0
Description: Maintenance Operations Protocol loader daemon
 This daemon services load requests on one or all Ethernet interfaces using
 the DEC Maintenance Operations Protocol. Normally, a filename (uppercase
 and ending in .SYS) is included in the load request; this is looked for in
 /tftpboot/mop by default and may be used as a netboot image.

Reply to: