Re: [RFR] templates://openvpn/{templates}
Christian Perrier wrote:
> Your review should be sent as an answer to this mail.
One I don't have much to say about.
> Template: openvpn/create_tun
[...]
> + You should not choose this option if you're using devfs.
[...]
> Split in paragraphs for being clearer. I however wonder whether
> mentioning devfs is really worth it. It is obsolete, IIRC.
I hope it isn't so obsolete as to be non-udev-ready.
> Template: openvpn/stop2upgrade
[...]
> + This option will take effect for the next upgrade.
[...]
> "Take effect" + in the upgrade or "for the upgrade". Or something
> else? ("at next upgrade"?)
Works for me.
> Package: openvpn
[...]
> - OpenVPN uses all of the encryption, authentication, and certification features
> + OpenVPN uses encryption, authentication, and certification features
> of the OpenSSL library (any cipher, key size, or HMAC digest).
>
> I found the original sentence somewhat waird and simplified it a little.
No, it worked in the original; foo uses all of the bar features
of the baz library. Perhaps it would be clearer as
OpenVPN uses all of the encryption, authentication, and certification features
provided by the OpenSSL library (any cipher, key size, or HMAC digest).
(But your version still works.)
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
Reply to: