Re: Request for package review
Roberto C. Sánchez wrote:
> [ Please CC me as I am not subscribed to debian-l10n-english ]
>
> I would like for the new shorewall-* packages to be reviewed. The
> source packages are:
>
> - shorewall-common
> - shorewall-lite
> - shorewall-shell
> - shorewall-perl
> - shorewall-doc
>
> The versions which need review are in experimental (version 4.0.5-2 for
> all of them).
In shorewall-common.templates:
> Template: shorewall-common/dont_restart
> Type: note
> _Description: Shorewall won't be restarted automatically
Phrased like that it sounds like debconf abuse; perhaps it should be
_Description: Shorewall requires manual restart
> This will prevent network blackout due to changes in configuration files.
Has to become self-supporting (especially after the above change):
Shorewall won't be restarted automatically, to prevent changes in
configuration files causing network blackouts.
> .
> Check your configuration and then restart Shorewall issuing:
> .
> invoke-rc.d shorewall restart
> .
> or
> .
> /etc/init.d/shorewall restart
No need for all that much whitespace.
.
Check the current configuration and then restart Shorewall with
'invoke-rc.d shorewall restart' or '/etc/init.d/shorewall restart'.
(I'd also consider throwing out one of those two, but I can't decide
which.)
> Template: shorewall-common/major_release
> Type: boolean
> _Description: Do you want to restart Shorewall right now?
This is getting personal - it doesn't need to be a sentence anyway:
_Description: Restart Shorewall now?
(I presume this one appears in cases where dont_restart doesn't...)
> This is a major release of Shorewall that introduces some changes in the
> configuration files. You have to check carefully your configuration before
> restarting your firewall to avoid failures and network blackout. The changes
> are listed in /usr/share/doc/shorewall/releasenotes.txt.gz.
Surely .../shorewall-COMMON/...? I'd say something like:
This is a major release of Shorewall which introduces changes in the
configuration files (see /usr/share/doc/shorewall-common/releasenotes.txt.gz).
To avoid the risk of network blackouts its configuration needs to have
been checked carefully before the firewall is restarted.
(Is it worth putting it in a NEWS.Debian file so apt-listchanges
displays it?)
The only problem I see in the control files is outside the scope of
a d-l-e review:
> Suggests: shorewall-doc, kernel-image-2.4 | kernel-image-2.6 | linux-image-2.6, make
Lenny doesn't support 2.4 kernels, does it?
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
--- shorewall-common.templates.old 2007-11-12 16:26:55.000000000 +0000
+++ shorewall-common.templates.new 2007-11-12 17:44:44.000000000 +0000
@@ -1,21 +1,16 @@
Template: shorewall-common/dont_restart
Type: note
-_Description: Shorewall won't be restarted automatically
- This will prevent network blackout due to changes in configuration files.
+_Description: Shorewall requires manual restart
+ Shorewall won't be restarted automatically, to prevent changes in
+ configuration files causing network blackouts.
.
- Check your configuration and then restart Shorewall issuing:
- .
- invoke-rc.d shorewall restart
- .
- or
- .
- /etc/init.d/shorewall restart
+ Check the current configuration and then restart Shorewall with
+ 'invoke-rc.d shorewall restart' or '/etc/init.d/shorewall restart'.
Template: shorewall-common/major_release
Type: boolean
-_Description: Do you want to restart Shorewall right now?
- This is a major release of Shorewall that introduces some changes in the
- configuration files. You have to check carefully your configuration before
- restarting your firewall to avoid failures and network blackout. The changes
- are listed in /usr/share/doc/shorewall/releasenotes.txt.gz.
-
+_Description: Restart Shorewall now?
+ This is a major release of Shorewall which introduces changes in the
+ configuration files (see /usr/share/doc/shorewall-common/releasenotes.txt.gz).
+ To avoid the risk of network blackouts its configuration needs to have
+ been checked carefully before the firewall is restarted.
Reply to: