Please find, for review, the debconf templates and packages descriptions for the playmidi source package. This review will last from Friday, November 09, 2007 to Monday, November 19, 2007. Please send reviews as unified diffs (diff -u) against the original files. Comments about your proposed changes will be appreciated. Your review should be sent as an answer to this mail. When appropriate, I will send intermediate requests for review, with "[RFRn]" (n>=2) as a subject tag. When we will reach a consensus, I send a "Last Chance For Comments" mail with "[LCFC]" as a subject tag. Finally, the reviewed templates will be sent to the package maintainer as a bug report, and a mail will be sent to this list with "[BTS]" as a subject tag. Rationale: --- ../playmidi.old/debian/templates 2007-11-01 07:00:31.546535179 +0000 +++ debian/templates 2007-11-05 05:05:59.640901597 +0000 @@ -1,18 +1,16 @@ Template: playmidi/options Type: string -_Description: Options for playmidi when invoked through MIME - This package sets up a MIME entry which allows your mail user agent and - other applications to play MIDI files. As playmidi doesn't have a - proper configuration file yet, you'll need to specify any options - required for it to work with your sound hardware. +_Description: Options for playmidi when invoked through MIME: Add final colon + The playmidi package sets up a MIME entry which allows mail user agents + and other applications to play MIDI files. "This" package is not always obvious when installed along with many packages. The second sentence goes into its own paragraph: . - If you have an external MIDI device or an Ensoniq SoundScape, Turtle - Beach WaveFront or WaveBlaster sound card, use `-e'. + In order for playmidi to work properly, you may need to specify + hardware-specific options: . - If you have a Sound Blaster AWE32, use `-a'. + '-e': external MIDI device, Ensoniq SoundScape, Turtle + Beach WaveFront or WaveBlaster sound card; + '-a': Sound Blaster AWE32; + '-g': Gravis Ultrasound. Instead of the "if you have" wording, use a more neutral one to avoid implying that all users own what's in the computer they use..:-) . - If you have a Gravis Ultrasound, use `-g'. - . - Otherwise, try leaving this blank -- many cards will work without extra - flags. If you change your mind later, edit - `/etc/playmidi/playmidi.conf'. + Most other cards will work without any specific options and this field + may then be left blank. This setting is kept in /etc/playmidi/playmidi.conf. Slightly more neutral and less "spoken" wording. --- ../playmidi.old/debian/control 2007-11-01 07:00:31.546535179 +0000 +++ debian/control 2007-11-05 05:07:44.135438764 +0000 @@ -12,8 +12,8 @@ Suggests: awesfx Description: MIDI player Playmidi is a MIDI file player that will play back using FM, GUS, - SoundBlaster or external MIDI. It also supports Creative Music - Files (CMF) and Microsoft RIFF (RMI) files and large MIDI archives + SoundBlaster or external MIDI. It also supports Creative Music + Files (CMF), Microsoft RIFF (RMI) files and large MIDI archives from games such as Ultima 7. Remove double spaces after sentence dots . - There are two interfaces: text and X. + The player may be used with a text or an X interface. Avoid the "there are" style. --
Template: playmidi/options Type: string _Description: Options for playmidi when invoked through MIME: The playmidi package sets up a MIME entry which allows mail user agents and other applications to play MIDI files. . In order for playmidi to work properly, you may need to specify hardware-specific options: . '-e': external MIDI device, Ensoniq SoundScape, Turtle Beach WaveFront or WaveBlaster sound card; '-a': Sound Blaster AWE32; '-g': Gravis Ultrasound. . Most other cards will work without any specific options and this field may then be left blank. This setting is kept in /etc/playmidi/playmidi.conf.
--- ../playmidi.old/debian/templates 2007-11-01 07:00:31.546535179 +0000 +++ debian/templates 2007-11-05 05:05:59.640901597 +0000 @@ -1,18 +1,16 @@ Template: playmidi/options Type: string -_Description: Options for playmidi when invoked through MIME - This package sets up a MIME entry which allows your mail user agent and - other applications to play MIDI files. As playmidi doesn't have a - proper configuration file yet, you'll need to specify any options - required for it to work with your sound hardware. +_Description: Options for playmidi when invoked through MIME: + The playmidi package sets up a MIME entry which allows mail user agents + and other applications to play MIDI files. . - If you have an external MIDI device or an Ensoniq SoundScape, Turtle - Beach WaveFront or WaveBlaster sound card, use `-e'. + In order for playmidi to work properly, you may need to specify + hardware-specific options: . - If you have a Sound Blaster AWE32, use `-a'. + '-e': external MIDI device, Ensoniq SoundScape, Turtle + Beach WaveFront or WaveBlaster sound card; + '-a': Sound Blaster AWE32; + '-g': Gravis Ultrasound. . - If you have a Gravis Ultrasound, use `-g'. - . - Otherwise, try leaving this blank -- many cards will work without extra - flags. If you change your mind later, edit - `/etc/playmidi/playmidi.conf'. + Most other cards will work without any specific options and this field + may then be left blank. This setting is kept in /etc/playmidi/playmidi.conf. --- ../playmidi.old/debian/control 2007-11-01 07:00:31.546535179 +0000 +++ debian/control 2007-11-05 05:07:44.135438764 +0000 @@ -12,8 +12,8 @@ Suggests: awesfx Description: MIDI player Playmidi is a MIDI file player that will play back using FM, GUS, - SoundBlaster or external MIDI. It also supports Creative Music - Files (CMF) and Microsoft RIFF (RMI) files and large MIDI archives + SoundBlaster or external MIDI. It also supports Creative Music + Files (CMF), Microsoft RIFF (RMI) files and large MIDI archives from games such as Ultima 7. . - There are two interfaces: text and X. + The player may be used with a text or an X interface.
Source: playmidi Section: sound Priority: optional Maintainer: Darren Salt <linux@youmustbejoking.demon.co.uk> Standards-Version: 3.7.2 Build-Depends: debhelper (>= 4.1.16), libncurses5-dev | libncurses-dev, libxaw7-dev, libxt-dev Package: playmidi Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends} Conflicts: suidmanager (<< 0.50) Suggests: awesfx Description: MIDI player Playmidi is a MIDI file player that will play back using FM, GUS, SoundBlaster or external MIDI. It also supports Creative Music Files (CMF), Microsoft RIFF (RMI) files and large MIDI archives from games such as Ultima 7. . The player may be used with a text or an X interface.
Attachment:
signature.asc
Description: Digital signature