[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://fltk1.1/{libfltk1.1-dev.templates}



Please find, for review, the debconf templates and packages descriptions for the fltk1.1 source package.

This review will last from Thursday, November 08, 2007 to Sunday, November 18, 2007.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- ../fltk1.1.old/debian/libfltk1.1-dev.templates	2007-11-08 05:15:42.202188111 +0000
+++ debian/libfltk1.1-dev.templates	2007-11-08 06:43:21.567052103 +0000
@@ -3,6 +3,8 @@
 Default: false
 _Description: Make .h links to <FL/*.H>?
  For compatibility with some older code, FLTK used to make its C++-specific
- headers available as <FL/*.h> as well as <FL/*.H>; however, the
- lowercase-h names are deprecated, and we recommend eliminating them from
- your code regardless.
+ headers available as <FL/*.h> as well as <FL/*.H>. However, the
+ lowercase-h names are deprecated and eliminating them from
+ source code is recommended.
+ .
+ Please choose whether such compatibility links should be created.

Simplify the sentence structure by removing the semi-colon.

Use passive voice instead of discouraged use of first person.

Reformulate the question as a separate paragraph so that users have a
clear idea of what's being asked.

--- ../fltk1.1.old/debian/control	2007-11-08 05:15:42.202188111 +0000
+++ debian/control	2007-11-08 06:50:11.090389509 +0000
@@ -15,13 +15,15 @@
 Suggests: fltk1.1-doc
 Conflicts: libfltk1-dev
 Replaces: libfltk1-dev
-Description: Fast Light (Toolkit) User Interface Designer
- Fluid is an interactive GUI designer for the Fast Light Toolkit,
- allowing graphical development of FLTK-based user interfaces.  It
- natively works with (textual) .fl files, but also includes rough
- support for reading .fd files produced by fdesign (in libforms-bin).
- (FLTK is a very nice LGPLed cross-platform graphical user interface
- toolkit originally based on libForms.)
+Description: Fast Light Toolkit - user interface designer
+ Fast Light Toolkit (FLTK) is a LGPLed cross-platform graphical user interface
+ toolkit originally based on libForms.
+ .
+ This package provides Fluid, an interactive GUI designer for FLTK,
+ allowing graphical development of FLTK-based user
+ interfaces. It natively works with (textual) .fl files, but also
+ includes rough support for reading .fd files produced by fdesign (in
+ libforms-bin).

1) Use a "common description - specific description" style for the
synopsis. Ditto for all other packages

2) Use a common paragraph for all packages, describing what is
FLTK. Avoid "very nice" in it as this is not really factual..:)

"LGPLed" could be avoided too. After all, the licence is already given
in debian/copyright.

The second paragraph is specific for each binary package. We use the
"This package provides...." style

Similar changes in all other packages. Only specific comments follow:
 
 Package: fltk1.1-games
 Section: games
 Architecture: any
 Depends: ${shlibs:Depends}
-Description: Fast Light Toolkit example games: checkers, sudoku
- Fltk1.1-games contains the example games that accompany FLTK, a very
- nice LGPLed cross-platform graphical user interface toolkit
- originally based on libForms.  Specifically, it contains the
- following two programs:
-  * flcheckers - classic board game, also known as draughts
-  * flsudoku - Sudoku puzzle (place numbers in a grid)
+Description: Fast Light Toolkit - example games: checkers, sudoku
+ Fast Light Toolkit (FLTK) is a LGPLed cross-platform graphical user interface
+ toolkit originally based on libForms.
+ .
+ Fltk1.1-games contains the example games that accompany FLTK.
+ Specifically, it contains the following two programs:
+  - flcheckers: classic board game, also known as draughts;
+  - flsudoku:   Sudoku puzzle (place numbers in a grid).

Use the "standard" enumeration style.

-- 


Template: libfltk1.1-dev/header-links
Type: boolean
Default: false
_Description: Make .h links to <FL/*.H>?
 For compatibility with some older code, FLTK used to make its C++-specific
 headers available as <FL/*.h> as well as <FL/*.H>. However, the
 lowercase-h names are deprecated and eliminating them from
 source code is recommended.
 .
 Please choose whether such compatibility links should be created.
--- ../fltk1.1.old/debian/libfltk1.1-dev.templates	2007-11-08 05:15:42.202188111 +0000
+++ debian/libfltk1.1-dev.templates	2007-11-08 06:43:21.567052103 +0000
@@ -3,6 +3,8 @@
 Default: false
 _Description: Make .h links to <FL/*.H>?
  For compatibility with some older code, FLTK used to make its C++-specific
- headers available as <FL/*.h> as well as <FL/*.H>; however, the
- lowercase-h names are deprecated, and we recommend eliminating them from
- your code regardless.
+ headers available as <FL/*.h> as well as <FL/*.H>. However, the
+ lowercase-h names are deprecated and eliminating them from
+ source code is recommended.
+ .
+ Please choose whether such compatibility links should be created.
--- ../fltk1.1.old/debian/control	2007-11-08 05:15:42.202188111 +0000
+++ debian/control	2007-11-08 06:50:11.090389509 +0000
@@ -15,13 +15,15 @@
 Suggests: fltk1.1-doc
 Conflicts: libfltk1-dev
 Replaces: libfltk1-dev
-Description: Fast Light (Toolkit) User Interface Designer
- Fluid is an interactive GUI designer for the Fast Light Toolkit,
- allowing graphical development of FLTK-based user interfaces.  It
- natively works with (textual) .fl files, but also includes rough
- support for reading .fd files produced by fdesign (in libforms-bin).
- (FLTK is a very nice LGPLed cross-platform graphical user interface
- toolkit originally based on libForms.)
+Description: Fast Light Toolkit - user interface designer
+ Fast Light Toolkit (FLTK) is a LGPLed cross-platform graphical user interface
+ toolkit originally based on libForms.
+ .
+ This package provides Fluid, an interactive GUI designer for FLTK,
+ allowing graphical development of FLTK-based user
+ interfaces. It natively works with (textual) .fl files, but also
+ includes rough support for reading .fd files produced by fdesign (in
+ libforms-bin).
 
 Package: libfltk1.1-dev
 Section: libdevel
@@ -32,10 +34,12 @@
 Provides: libfltk-dev
 Conflicts: libfltk-dev
 Replaces: libfltk-dev
-Description: Fast Light Toolkit development files
- Libfltk1.1-dev contains the files necessary for compiling programs
- that depend on FLTK, a very nice LGPLed cross-platform C++ GUI
- (graphical user interface) toolkit originally based on libForms.
+Description: Fast Light Toolkit - development files
+ Fast Light Toolkit (FLTK) is a LGPLed cross-platform graphical user interface
+ toolkit originally based on libForms.
+ .
+ This package provides the files necessary for compiling programs
+ that depend on FLTK.
 
 Package: libfltk1.1
 Section: libs
@@ -43,10 +47,12 @@
 Depends: ${shlibs:Depends}
 Conflicts: libfltk1.1c102
 Replaces: libfltk1.1c102
-Description: Fast Light Toolkit shared libraries
+Description: Fast Light Toolkit - shared libraries
+ Fast Light Toolkit (FLTK) is a LGPLed cross-platform graphical user interface
+ toolkit originally based on libForms.
+ .
  Libfltk1.1 contains the files necessary for running programs
- dynamically linked with FLTK, a very nice LGPLed cross-platform
- graphical user interface toolkit originally based on libForms.
+ dynamically linked with FLTK.
 
 Package: libfltk1.1-dbg
 Section: libdevel
@@ -56,10 +62,13 @@
 Recommends: gdb (>= 6.0)
 Conflicts: libfltk1.1c102-dbg
 Replaces: libfltk1.1c102-dbg
-Description: Fast Light Toolkit shared libraries (debugging symbols)
+Description: Fast Light Toolkit - shared libraries with debugging symbols
+ Fast Light Toolkit (FLTK) is a LGPLed cross-platform graphical user interface
+ toolkit originally based on libForms.
+ .
  This package is useful to provide a backtrace with symbol names in a
  debugger; this facilitates interpretation of core dumps, and aids in finding
- logic errors in programs using the libraries in this package (or the
+ logic errors in programs using the libraries in the package (or the
  libraries themselves).
  .
  Non-programmers will likely have little use for this package.  See the
@@ -68,19 +77,22 @@
 Package: fltk1.1-doc
 Section: doc
 Architecture: all
-Description: Fast Light Toolkit documentation
- Fltk1.1-doc contains documentation for FLTK, a very nice LGPLed
- cross-platform graphical user interface toolkit originally based on
- libForms, including a chapter on its user interface designer (fluid).
+Description: Fast Light Toolkit - documentation
+ Fast Light Toolkit (FLTK) is a LGPLed cross-platform graphical user interface
+ toolkit originally based on libForms.
+ .
+ This package provides documentation for FLTK, including a chapter on
+ its user interface designer (fluid).
 
 Package: fltk1.1-games
 Section: games
 Architecture: any
 Depends: ${shlibs:Depends}
-Description: Fast Light Toolkit example games: checkers, sudoku
- Fltk1.1-games contains the example games that accompany FLTK, a very
- nice LGPLed cross-platform graphical user interface toolkit
- originally based on libForms.  Specifically, it contains the
- following two programs:
-  * flcheckers - classic board game, also known as draughts
-  * flsudoku - Sudoku puzzle (place numbers in a grid)
+Description: Fast Light Toolkit - example games: checkers, sudoku
+ Fast Light Toolkit (FLTK) is a LGPLed cross-platform graphical user interface
+ toolkit originally based on libForms.
+ .
+ Fltk1.1-games contains the example games that accompany FLTK.
+ Specifically, it contains the following two programs:
+  - flcheckers: classic board game, also known as draughts;
+  - flsudoku:   Sudoku puzzle (place numbers in a grid).
Source: fltk1.1
Section: libs
Priority: optional
Maintainer: Aaron M. Ucko <ucko@debian.org>
Build-Depends: cdbs (>= 0.4.39-0.1), debhelper (>= 5), libjpeg62-dev, libpng12-dev, libxft-dev (>> 2.1.2), libxext-dev, libxinerama-dev, libx11-dev, zlib1g-dev | libz-dev, libgl1-mesa-dev | libgl-dev, libglu1-mesa-dev | libglu-dev, libasound2-dev [!hurd-i386 !kfreebsd-i386 !kfreebsd-amd64], imagemagick
Build-Depends-Indep: htmldoc
Standards-Version: 3.7.2
Homepage: http://www.fltk.org/

Package: fluid
Section: devel
Architecture: any
Depends: ${shlibs:Depends}
Recommends: libfltk1.1-dev
Suggests: fltk1.1-doc
Conflicts: libfltk1-dev
Replaces: libfltk1-dev
Description: Fast Light Toolkit - user interface designer
 Fast Light Toolkit (FLTK) is a LGPLed cross-platform graphical user interface
 toolkit originally based on libForms.
 .
 This package provides Fluid, an interactive GUI designer for FLTK,
 allowing graphical development of FLTK-based user
 interfaces. It natively works with (textual) .fl files, but also
 includes rough support for reading .fd files produced by fdesign (in
 libforms-bin).

Package: libfltk1.1-dev
Section: libdevel
Architecture: any
Depends: ${misc:Depends}, libfltk1.1 (= ${binary:Version}), libx11-dev
Recommends: libgl1-mesa-dev | libgl-dev
Suggests: fltk1.1-doc, fluid, libglu1-mesa-dev | libglu-dev, libjpeg62-dev, libpng12-0-dev, libxft-dev (>> 2.1.2), libxext-dev, libxinerama-dev, zlib1g-dev | libz-dev
Provides: libfltk-dev
Conflicts: libfltk-dev
Replaces: libfltk-dev
Description: Fast Light Toolkit - development files
 Fast Light Toolkit (FLTK) is a LGPLed cross-platform graphical user interface
 toolkit originally based on libForms.
 .
 This package provides the files necessary for compiling programs
 that depend on FLTK.

Package: libfltk1.1
Section: libs
Architecture: any
Depends: ${shlibs:Depends}
Conflicts: libfltk1.1c102
Replaces: libfltk1.1c102
Description: Fast Light Toolkit - shared libraries
 Fast Light Toolkit (FLTK) is a LGPLed cross-platform graphical user interface
 toolkit originally based on libForms.
 .
 Libfltk1.1 contains the files necessary for running programs
 dynamically linked with FLTK.

Package: libfltk1.1-dbg
Section: libdevel
Priority: extra
Architecture: any
Depends: libfltk1.1 (= ${binary:Version})
Recommends: gdb (>= 6.0)
Conflicts: libfltk1.1c102-dbg
Replaces: libfltk1.1c102-dbg
Description: Fast Light Toolkit - shared libraries with debugging symbols
 Fast Light Toolkit (FLTK) is a LGPLed cross-platform graphical user interface
 toolkit originally based on libForms.
 .
 This package is useful to provide a backtrace with symbol names in a
 debugger; this facilitates interpretation of core dumps, and aids in finding
 logic errors in programs using the libraries in the package (or the
 libraries themselves).
 .
 Non-programmers will likely have little use for this package.  See the
 libfltk1.1 package for more information.

Package: fltk1.1-doc
Section: doc
Architecture: all
Description: Fast Light Toolkit - documentation
 Fast Light Toolkit (FLTK) is a LGPLed cross-platform graphical user interface
 toolkit originally based on libForms.
 .
 This package provides documentation for FLTK, including a chapter on
 its user interface designer (fluid).

Package: fltk1.1-games
Section: games
Architecture: any
Depends: ${shlibs:Depends}
Description: Fast Light Toolkit - example games: checkers, sudoku
 Fast Light Toolkit (FLTK) is a LGPLed cross-platform graphical user interface
 toolkit originally based on libForms.
 .
 Fltk1.1-games contains the example games that accompany FLTK.
 Specifically, it contains the following two programs:
  - flcheckers: classic board game, also known as draughts;
  - flsudoku:   Sudoku puzzle (place numbers in a grid).

Attachment: signature.asc
Description: Digital signature


Reply to: