Please find, for review, the debconf templates and packages descriptions for the rkhunter source package. This review will last from Monday, November 05, 2007 to Thursday, November 15, 2007. Please send reviews as unified diffs (diff -u) against the original files. Comments about your proposed changes will be appreciated. Your review should be sent as an answer to this mail. When appropriate, I will send intermediate requests for review, with "[RFRn]" (n>=2) as a subject tag. When we will reach a consensus, I send a "Last Chance For Comments" mail with "[LCFC]" as a subject tag. Finally, the reviewed templates will be sent to the package maintainer as a bug report, and a mail will be sent to this list with "[BTS]" as a subject tag. Rationale: --- ../rkhunter.old/debian/templates 2007-10-30 22:29:05.577953562 +0100 +++ debian/templates 2007-11-05 06:44:03.062760816 +0100 @@ -1,22 +1,23 @@ Template: rkhunter/cron_daily_run Type: boolean -_Description: Activate daily run? - Choose this option if you want rkhunter to be run automatically - via cron.daily. +_Description: Activate daily run of rkunter? Re-specify what daily run is planned (may be useful when the package is installed along many other packages). + If you choose this option, rkhunter will be run automatically + by a daily cron job. Use our "standard" wording for such situations. "cron.daily" could be considered as jargon (not every Debian user is aware that such thing exists). Let's use a more generic wording (even if "cron job" is still slitghtly jargonic).. Template: rkhunter/cron_db_update Type: boolean -_Description: Activate weekly database update? - Choose this option if you want rkhunter databases to be - updated automatically via cron.weekly. +_Description: Activate weekly rkhunter databases update? + If you choose this option, rkhunter databases will be + updated automatically by a weekly cron job. About the same changes. Template: rkhunter/apt_autogen Type: boolean Default: false -_Description: Update file properties database automatically? - rkhunter can be configured so that the file properties database - is updated automatically by apt. - Default is not to enable this feature as the file properties - database update can be slow on some older or low-resource systems. - Even if enabled, the database won't be updated by apt if the +_Description: Automatically update rkhunter file properties database? + The file properties database can be updated automatically + by the package management system. + . + This feature is not enabled by default as + database updates may be slow on low-end machines. + Even if it is enabled, the database won't be updated if the The key word here is "automatically", so let's move it first. Native speakers, should this be "rkhunter'S" for the possessive form? The first paragraph avoids the leading lowercase letter. Avoid mentioning "apt" specifically (could be 'aptitude' or whatever else) and, as a consequence, let's be less jargonic... Split the "Default is" paragraph in its own paragraph. IMHO "Default is..." is not grammatically correct. I'm not entirely fond of my proposed "low-end machines". I'm usually not enthusiast about talking of "machines" but never found a better alternative (maybe "computers" would be good, after all, even if, in these days of virtualisation, it's quite restrictive). 'hashes' test is disabled in rkhunter configuration. --- ../rkhunter.old/debian/control 2007-10-30 22:29:05.577953562 +0100 +++ debian/control 2007-11-04 09:10:51.803839209 +0100 @@ -13,17 +13,17 @@ Recommends: libmd5-perl, binutils, wget | curl | links | elinks | lynx, iproute Suggests: mailx Description: rootkit, backdoor, sniffer and exploit scanner - Rootkit Hunter scans your system for known and unknown rootkits, + Rootkit Hunter scans systems for known and unknown rootkits, backdoors, sniffers and exploits. Unpersonnalization (the system is not necessarily "your" system . Some of the tests it does: - - MD5 hash compare - - Look for default files used by rootkits - - Wrong file permissions for binaries - - Look for suspected strings in LKM and KLD modules - - Look for hidden files - - Optional scan within plaintext and binary files + - MD5 hash comparisons; + - search for default files used by rootkits; + - binary files permissions check; + - suspect strings in LKM and KLD modules; + - hidden files; + - optional scan within plaintext and binary files. 'standard' enumeration style with only 2 leading spaces and not 3 'comparisons'? Am I correct? That enumeration still lacks consistency. We should either use verbs only or nouns only, not a mix of both. . - Please note that rkhunter does *not* guarantee your system has - not been compromised! You should also run additional tests, e.g. using - chkrootkit and other measures. + Only using rkhunter does not guarantee that a system is not + compromised. Running additional tests, such as chkrootkit, is + recommended. "Please note" in packages' descriptions should probably be discouraged as they're not exactly documentation (another thing to add to the style guide?). Is 'using' as subject of the verb a correct grammatical construction in English (it is in French). Same for 'Running tests'. Native speakers, help..:-) --
Template: rkhunter/cron_daily_run Type: boolean _Description: Activate daily run of rkunter? If you choose this option, rkhunter will be run automatically by a daily cron job. Template: rkhunter/cron_db_update Type: boolean _Description: Activate weekly rkhunter databases update? If you choose this option, rkhunter databases will be updated automatically by a weekly cron job. Template: rkhunter/apt_autogen Type: boolean Default: false _Description: Automatically update rkhunter file properties database? The file properties database can be updated automatically by the package management system. . This feature is not enabled by default as database updates may be slow on low-end machines. Even if it is enabled, the database won't be updated if the 'hashes' test is disabled in rkhunter configuration.
--- ../rkhunter.old/debian/templates 2007-10-30 22:29:05.577953562 +0100 +++ debian/templates 2007-11-05 06:44:03.062760816 +0100 @@ -1,22 +1,23 @@ Template: rkhunter/cron_daily_run Type: boolean -_Description: Activate daily run? - Choose this option if you want rkhunter to be run automatically - via cron.daily. +_Description: Activate daily run of rkunter? + If you choose this option, rkhunter will be run automatically + by a daily cron job. Template: rkhunter/cron_db_update Type: boolean -_Description: Activate weekly database update? - Choose this option if you want rkhunter databases to be - updated automatically via cron.weekly. +_Description: Activate weekly rkhunter databases update? + If you choose this option, rkhunter databases will be + updated automatically by a weekly cron job. Template: rkhunter/apt_autogen Type: boolean Default: false -_Description: Update file properties database automatically? - rkhunter can be configured so that the file properties database - is updated automatically by apt. - Default is not to enable this feature as the file properties - database update can be slow on some older or low-resource systems. - Even if enabled, the database won't be updated by apt if the +_Description: Automatically update rkhunter file properties database? + The file properties database can be updated automatically + by the package management system. + . + This feature is not enabled by default as + database updates may be slow on low-end machines. + Even if it is enabled, the database won't be updated if the 'hashes' test is disabled in rkhunter configuration. --- ../rkhunter.old/debian/control 2007-10-30 22:29:05.577953562 +0100 +++ debian/control 2007-11-04 09:10:51.803839209 +0100 @@ -13,17 +13,17 @@ Recommends: libmd5-perl, binutils, wget | curl | links | elinks | lynx, iproute Suggests: mailx Description: rootkit, backdoor, sniffer and exploit scanner - Rootkit Hunter scans your system for known and unknown rootkits, + Rootkit Hunter scans systems for known and unknown rootkits, backdoors, sniffers and exploits. . Some of the tests it does: - - MD5 hash compare - - Look for default files used by rootkits - - Wrong file permissions for binaries - - Look for suspected strings in LKM and KLD modules - - Look for hidden files - - Optional scan within plaintext and binary files + - MD5 hash comparisons; + - search for default files used by rootkits; + - binary files permissions check; + - suspect strings in LKM and KLD modules; + - hidden files; + - optional scan within plaintext and binary files. . - Please note that rkhunter does *not* guarantee your system has - not been compromised! You should also run additional tests, e.g. using - chkrootkit and other measures. + Only using rkhunter does not guarantee that a system is not + compromised. Running additional tests, such as chkrootkit, is + recommended.
Source: rkhunter
Section: admin
Priority: optional
Maintainer: Micah Anderson <micah@debian.org>
Uploaders: Julien Valroff <julien@kirya.net>
Build-Depends: debhelper (>= 5.0.0), dpatch, po-debconf
Standards-Version: 3.7.2
Homepage: http://rkhunter.sourceforge.net
Package: rkhunter
Architecture: all
Depends: file, exim4 | postfix | sendmail | mail-transport-agent, perl, net-tools, ${misc:Depends}
Recommends: libmd5-perl, binutils, wget | curl | links | elinks | lynx, iproute
Suggests: mailx
Description: rootkit, backdoor, sniffer and exploit scanner
Rootkit Hunter scans systems for known and unknown rootkits,
backdoors, sniffers and exploits.
.
Some of the tests it does:
- MD5 hash comparisons;
- search for default files used by rootkits;
- binary files permissions check;
- suspect strings in LKM and KLD modules;
- hidden files;
- optional scan within plaintext and binary files.
.
Only using rkhunter does not guarantee that a system is not
compromised. Running additional tests, such as chkrootkit, is
recommended.
Attachment:
signature.asc
Description: Digital signature