[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://spamprobe/{templates}



Christian Perrier wrote:
> Your review should be sent as an answer to this mail.

>  Template: spamprobe/db_upgrade

> + All spamprobe users on this system should be informed of this change
> + and suggested to read the README.Debian file.

Fine except for "users [...] should be [...] suggested"; "suggested"
doesn't fit, but "advised" does (you "suggest stuff to people", but
"advise people of stuff", so they passivise differently).
 
>  Description: Bayesian spam filter
> - This spam filter is based on the famous Paul Graham article. It
> - uses a database (BerkeleyDB or simpler hash file) to store one and
> + This package provide a spam filter based on an article by Paul Graham. It
> + uses a database (either BerkeleyDB or a simpler hash file) to store one and
> 
> The article is famous only for people who think it is..:-)...let's be
> more neutral and factual.

If we're going to mention Paul Graham's article at all, it seems to
me we should mention its *title*, too.   I'd heard of that, but I'd
forgotten who wrote it...

    This package provides a spam filter based on the article 'A Plan for Spam',
    by Paul Graham. It uses a database (either BerkeleyDB or a simpler hash
    file) to store one- and two-word phrases.

(Oh, and s/provide/provides/, and extra hyphens.)

>   two word phrases. Only certain headers are analyzed and HTML tags are
>   ignored to prevent false positives of legitimate HTML emails. Image
>   attachments are considered as words that can signal a spam. It can be

Do people say "a spam"?  To me it's a non-count noun: I'd say "may
indicate spam".
-- 
JBR
Ankh kak! (Ancient Egyptian blessing)
--- ../spamprobe.old/debian/templates	2007-09-12 00:10:17.000000000 +0100
+++ debian/templates	2007-09-17 14:50:57.000000000 +0100
@@ -1,15 +1,14 @@
 Template: spamprobe/db_upgrade
 Type: note
 _Description: Upgrading to Berkeley DB 4.6
- Starting with released spamprobe 1.4d-1, database format has changed
- to Berkeley DB 4.6 to the effect that spamprobe will not be able to
- modify existing databases.
+ As of spamprobe 1.4d-1, the database format changed
+ to Berkeley DB 4.6 and spamprobe is no longer able to modify
+ databases using an older format.
  .
  Since there is no general way to locate all existing databases, no
- automatic upgrade is attempted.  A manual upgrade path using
- spamprobe export/import is outlined in spamprobe(1) DATABASE
- MAINTENANCE.
+ automatic upgrade is attempted. A manual upgrade path using
+ spamprobe export/import is outlined in the 'DATABASE MAINTENANCE' section
+ of the spamprobe(1) manual page.
  .
- Please inform all spamprobe users on your system of this change and
- to read README.Debian for further changes.  Sorry for the
- inconvenience.
+ All spamprobe users on this system should be informed of this change
+ and advised to read the README.Debian file.
--- ../spamprobe.old/debian/control	2007-09-12 00:10:17.000000000 +0100
+++ debian/control	2007-09-17 14:50:25.000000000 +0100
@@ -2,7 +2,7 @@
 Section: mail
 Priority: optional
 Maintainer: Nicolas Duboc <nduboc@debian.org>
-Build-Depends: debhelper (>> 4.0.0), po-debconf, libdb4.6-dev, xmlto, libungif4-dev, libpng12-dev, libjpeg62-dev
+Build-Depends: debhelper (>> 4.0.0), libdb4.6-dev, xmlto, libungif4-dev, libpng12-dev, libjpeg62-dev
 Standards-Version: 3.7.2
 
 Package: spamprobe
@@ -10,9 +10,9 @@
 Recommends: procmail | maildrop
 Depends: debconf | debconf-2.0, ${shlibs:Depends}
 Description: Bayesian spam filter
- This spam filter is based on the famous Paul Graham article. It
- uses a database (BerkeleyDB or simpler hash file) to store one and
- two word phrases. Only certain headers are analyzed and HTML tags are
- ignored to prevent false positives of legitimate HTML emails. Image
- attachments are considered as words that can signal a spam. It can be
- simply integrated with procmail or maildrop to filter your spam.
+ This package provides a spam filter based on the article 'A Plan for Spam',
+ by Paul Graham. It uses a database (either BerkeleyDB or a simpler hash file)
+ to store one- and two-word phrases. Only certain headers are analyzed and
+ HTML tags are ignored to prevent false positives of legitimate HTML emails.
+ Image attachments are considered as words that may indicate spam. It can be
+ simply integrated with procmail or maildrop to filter spam on incoming mail.
Template: spamprobe/db_upgrade
Type: note
_Description: Upgrading to Berkeley DB 4.6
 As of spamprobe 1.4d-1, the database format changed
 to Berkeley DB 4.6 and spamprobe is no longer able to modify
 databases using an older format.
 .
 Since there is no general way to locate all existing databases, no
 automatic upgrade is attempted. A manual upgrade path using
 spamprobe export/import is outlined in the 'DATABASE MAINTENANCE' section
 of the spamprobe(1) manual page.
 .
 All spamprobe users on this system should be informed of this change
 and advised to read the README.Debian file.
Source: spamprobe
Section: mail
Priority: optional
Maintainer: Nicolas Duboc <nduboc@debian.org>
Build-Depends: debhelper (>> 4.0.0), libdb4.6-dev, xmlto, libungif4-dev, libpng12-dev, libjpeg62-dev
Standards-Version: 3.7.2

Package: spamprobe
Architecture: any
Recommends: procmail | maildrop
Depends: debconf | debconf-2.0, ${shlibs:Depends}
Description: Bayesian spam filter
 This package provides a spam filter based on the article 'A Plan for Spam',
 by Paul Graham. It uses a database (either BerkeleyDB or a simpler hash file)
 to store one- and two-word phrases. Only certain headers are analyzed and
 HTML tags are ignored to prevent false positives of legitimate HTML emails.
 Image attachments are considered as words that may indicate spam. It can be
 simply integrated with procmail or maildrop to filter spam on incoming mail.

Reply to: