[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://portmap/{templates}



Please find, for review, the debconf templates and packages descriptions for the portmap source package.

This review will last from Saturday, September 01, 2007 to Tuesday, September 11, 2007.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- ../portmap.old/debian/templates	2007-08-27 15:13:18.610015498 +0200
+++ debian/templates	2007-08-28 23:17:28.103514248 +0200
@@ -2,14 +2,13 @@
 Type: boolean
 Default: false
 _Description: Should portmap be bound to the loopback address?
- Portmap by default listens to all IP addresses. However, if you are
- not providing network RPC services to remote clients (you are if you are
- setting up a NFS or NIS server) you can safely bind it to the loopback 
- IP address (127.0.0.1) 
+ By default, portmap listens to all IP addresses. However, if this
+ machine does not provide network RPC services to remote clients, you
+ can safely bind it to the loopback IP address (127.0.0.1).

"By default,...." seems better wording to me

Remove "you are" stuff in favor of neutral wording ("this
machine"). After all, the services are provided by the machine, not
the user..:-)

Remove the confusing mention of NFS or NIS servers.

  .
  This will allow RPC local services (like FAM) to work properly, while
- preventing remote systems from accessing your RPC services.
+ preventing remote systems from accessing the RPC services.

Same rationale than above about who does provide the services

  .
- You can also change this configuration by editing the OPTIONS
- line in the /etc/default/portmap file. If you just don't specify
- the -i option it will bind to all interfaces.
+ This configuration can be changed by editing the OPTIONS
+ line in the /etc/default/portmap file and adapt the use of the -i option
+ to your needs.

More general wording to point the user to "-i"


--- ../portmap.old/debian/control	2007-08-27 15:13:18.610015498 +0200
+++ debian/control	2007-08-28 23:13:15.116193737 +0200
@@ -10,9 +10,9 @@
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}, lsb-base (>= 1.3-9)
 Replaces: netbase (<< 4.00)
-Description: The RPC portmapper
+Description: RPC port mapper

Avoid the use of leading articles in packages descriptions

portmap is "something that maps", hence a mapper. What it does map are
ports....hence breking this in two words.

  Portmap is a server that converts RPC (Remote Procedure Call) program
- numbers into DARPA protocol port numbers.  It must be running in order
+ numbers into DARPA protocol port numbers. It must be running in order

Remove double spaces

Template: portmap/loopback
Type: boolean
Default: false
_Description: Should portmap be bound to the loopback address?
 By default, portmap listens to all IP addresses. However, if this
 machine does not provide network RPC services to remote clients, you
 can safely bind it to the loopback IP address (127.0.0.1).
 .
 This will allow RPC local services (like FAM) to work properly, while
 preventing remote systems from accessing the RPC services.
 .
 This configuration can be changed by editing the OPTIONS
 line in the /etc/default/portmap file and adapt the use of the -i option
 to your needs.
--- ../portmap.old/debian/templates	2007-08-27 15:13:18.610015498 +0200
+++ debian/templates	2007-08-28 23:17:28.103514248 +0200
@@ -2,14 +2,13 @@
 Type: boolean
 Default: false
 _Description: Should portmap be bound to the loopback address?
- Portmap by default listens to all IP addresses. However, if you are
- not providing network RPC services to remote clients (you are if you are
- setting up a NFS or NIS server) you can safely bind it to the loopback 
- IP address (127.0.0.1) 
+ By default, portmap listens to all IP addresses. However, if this
+ machine does not provide network RPC services to remote clients, you
+ can safely bind it to the loopback IP address (127.0.0.1).
  .
  This will allow RPC local services (like FAM) to work properly, while
- preventing remote systems from accessing your RPC services.
+ preventing remote systems from accessing the RPC services.
  .
- You can also change this configuration by editing the OPTIONS
- line in the /etc/default/portmap file. If you just don't specify
- the -i option it will bind to all interfaces.
+ This configuration can be changed by editing the OPTIONS
+ line in the /etc/default/portmap file and adapt the use of the -i option
+ to your needs.
--- ../portmap.old/debian/control	2007-08-27 15:13:18.610015498 +0200
+++ debian/control	2007-08-28 23:13:15.116193737 +0200
@@ -10,9 +10,9 @@
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}, lsb-base (>= 1.3-9)
 Replaces: netbase (<< 4.00)
-Description: The RPC portmapper
+Description: RPC port mapper
  Portmap is a server that converts RPC (Remote Procedure Call) program
- numbers into DARPA protocol port numbers.  It must be running in order
+ numbers into DARPA protocol port numbers. It must be running in order
  to make RPC calls.
  .
  Services that use RPC include NFS and NIS.
Source: portmap
Section: net
Priority: standard
Maintainer: Anibal Monsalve Salazar <anibal@debian.org>
Uploaders: Javier Fernandez-Sanguino Pen~a <jfs@computer.org>
Standards-Version: 3.7.2
Build-Depends: libwrap-dev, debhelper (>= 5)

Package: portmap
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, lsb-base (>= 1.3-9)
Replaces: netbase (<< 4.00)
Description: RPC port mapper
 Portmap is a server that converts RPC (Remote Procedure Call) program
 numbers into DARPA protocol port numbers. It must be running in order
 to make RPC calls.
 .
 Services that use RPC include NFS and NIS.
 .
  Homepage: http://neil.brown.name/portmap/

Attachment: signature.asc
Description: Digital signature


Reply to: