[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [LCFC] templates://lwat/templates



> > Maybe the maintainer can explain us....which would actually mean
> > adding a long description..:)
> 
> That would be good.

They explained this to me and I added a long description to that
"listGroups" thing.


> There are a few outstanding thoughts and questions I have.
> 
>   * Should the templates try and explain what the things are used for,
>     for instance the LDAP server? It seems like someone installing this
>     package would know why they needed to provide one, but taking them
>     out of context it is not clear, so as a reviewer it is tempting to
>     highlight this.

Indeed, explaining what the LDAP server is used ofr is probably out of
scope here.

We still have to remember that users and sysadmins also have
documentation they can read so not everything can be explained in
debconf templates.

>   * Should it define groups, hosts, netgroups etc?

For the above reason, I would say "no".


>   * I assumed that the password limits are applied when a user changes
>     their password, but are they always autogenerated, or can the user
>     not change it, or are the restrictions only on the initial generated
>     password?

That, indeed, should *really* be explained to us by maintainers..:-)

You made such assumption in your proposal. I like it...but we first
need to confirm whether users will be allowed to change their password
and if these rules will apply to both the generated passwords AND the
passwords set by users.


>   * What are uppercase and lowercase characters? Is it locale dependent,
>     or just [A-Z] and [a-z]?

When such minimum numbers are considered, this is about [A-Z], [a-z]


>  Default: ou=Group
>  _Description: Prefix for groups on the LDAP server:
>   Please enter the prefix under which the groups information is
> - stored. Only the last part is needed.
> + stored. If one is not used then "ou=" is a valid answer.

I happen to prefer my own wording (asusming you'll correct English if
needed):

Default: ou=Group
_Description: Prefix for groups on the LDAP server:
 Please enter the prefix under which the groups information is
 stored.
 .
 Do not include the DN prefix in this setting. It will be added
 automatically in the generated configuration file.



>  Template: lwat/minPwNumber
>  Type: string
>  Default: 1
> -_Description: Minimum number of digits (0-9) in passwords:
> +_Description: Minimum number of digits (characters 0-9) in passwords:
> + The passwords chosen by by users will be checked to ensure that they have a
> + minimum number of digits in them. Digits are defined to be the characters
> + 0-9. Enter 0 to disable this check.


I'm fine with that wording. I would separate the "Enter 0 to
disable..." part in one paragraph as that would make translation
easier (translate it once instead of 3 times) but that's all.

However, we should confirm with maintainers that the above is true..:)


Attachment: signature.asc
Description: Digital signature


Reply to: