Re: [RFR] templates://shorewall-common/{shorewall-common.templates}
Christian Perrier wrote:
> Your review should be sent as an answer to this mail.
> Template: shorewall-common/dont_restart
[...]
> + Shorewall will not be restarted automatically after being upgraded.
> + This will prevent network outages due to changes in configuration files.
Clearer as:
Shorewall will not be restarted automatically after being upgraded,
to prevent changes in configuration files causing network outages.
> Template: shorewall-common/major_release
[...]
> + Shorewall is being upgraded to major version that introduces some
> + changes in the configuration files.
> + .
> + These files should be checked carefully before restarting the
> + firewall, to avoid failures and network outages. Please read the
> + /usr/share/doc/shorewall/releasenotes.txt.gz file for more
> + information.
Chopping and changing:
This release of Shorewall introduces some changes in the configuration
files - see /usr/share/doc/shorewall-common/releasenotes.txt.gz.
.
To avoid the risk of failures and network outages these files should be
checked carefully before the firewall is restarted.
Note the corrected packagename directory; and shouldn't that
releasenotes file be (symlinked as) NEWS.Debian.gz?
Then in the control file:
> + Shorewall allows describing firewall/gateway requirements
> using entries in a set of configuration files. It reads those
I'd prefer:
Shorewall allows firewall/gateway requirements to be described
using entries in a set of configuration files. It reads those
Oh, and one I spotted at the last moment:
> This package contains files needed by both the perl-based and
> shell-based compilers.
s/perl/Perl/
And is it netfilter or Netfilter? netfilter.org says the former.
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
--- ../shorewall-common.old/debian/shorewall-common.templates 2007-11-25 13:35:23.000000000 +0000
+++ debian/shorewall-common.templates 2007-12-05 19:08:30.000000000 +0000
@@ -1,21 +1,19 @@
Template: shorewall-common/dont_restart
Type: note
-_Description: Shorewall won't be restarted automatically
- This will prevent network blackout due to changes in configuration files.
+_Description: No automatic restart for Shorewall
+ Shorewall will not be restarted automatically after being upgraded,
+ to prevent changes in configuration files causing network outages.
.
- Check your configuration and then restart Shorewall issuing:
- .
- invoke-rc.d shorewall restart
- .
- or
- .
- /etc/init.d/shorewall restart
+ You should check Shorewall's configuration files and restart it with
+ 'invoke-rc.d shorewall restart'.
Template: shorewall-common/major_release
Type: boolean
-_Description: Do you want to restart Shorewall right now?
- This is a major release of Shorewall that introduces some changes in the
- configuration files. You have to check carefully your configuration before
- restarting your firewall to avoid failures and network blackout. The changes
- are listed in /usr/share/doc/shorewall/releasenotes.txt.gz.
-
+_Description: Restart Shorewall?
+ This release of Shorewall introduces some changes in the configuration
+ files - see /usr/share/doc/shorewall-common/releasenotes.txt.gz.
+ .
+ To avoid the risk of failures and network outages these files should be
+ checked carefully before the firewall is restarted.
+ .
+ Please choose whether you want to restart Shorewall immediately.
--- ../shorewall-common.old/debian/control 2007-11-25 13:35:23.000000000 +0000
+++ debian/control 2007-12-05 19:21:37.000000000 +0000
@@ -14,22 +14,22 @@
Suggests: shorewall-doc, linux-image, make
Conflicts: ipmasq, knetfilter, firewall-easy, filtergen, uif, webmin-firewall, ipmenu, gnome-lokkit, guarddog, guidedog, ferm
Replaces: shorewall
-Description: Shoreline Firewall, netfilter configurator (common files)
- Shorewall allows you to describe your firewall/gateway requirements
+Description: Shoreline Firewall, netfilter configurator - common files
+ Shorewall allows firewall/gateway requirements to be described
using entries in a set of configuration files. It reads those
configuration files and, with the help of the iptables utility,
- configures Netfilter to match your requirements.
+ configures netfilter to match these requirements.
.
Shorewall supports a wide range of router/firewall/gateway applications,
traffic shaping and almost every type of VPN.
.
- This package contains files needed by both the perl-based and
+ This package contains files needed by both the Perl-based and
shell-based compilers.
Package: shorewall
Architecture: all
Depends: shorewall-shell
-Description: Shoreline Firewall (transitional package)
- This package is simply to facilitate the transition to shorewall-shell.
- You may remove it at your convenience.
+Description: Shoreline Firewall, netfilter configurator - transitional package
+ This package is a transition package to shorewall-shell. It can be safely
+ removed.
Template: shorewall-common/dont_restart
Type: note
_Description: No automatic restart for Shorewall
Shorewall will not be restarted automatically after being upgraded,
to prevent changes in configuration files causing network outages.
.
You should check Shorewall's configuration files and restart it with
'invoke-rc.d shorewall restart'.
Template: shorewall-common/major_release
Type: boolean
_Description: Restart Shorewall?
This release of Shorewall introduces some changes in the configuration
files - see /usr/share/doc/shorewall-common/releasenotes.txt.gz.
.
To avoid the risk of failures and network outages these files should be
checked carefully before the firewall is restarted.
.
Please choose whether you want to restart Shorewall immediately.
Source: shorewall-common
Section: net
Priority: optional
Maintainer: Roberto C. Sanchez <roberto@connexer.com>
Homepage: http://www.shorewall.net
Build-Depends: debhelper (>> 5), dpatch, po-debconf
Standards-Version: 3.7.2
Vcs-Browser: http://shorewall.svn.sourceforge.net/viewvc/shorewall/
Vcs-Svn: https://shorewall.svn.sourceforge.net/svnroot/shorewall/
Package: shorewall-common
Architecture: all
Depends: iptables (>= 1.2.7a), iproute, debconf | debconf-2.0
Suggests: shorewall-doc, linux-image, make
Conflicts: ipmasq, knetfilter, firewall-easy, filtergen, uif, webmin-firewall, ipmenu, gnome-lokkit, guarddog, guidedog, ferm
Replaces: shorewall
Description: Shoreline Firewall, netfilter configurator - common files
Shorewall allows firewall/gateway requirements to be described
using entries in a set of configuration files. It reads those
configuration files and, with the help of the iptables utility,
configures netfilter to match these requirements.
.
Shorewall supports a wide range of router/firewall/gateway applications,
traffic shaping and almost every type of VPN.
.
This package contains files needed by both the Perl-based and
shell-based compilers.
Package: shorewall
Architecture: all
Depends: shorewall-shell
Description: Shoreline Firewall, netfilter configurator - transitional package
This package is a transition package to shorewall-shell. It can be safely
removed.
Reply to: