Re: [RFR] templates://postgresql-common/{postgresql-common.templates}
Christian Perrier wrote:
> Your review should be sent as an answer to this mail.
>
> Rationale:
> .
> - The old server and client packages are not supported any more. After
> - having upgraded the existing clusters, you should remove the
> - postgresql-${old} and postgresql-client-${old} packages.
> + The old server and client packages are not supported anymore. After
> + upgrading the existing clusters, the
> + postgresql-${old} and postgresql-client-${old} packages should be removed.
>
> "any more" or "anymore". Native speakers, could you please confirm
> that my change is correct?
It's a dialect thing (http://m-w.com/cgi-bin/dictionary?va=anymore);
in contexts like this, "any more" is normal in en_GB, "anymore" in
(most kinds of) en_US.
> Ditto for the tense change. "having upgraded" is what I would say in
> first stance....and I'm often wrong on English tenses just like many
> French people.
After upgrading is good as regards "tenses", but I still wouldn't
write it like this myself (because the packages are the subject, and
they aren't what's upgrading the clusters). I'd say:
After the existing clusters are upgraded, the postgresql-${old}
and postgresql-client-${old} packages should be removed.
[...]
> -Description: manager for PostgreSQL database clusters
> - postgresql-common provides a structure under which multiple versions of
> +Description: PostgreSQL database clusters manager
> + The postgresql-common package provides a structure under which multiple versions of
> PostgreSQL may be installed and/or multiple clusters maintained at one
> time.
>
> Revert the words in the short description
(You mean invert.) I'd make that a "PostgreSQL database cluster
manager" or perhaps even a "PostgreSQL database-cluster manager".
The relative-clause-with-parallel-passive-constructions thing going
on here is a bit much:
a structure under which
multiple versionsofPostgreSQL may be installed
and/or
multiple clusters [may be] maintained
at one time
It's technically grammatical with "may be" elided, but I'd keep it.
[...]
> - If you have openssl installed, this package will automatically create a (self
> - signed) SSL certificate so that SSL works out of the box.
> + If OpenSSL is installed, this package will automatically create a (self-signed) SSL certificate so that SSL connections are supported.
Drop one of the mentions of SSL (and reformat):
If OpenSSL is installed, this package will automatically create a
(self-signed) certificate so that SSL connections are supported.
Other tweaks:
> [...] Some of the features are:
> ACID transactions, foreign keys, views, sequences, subqueries,
> triggers, user-defined types and functions, outer joins, multiversion
> concurrency control.
I'd make that:
Its features include ACID transactions, foreign keys, views,
sequences, subqueries, triggers, outer joins, multiversion
concurrency control, and user-defined types and functions.
--
JBR
Ankh kak! (Ancient Egyptian blessing)
--- ../postgresql-common.old/debian/postgresql-common.templates 2007-05-20 14:20:00.000000000 +0100
+++ debian/postgresql-common.templates 2007-09-29 12:37:43.000000000 +0100
@@ -1,9 +1,9 @@
Template: postgresql-common/obsolete-major
-Type: note
+Type: error
_Description: Obsolete major version ${old}
- The PostgreSQL version ${old} is obsolete, but you still have the server
- and/or client package installed. Please install the latest packages
- (postgresql-${latest} and postgresql-client-${latest}) and upgrade your
+ The PostgreSQL version ${old} is obsolete, but the server
+ or client packages are still installed. Please install the latest packages
+ (postgresql-${latest} and postgresql-client-${latest}) and upgrade the
existing ${oldversion} clusters with pg_upgradecluster (see manpage).
.
Please be aware that the installation of postgresql-${latest} will
@@ -12,6 +12,6 @@
cluster (pg_dropcluster --stop ${latest} main, see manpage for
details).
.
- The old server and client packages are not supported any more. After
- having upgraded the existing clusters, you should remove the
- postgresql-${old} and postgresql-client-${old} packages.
+ The old server and client packages are not supported anymore. After
+ the existing clusters are upgraded, the
+ postgresql-${old} and postgresql-client-${old} packages should be removed.
--- ../postgresql-common.old/debian/control 2007-08-04 10:30:42.000000000 +0100
+++ debian/control 2007-09-29 12:40:56.000000000 +0100
@@ -11,20 +11,20 @@
Conflicts: postgresql (<< 7.5), postgresql-client (<< 7.5), postgresql-7.4 (<< 1:7.4.8-10), postgresql-8.0 (<< 8.0.3-7)
Replaces: postgresql (<< 7.5), postgresql-client (<< 7.5)
Depends: postgresql-client-common (>= ${source:Version}), procps, adduser, debconf (>= 0.5.00) | debconf-2.0, lsb-base (>= 3.0-3), ssl-cert (>= 1.0.11)
-Description: manager for PostgreSQL database clusters
- postgresql-common provides a structure under which multiple versions of
- PostgreSQL may be installed and/or multiple clusters maintained at one
+Description: PostgreSQL database cluster manager
+ The postgresql-common package provides a structure under which multiple versions of
+ PostgreSQL may be installed and/or multiple clusters may be maintained at one
time.
.
- If you have openssl installed, this package will automatically create a (self
- signed) SSL certificate so that SSL works out of the box.
+ If OpenSSL is installed, this package will automatically create a
+ (self-signed) certificate so that SSL connections are supported.
.
PostgreSQL is a fully featured object-relational database management
- system. It supports a large part of the SQL standard and is designed
- to be extensible by users in many aspects. Some of the features are:
- ACID transactions, foreign keys, views, sequences, subqueries,
- triggers, user-defined types and functions, outer joins, multiversion
- concurrency control. Graphical user interfaces and bindings for many
+ system. It supports a large part of the SQL standard and is designed
+ to be extensible by users in many aspects. Its features include ACID
+ transactions, foreign keys, views, sequences, subqueries, triggers,
+ outer joins, multiversion concurrency control, and user-defined types
+ and functions. Graphical user interfaces and bindings for many
programming languages are available as well.
Package: postgresql-client-common
@@ -33,7 +33,7 @@
Replaces: postgresql (<< 7.5), postgresql-client (<< 7.5), postgresql-common (<< 45)
Depends: debconf (>= 0.5.00) | debconf-2.0
Description: manager for multiple PostgreSQL client versions
- postgresql-client-common provides a structure under which multiple
+ The postgresql-client-common package provides a structure under which multiple
versions of PostgreSQL client programs may be installed at the same
time. It provides a wrapper which selects the right version for the
particular cluster you want to access (with a command line option, an
@@ -41,10 +41,9 @@
~/.postgresqlrc).
.
PostgreSQL is a fully featured object-relational database management
- system. It supports a large part of the SQL standard and is designed
- to be extensible by users in many aspects. Some of the features are:
- ACID transactions, foreign keys, views, sequences, subqueries,
- triggers, user-defined types and functions, outer joins, multiversion
- concurrency control. Graphical user interfaces and bindings for many
+ system. It supports a large part of the SQL standard and is designed
+ to be extensible by users in many aspects. Its features include ACID
+ transactions, foreign keys, views, sequences, subqueries, triggers,
+ outer joins, multiversion concurrency control, and user-defined types
+ and functions. Graphical user interfaces and bindings for many
programming languages are available as well.
-
--- ../postgresql-common.old/debian/postgresql-common.templates 2007-05-20 14:20:00.000000000 +0100
+++ debian/postgresql-common.templates 2007-09-29 12:43:00.000000000 +0100
@@ -1,9 +1,9 @@
Template: postgresql-common/obsolete-major
-Type: note
+Type: error
_Description: Obsolete major version ${old}
- The PostgreSQL version ${old} is obsolete, but you still have the server
- and/or client package installed. Please install the latest packages
- (postgresql-${latest} and postgresql-client-${latest}) and upgrade your
+ The PostgreSQL version ${old} is obsolete, but the server
+ or client packages are still installed. Please install the latest packages
+ (postgresql-${latest} and postgresql-client-${latest}) and upgrade the
existing ${oldversion} clusters with pg_upgradecluster (see manpage).
.
Please be aware that the installation of postgresql-${latest} will
@@ -12,6 +12,6 @@
cluster (pg_dropcluster --stop ${latest} main, see manpage for
details).
.
- The old server and client packages are not supported any more. After
- having upgraded the existing clusters, you should remove the
- postgresql-${old} and postgresql-client-${old} packages.
+ The old server and client packages are not supported anymore. After
+ the existing clusters are upgraded, the postgresql-${old} and
+ postgresql-client-${old} packages should be removed.
--- ../postgresql-common.old/debian/control 2007-08-04 10:30:42.000000000 +0100
+++ debian/control 2007-09-29 12:40:56.000000000 +0100
@@ -11,20 +11,20 @@
Conflicts: postgresql (<< 7.5), postgresql-client (<< 7.5), postgresql-7.4 (<< 1:7.4.8-10), postgresql-8.0 (<< 8.0.3-7)
Replaces: postgresql (<< 7.5), postgresql-client (<< 7.5)
Depends: postgresql-client-common (>= ${source:Version}), procps, adduser, debconf (>= 0.5.00) | debconf-2.0, lsb-base (>= 3.0-3), ssl-cert (>= 1.0.11)
-Description: manager for PostgreSQL database clusters
- postgresql-common provides a structure under which multiple versions of
- PostgreSQL may be installed and/or multiple clusters maintained at one
+Description: PostgreSQL database cluster manager
+ The postgresql-common package provides a structure under which multiple versions of
+ PostgreSQL may be installed and/or multiple clusters may be maintained at one
time.
.
- If you have openssl installed, this package will automatically create a (self
- signed) SSL certificate so that SSL works out of the box.
+ If OpenSSL is installed, this package will automatically create a
+ (self-signed) certificate so that SSL connections are supported.
.
PostgreSQL is a fully featured object-relational database management
- system. It supports a large part of the SQL standard and is designed
- to be extensible by users in many aspects. Some of the features are:
- ACID transactions, foreign keys, views, sequences, subqueries,
- triggers, user-defined types and functions, outer joins, multiversion
- concurrency control. Graphical user interfaces and bindings for many
+ system. It supports a large part of the SQL standard and is designed
+ to be extensible by users in many aspects. Its features include ACID
+ transactions, foreign keys, views, sequences, subqueries, triggers,
+ outer joins, multiversion concurrency control, and user-defined types
+ and functions. Graphical user interfaces and bindings for many
programming languages are available as well.
Package: postgresql-client-common
@@ -33,7 +33,7 @@
Replaces: postgresql (<< 7.5), postgresql-client (<< 7.5), postgresql-common (<< 45)
Depends: debconf (>= 0.5.00) | debconf-2.0
Description: manager for multiple PostgreSQL client versions
- postgresql-client-common provides a structure under which multiple
+ The postgresql-client-common package provides a structure under which multiple
versions of PostgreSQL client programs may be installed at the same
time. It provides a wrapper which selects the right version for the
particular cluster you want to access (with a command line option, an
@@ -41,10 +41,9 @@
~/.postgresqlrc).
.
PostgreSQL is a fully featured object-relational database management
- system. It supports a large part of the SQL standard and is designed
- to be extensible by users in many aspects. Some of the features are:
- ACID transactions, foreign keys, views, sequences, subqueries,
- triggers, user-defined types and functions, outer joins, multiversion
- concurrency control. Graphical user interfaces and bindings for many
+ system. It supports a large part of the SQL standard and is designed
+ to be extensible by users in many aspects. Its features include ACID
+ transactions, foreign keys, views, sequences, subqueries, triggers,
+ outer joins, multiversion concurrency control, and user-defined types
+ and functions. Graphical user interfaces and bindings for many
programming languages are available as well.
-
Template: postgresql-common/obsolete-major
Type: error
_Description: Obsolete major version ${old}
The PostgreSQL version ${old} is obsolete, but the server
or client packages are still installed. Please install the latest packages
(postgresql-${latest} and postgresql-client-${latest}) and upgrade the
existing ${oldversion} clusters with pg_upgradecluster (see manpage).
.
Please be aware that the installation of postgresql-${latest} will
automatically create a default cluster ${latest}/main. If you want to upgrade
the ${old}/main cluster, you need to remove the already existing ${latest}
cluster (pg_dropcluster --stop ${latest} main, see manpage for
details).
.
The old server and client packages are not supported anymore. After
the existing clusters are upgraded, the postgresql-${old} and
postgresql-client-${old} packages should be removed.
Source: postgresql-common
Section: misc
Priority: optional
Maintainer: Martin Pitt <mpitt@debian.org>
Uploaders: Oliver Elphick <Oliver.Elphick@lfix.co.uk>
Standards-Version: 3.7.2
Build-Depends: cdbs, debhelper (>= 4.1.29)
Package: postgresql-common
Architecture: all
Conflicts: postgresql (<< 7.5), postgresql-client (<< 7.5), postgresql-7.4 (<< 1:7.4.8-10), postgresql-8.0 (<< 8.0.3-7)
Replaces: postgresql (<< 7.5), postgresql-client (<< 7.5)
Depends: postgresql-client-common (>= ${source:Version}), procps, adduser, debconf (>= 0.5.00) | debconf-2.0, lsb-base (>= 3.0-3), ssl-cert (>= 1.0.11)
Description: PostgreSQL database cluster manager
The postgresql-common package provides a structure under which multiple versions of
PostgreSQL may be installed and/or multiple clusters may be maintained at one
time.
.
If OpenSSL is installed, this package will automatically create a
(self-signed) certificate so that SSL connections are supported.
.
PostgreSQL is a fully featured object-relational database management
system. It supports a large part of the SQL standard and is designed
to be extensible by users in many aspects. Its features include ACID
transactions, foreign keys, views, sequences, subqueries, triggers,
outer joins, multiversion concurrency control, and user-defined types
and functions. Graphical user interfaces and bindings for many
programming languages are available as well.
Package: postgresql-client-common
Architecture: all
Conflicts: postgresql (<< 7.5), postgresql-client (<< 7.5), postgresql-common (<< 45)
Replaces: postgresql (<< 7.5), postgresql-client (<< 7.5), postgresql-common (<< 45)
Depends: debconf (>= 0.5.00) | debconf-2.0
Description: manager for multiple PostgreSQL client versions
The postgresql-client-common package provides a structure under which multiple
versions of PostgreSQL client programs may be installed at the same
time. It provides a wrapper which selects the right version for the
particular cluster you want to access (with a command line option, an
environment variable, /etc/postgresql-commmon/user_clusters, or
~/.postgresqlrc).
.
PostgreSQL is a fully featured object-relational database management
system. It supports a large part of the SQL standard and is designed
to be extensible by users in many aspects. Its features include ACID
transactions, foreign keys, views, sequences, subqueries, triggers,
outer joins, multiversion concurrency control, and user-defined types
and functions. Graphical user interfaces and bindings for many
programming languages are available as well.
Reply to: