[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR2] templates://ocsinventory-agent/ocsinventory-agent.templates



Quoting James Westby (jw+debian@jameswestby.net):
> Please review the changed templates and control file of the
> ocsinventory-agent package.
> 
> I have incorporated the comments from the initial RFR, except for
> Christian's suggestion to change the values used in the first template.
> I was unsure of whether to do this, as it requires changes to the
> package. Pierre, could you comment on whether you would be happy to make
> the required changes?

The changes are minimal:

      db_get ocsinventory-agent/method || true
      if [ "$RET" = http ]; then
        db_get ocsinventory-agent/server || true
	SERVER="$RET"
      fi

Becomes:

      db_get ocsinventory-agent/method || true
      if [ "$RET" = "http" ]; then
        db_set ocsinventory-agent/method "HTTP" || true
      fi
      if [ "$RET" = "HTTP" ]; then
        db_get ocsinventory-agent/server || true
	SERVER="$RET"
      fi

That should even handle the transition..:)..The "local" value doesn't
seem to be tested...

But, of course, these changes require Pierre to agree with them.


Attachment: signature.asc
Description: Digital signature


Reply to: