[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://havp/{havp.templates.master}



Christian Perrier wrote:
> Please find, for review, the debconf templates of havp.

The bulleted list in havp's long description is redundant after the
text paragraph; the description is better without it.  Shortened
version and patch to the original attached; detailed moaning about
individual bulletpoints below. 

>   - HTTP antivirus proxy

(You've corrected the inconsistent capitalisation.)

>   - Scans complete incoming traffic
>   - Nonblocking downloads 
>   - Smooth scanning of dynamic and password protected traffic 

This is a repetition of the text, but in less fluent English
("complete traffic" doesn't quite work); and what does "dynamic
traffic" mean, anyway?  Does "smooth" just mean "rapid"?

>   - Can used with squid or other proxy

"Can be used".  havp already Suggests: squid and mentions it in the
text, then goes on to say:

>   - Parent proxy support
>   - Transparent proxy support

That is, havp functions transparently as either a standalone or as a
parent-proxy, just as the text already explained.

>   - Logfile
>   - Process change to defined user and group
>   - Daemon

Either merge this information into the text ("runs as user havp,
with logfile") or just let readers take it for granted that it's a
well-behaved proxy-daemon.

>   - Use Clamav (GPL antivirus)

"Uses".  Redundant when havp's dependency trail leads to clamav's
own package description (via "Recommends: clamav-freshclam", which
seems a bit weak).

>   - Operating System: Linux 

"Architecture: any" makes this redundant (or maybe false, if that
kfreebsd version works).

>   - Written in C++

Might be merged into the text, but anybody interested can search for
the "implemented-in::c++" debtag.

>   - Released under GPL

Thanks.
-- 
JBR
Ankh kak! (Ancient Egyptian blessing)
--- control.orig	2007-04-09 14:06:49.000000000 +0100
+++ control.jbr	2007-04-09 14:07:07.000000000 +0100
@@ -16,18 +16,3 @@
  main aims are continuous, non-blocking downloads and smooth scanning of
  dynamic and password protected HTTP traffic. Havp antivirus proxy has a
  parent and transparent proxy mode. It can be used with squid or standalone.
- .
-  - HTTP Antivirus proxy
-  - Scans complete incoming traffic
-  - Nonblocking downloads 
-  - Smooth scanning of dynamic and password protected traffic 
-  - Can used with squid or other proxy
-  - Parent proxy support
-  - Transparent proxy support
-  - Logfile
-  - Process change to defined user and group
-  - Daemon
-  - Use Clamav (GPL antivirus)
-  - Operating System: Linux 
-  - Written in C++
-  - Released under GPL
Source: havp
Section: net
Priority: optional
Maintainer: Rene Mayrhofer <rene.mayrhofer@gibraltar.at>
Build-Depends: debhelper (>= 4.0.0), autotools-dev, libssl-dev, libclamav-dev, dpatch, docbook-to-man, po-debconf
Standards-Version: 3.7.2.1

Package: havp
Architecture: any
Pre-Depends: debconf | debconf-2.0
Depends: ${shlibs:Depends}, ${misc:Depends}, adduser
Recommends: clamav-freshclam
Suggests: squid
Description: HTTP Anti Virus Proxy
 HAVP (HTTP Antivirus Proxy) is a proxy with a ClamAV anti-virus scanner. The
 main aims are continuous, non-blocking downloads and smooth scanning of
 dynamic and password protected HTTP traffic. Havp antivirus proxy has a
 parent and transparent proxy mode. It can be used with squid or standalone.

Reply to: