[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://openssl/{libssl0.9.8.templates}



(please look at my review comments at the end of this mail)

Please find, for review, the debconf templates and the debian/control
file of openssl.

This review will last from Thursday, March 29, 2007 to Sunday, April 08, 2007.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

The part to review in debian/control are the package description(s).

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Note to openssl maintainer(s): this review is CC'ed to you so that
you can comment on the proposed changes before we propose the rewrite
in a bug report. Please note that these changes will be reviewed and
are therefore *not* the final version.

Please take care to send any comment to debian-l10n-english.

Review comments:
----------------

debian/control:
 - German-style capitalisation removed in some places
 - Bulleted list made with dashes. We should determine a policy here

templates:
 - attempt to make them shorter
 - remove the use of 1st person
 - turn the short description into a prompt. Remove interrogative form

-- 


Template: libssl0.9.8/restart-services
Type: string
_Description: Services to restart to make them use the new libraries:
 This release of OpenSSL fixes some security issues. Services may not
 use these fixes until they are restarted. Please note that restarting
 the SSH server (sshd) should not affect any existing connections.
 .
 Please check the list of detected services that need to be restarted. Please
 correct this list, if needed. The services are named from the
 name of their initialisation script in /etc/init.d and must be separated by
 spaces. No services will be restarted if the list is empty.
 .
 Any service that later fails unexpectedly after this upgrade should
 be restarted. It is recommended to reboot this host to avoid any
 SSL-related trouble.
--- ../openssl.old/debian/libssl0.9.8.templates	2007-03-29 06:11:35.006946730 +0200
+++ debian/libssl0.9.8.templates	2007-03-29 18:52:31.440400500 +0200
@@ -1,15 +1,15 @@
 Template: libssl0.9.8/restart-services
 Type: string
-_Description: Which services should be restarted to make them use the new libraries?
- Security holes were fixed with this release. Services may not use these
- fixes until they are restarted. Note: restarting sshd should not affect any
- existing connections.
+_Description: Services to restart to make them use the new libraries:
+ This release of OpenSSL fixes some security issues. Services may not
+ use these fixes until they are restarted. Please note that restarting
+ the SSH server (sshd) should not affect any existing connections.
  .
- Following is a list of detected services that need to be restarted. Please
- correct the list, if you think it is incorrect. The services names must be
- identical to the script names in /etc/init.d and must be separated by
- spaces. If you clear the list, no services will be restarted.
+ Please check the list of detected services that need to be restarted. Please
+ correct this list, if needed. The services are named from the
+ name of their initialisation script in /etc/init.d and must be separated by
+ spaces. No services will be restarted if the list is empty.
  .
- If other services begin to fail mysteriously after this upgrade, it may be
- necessary to restart them too.  We strongly recommend you to reboot your
- machine to avoid the SSL related trouble.
+ Any service that later fails unexpectedly after this upgrade should
+ be restarted. It is recommended to reboot this host to avoid any
+ SSL-related trouble.
Source: openssl
Build-Depends: debhelper (>= 5.0.22), binutils (>= 2.14.90.0.7), zlib1g-dev, m4, bc
Section: utils
Priority: optional
Maintainer: Debian OpenSSL Team <pkg-openssl-devel@lists.alioth.debian.org>
Uploaders: Christoph Martin <christoph.martin@uni-mainz.de>, Kurt Roeckx <kurt@roeckx.be>
Standards-Version: 3.7.0

Package: openssl
Priority: optional
Architecture: any
Depends: ${shlibs:Depends}, ${perl:Depends}, libssl0.9.8 (>= 0.9.8e-1)
Conflicts: ssleay (<< 0.9.2b)
Suggests: ca-certificates
Description: Secure Socket Layer (SSL) binary and related cryptographic tools
 This package contains the openssl binary and related tools.
 .
 It is part of the OpenSSL implementation of SSL.
 .
 You need it to perform certain cryptographic actions like:
  -  Creation of RSA, DH and DSA key parameters;
  -  Creation of X.509 certificates, CSRs and CRLs;
  -  Calculation of message digests;
  -  Encryption and decryption with ciphers;
  -  SSL/TLS client and server tests;
  -  Handling of S/MIME signed or encrypted mail.

Package: libssl0.9.8
Section: libs
Priority: important
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}
Conflicts: ssleay (<< 0.9.2b), libssl, openssl (<< 0.9.6-2), libssl096-dev (<< 0.9.6-2)
Description: SSL shared libraries
 libssl and libcrypto shared libraries needed by programs like
 apache-ssl, telnet-ssl and openssh.
 .
 It is part of the OpenSSL implementation of SSL.

Package: libcrypto0.9.8-udeb
XC-Package-Type: udeb
Section: debian-installer
Priority: optional
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}
Provides: libssl0.9.8
Description: crypto shared library - udeb
 libcrypto shared library.
 .
 Do not install it on a normal system.

Package: libssl-dev
Section: libdevel
Priority: optional
Architecture: any
Depends: libssl0.9.8 (= ${Source-Version}), zlib1g-dev
Conflicts: ssleay (<< 0.9.2b), libssl08-dev, libssl09-dev, libssl095a-dev, libssl096-dev
Description: SSL development libraries, header files and documentation
 libssl and libcrypt development libraries, header files and manpages.
 .
 It is part of the OpenSSL implementation of SSL.

Package: libssl0.9.8-dbg
Section: libdevel
Priority: extra
Architecture: any
Depends: libssl0.9.8 (= ${Source-Version})
Description: Symbol tables for libssl and libcrypt
 This package is part of the OpenSSL implementation of SSL.

Attachment: signature.asc
Description: Digital signature


Reply to: