Re: [RFR] templates://mediawiki1.7/{templates}
On Tue, Mar 27, 2007 at 07:53:03AM +0200, Christian Perrier wrote:
> Please find, for review, the debconf templates and the debian/control
> file of mediawiki1.7.
>
> This review will last from Tuesday, March 27, 2007 to Friday, April 06, 2007.
>
> Please send reviews as unified diffs (diff -u) against the original
> files. Comments about your proposed changes will be appreciated.
Here are my changes. Note that I disagreed with your patch slightly
Christian.
--- mediawiki.templates.orig 2007-03-27 23:26:06.000000000 +1000
+++ mediawiki.templates 2007-03-27 23:29:04.000000000 +1000
@@ -3,30 +3,30 @@
Choices: apache, apache-ssl, apache2, cherokee
Default: apache2
_Description: Web server(s) to configure automatically:
- Please choose the web server(s) that should be configured
+ Please select the web server(s) that should be configured
automatically for MediaWiki.
Template: mediawiki/upgrade-1d5
Type: boolean
Default: true
_Description: Perform automatic upgrade from MediaWiki 1.5?
- MediaWiki will be upgraded from the 1.5 version.
+ MediaWiki is being upgraded from version 1.5.
.
The new package version uses /var/lib/mediawiki1.7 for the wiki
- database location. The old database files need to be moved before
+ database. The old database files need to be moved before
performing the upgrade.
.
- This operation can be done automatically: the database wille be
+ This operation can be done automatically: the database will be
backed up, upgraded, and a new configuration file will be prepared
- for the new wiki. This script can be launched now. Alternatively, you
- can use it later by launching, as root,
+ for the new version. The operation can be performed now. Alternatively,
+ you can perform it later by launching, as root,
/usr/share/mediawiki1.7/debian-scripts/upgrade-mediawiki1.5.
Template: mediawiki/upgrade-1d5-adminuser
Type: string
Default: root
_Description: Database user for MediaWiki 1.7:
- Please provide a MySQL account that has administrative access to the old
+ Please provide a MySQL account that has administrative access to the
MediaWiki 1.5 database.
.
When in doubt, the MySQL root account can be used.
@@ -44,7 +44,7 @@
Template: mediawiki/configuration-fixed
Type: note
_Description: Configuration files fixed
- A previous bug in the package enforced configuration files to be
+ A previous bug in the mediawiki package forced configuration files to be
stored in /var/lib/mediawiki1.7.
.
These files have been moved back to /etc/mediawiki1.7 and a backup
The description looks quite good, only one comment below.
> Source: mediawiki1.7
> Section: web
> Priority: optional
> Maintainer: Mediawiki Maintenance Team <pkg-mediawiki-devel@lists.alioth.debian.org>
> Uploaders: Marc Dequènes (Duck) <Duck@DuckCorp.org>, Romain Beauxis <toots@rastageeks.org>, Arnaud Cornet <arnaud.cornet@gmail.com>
> Build-Depends: debhelper (>= 4.2.0), quilt, patchutils (>= 0.2.25), cdbs (>= 0.4.27-1), ocaml-nox | ocaml, xsltproc, docbook-xml, docbook-xsl, po-debconf
> Standards-Version: 3.7.2
>
> Package: mediawiki1.7
> Architecture: all
> Pre-depends: debconf (>= 0.2.26) | debconf-2.0
> Depends: apache2 | httpd, php5, php5-mysql, php5-cli, debconf (>= 0.2.26) | debconf-2.0, mime-support
> Recommends: mysql-server
> Suggests: php5-gd | imagemagick, mediawiki1.7-math, memcached, clamav
> Description: website engine for collaborative work
> MediaWiki is a particular wiki engine (a program to easily
> create a website which can be edited in a collaborative
> maner). It is designed to handle heavy websites containing
> library-like documents : users can upload images/sounds,
> multilingual support, TOC autogen, ISBN links, ...
> Moreover, it keeps track of changes, so you can view diffs,
> revert, and receive notifies. This system has many other
> features and can easily be extended.
> .
> MediaWiki is the underlying wiki engine used by the famous
> WikiPedia site (http://www.wikipedia.org/).
s/Pedia/pedia/
> .
> Homepage: http://www.mediawiki.org/
>
> Package: mediawiki1.7-math
> Architecture: any
> Depends: ${interpreter:Depends}, mediawiki1.7, tetex-bin | texlive-latex-base, gs-gpl | gs-esp, imagemagick
> Replaces: mediawiki-math, mediawiki1.5-math
> Recommends: latex-cjk-all, tetex-extra
> Description: math rendering plugin for MediaWiki
> MediaWiki is a particular wiki engine (a program to easily
> create a website which can be edited in a collaborative
> maner). It is designed to handle heavy websites containing
> library-like documents : users can upload images/sounds,
> multilingual support, TOC autogen, ISBN links, ...
> Moreover, it keeps track of changes, so you can view diffs,
> revert, and receive notifies. This system has many other
> features and can easily be extended.
> .
> MediaWiki is the underlying wiki engine used by the famous
> WikiPedia site (http://www.wikipedia.org/).
> .
> This package contains the math rendering plugin.
> .
> Homepage: http://www.mediawiki.org/
>
Hamish
--
Hamish Moffatt VK3SB <hamish@debian.org> <hamish@cloud.net.au>
Reply to: