Re: cloop and kernel 5.0.1

[Klaus Knopper <debian-knoppix@knopper.net>]

Hello Massimo,

I anticipated the block layer changing in Kernel 5.x, seems I need to
rewrite the request queue logic in cloop. I'll have a look on it when
upgrading the kernel next time.

Regards
-Klaus

On 10.03.19, Max wrote:
> Hello Klaus,
> 
> Something has changed on the latest kernel and cloop doesn't compile:
> 
> 
> /usr/src/cloop-4/cloop.c: In function ‘cloop_do_request’:
> /usr/src/cloop-4/cloop.c:487:15: error: implicit declaration of function
> ‘blk_fetch_request’; did you mean ‘blk_get_request’?
> [-Werror=implicit-function-declaration]
>   while((req = blk_fetch_request(q)) != NULL)
>                ^~~~~~~~~~~~~~~~~
>                blk_get_request
> /usr/src/cloop-4/cloop.c:487:13: warning: assignment to ‘struct request *’
> from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
>   while((req = blk_fetch_request(q)) != NULL)
>              ^
> /usr/src/cloop-4/cloop.c: In function ‘cloop_alloc’:
> /usr/src/cloop-4/cloop.c:1154:19: error: implicit declaration of function
> ‘blk_init_queue’; did you mean ‘blk_put_queue’?
> [-Werror=implicit-function-declaration]
>   clo->clo_queue = blk_init_queue(cloop_do_request, &clo->queue_lock);
>                    ^~~~~~~~~~~~~~
>                    blk_put_queue
> /usr/src/cloop-4/cloop.c:1154:17: warning: assignment to ‘struct
> request_queue *’ from ‘int’ makes pointer from integer without a cast
> [-Wint-conversion]
>   clo->clo_queue = blk_init_queue(cloop_do_request, &clo->queue_lock);
> 
> Thank you 
> 
> 
> Massimo
> 
> 
> 
> 
> --
> Sent from: http://debian.2.n7.nabble.com/debian-knoppix-f2117189.html