Re: Cloop and kernel 3.9.0: more cloops please
While you are fixing cloop.c, I would like to request 32 cloops, please.
(I forgot who asked for this before, but it would really help me also.)
Please let us know when you have kernel 3.9 on the debsite.
Thanks!
Charles
On Tue, 7 May 2013 05:21:37 +0200
Klaus Knopper <debian-knoppix@knopper.net> wrote:
> Hello Max,
>
> On Mon, May 06, 2013 at 09:22:20AM -0700, Max wrote:
> >
> > We had almost two years without problems but now it seems that we have a
> > problem with kernel 3.9.0 and cloop:
> >
> > make[1]: Entering directory `/usr/src/linux-3.9'
> > CC [M] /usr/src/cloop-2.639/cloop.o
> > /usr/src/cloop-2.639/cloop.c: In function 'cloop_get_status':
> > /usr/src/cloop-2.639/cloop.c:746:2: warning: passing argument 1 of
> > 'vfs_getattr' from incompatible pointer type [enabled by default]
> > In file included from /usr/src/cloop-2.639/cloop.c:39:0:
> > include/linux/fs.h:2473:12: note: expected 'struct path *' but argument is
> > of type 'struct vfsmount *'
> > /usr/src/cloop-2.639/cloop.c:746:2: warning: passing argument 2 of
> > 'vfs_getattr' from incompatible pointer type [enabled by default]
> > In file included from /usr/src/cloop-2.639/cloop.c:39:0:
> > include/linux/fs.h:2473:12: note: expected 'struct kstat *' but argument
> > is of type 'struct dentry *'
> > /usr/src/cloop-2.639/cloop.c:746:2: error: too many arguments to function
> > 'vfs_getattr'
> > In file included from /usr/src/cloop-2.639/cloop.c:39:0:
> > include/linux/fs.h:2473:12: note: declared here
> > make[2]: *** [/usr/src/cloop-2.639/cloop.o] Error 1
> > make[1]: *** [_module_/usr/src/cloop-2.639] Error 2
> > make[1]: Leaving directory `/usr/src/linux-3.9'
> > make: *** [cloop.ko] Error
>
> The Kernel 3.9 API change in vfs_getattr seems to be an optimization,
> using just a pointer to the path structure instead of both a pointer to
> vfsmount and dentry. See here:
> https://github.com/ryao/spl/commit/4880d883d4d0bd86f227c1ce422502691bc8790f
>
> Please try the attached patch, it fixes the changed syntax. I didn't
> rebuild the full kernel yet, though.
>
> Regards
> -Klaus
Reply to: