[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1118465: Regression: linux-image-5.10.0-36-arm64 fails to bring up LAN7800 USB NIC: "NO-CARRIER" and "state DOWN"



Hi Ben,

In case Axel can confirm, there is a "off-by-one" in one of the Fixes:

On Tue, Oct 21, 2025 at 10:27:37PM +0200, Ben Hutchings wrote:
> Control: tag -1 upstream patch moreinfo
> 
> Does this patch fix it?
> 
> Ben.
> 
> -- 
> Ben Hutchings
> Editing code like this is akin to sticking plasters on the bleeding
> stump of a severed limb. - me, 29 June 1999

> From 4f97e494a3e2500166be4e8b53b4c412d6a44a9f Mon Sep 17 00:00:00 2001
> From: Ben Hutchings <benh@debian.org>
> Date: Tue, 21 Oct 2025 22:18:49 +0200
> Subject: [PATCH] usbnet: Report link up even when the interface is not yet up
> 
> Even after commit 466d393700f9 ("net: usbnet: Fix the wrong
> netif_carrier_on() call"), usbnet isn't calling netif_carrier_on() in
> all the same cases it would before.  Specifically, if the link is
> reported up before EVENT_DEV_OPEN is set, netif_carrier_on() may no
> longer be called.
> 
> Fix this by checking for EVENT_LINK_CARRIER_ON first in
> __handle_link_change(), before EVENT_DEV_OPEN.
> 
> References: https://bugs.debian.org/1118465
> Reported-by: Axel Beckert <axel@ethz.ch>
> Fixes: 0d9cfc9b8cb1 ("net: usbnet: Avoid potential RCU stall on LINK_CHANGE event")
> Fixes: 466d393700f9 ("net: usbnet: Fix the wrong netif_carrier_on() call")

Should that be
Fixes: 8466d393700f ("net: usbnet: Fix the wrong netif_carrier_on() call")
?

Spotted it while checking to see ee which other stable series are affected.

Regards,
Salvatore


Reply to: