Bug#1114806: Bisect result

[Niklas Cathor <niklas.cathor@gmx.de>]

Hi Salvatore,

(resending previous message, because I forgot to CC the bug tracker)

On 9/13/25 8:47 PM, Salvatore Bonaccorso wrote:
> Hi Niklas,
>
> On Sat, Sep 13, 2025 at 08:23:01PM +0200, Salvatore Bonaccorso wrote:
> > Hi Niklas,
> >
> > On Fri, Sep 12, 2025 at 08:02:02PM +0200, Niklas Cathor wrote:
> > > Hi Salvatore,
> > >
> > > I encountered the same issue, and was able to bisect. I'm pasting the result
> > > below.
> > > Thank you for looking into this. Let me know if I should report it upstream
> > > instead.
> > >
> > > cheers,
> > > Niklas
> > >
> > >
> > > 165a69a87d6bde85cac2c051fa6da611ca4524f6 is the first bad commit
> > > commit 165a69a87d6bde85cac2c051fa6da611ca4524f6 (HEAD)
> > > Author: Lijo Lazar <lijo.lazar@amd.com>
> > > Date:   Mon Jun 2 12:55:14 2025 +0530
> > >
> > >      drm/amdgpu: Add more checks to PSP mailbox
> > >
> > >      [ Upstream commit 8345a71fc54b28e4d13a759c45ce2664d8540d28 ]
> > >
> > >      Instead of checking the response flag, use status mask also to check
> > >      against any unexpected failures like a device drop. Also, log error if
> > >      waiting on a psp response fails/times out.
> > >
> > >      Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
> > >      Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
> > >      Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> > >      Signed-off-by: Sasha Levin <sashal@kernel.org>
> > >
> > >   drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c  |  4 ++++
> > >   drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h  | 11 +++++++++++
> > >   drivers/gpu/drm/amd/amdgpu/psp_v10_0.c   |  4 ++--
> > >   drivers/gpu/drm/amd/amdgpu/psp_v11_0.c   | 31
> > > +++++++++++++++++++------------
> > >   drivers/gpu/drm/amd/amdgpu/psp_v11_0_8.c | 25 +++++++++++++++----------
> > >   drivers/gpu/drm/amd/amdgpu/psp_v12_0.c   | 18 +++++++++++-------
> > >   drivers/gpu/drm/amd/amdgpu/psp_v13_0.c   | 25 +++++++++++++++----------
> > >   drivers/gpu/drm/amd/amdgpu/psp_v13_0_4.c | 25 +++++++++++++++----------
> > >   drivers/gpu/drm/amd/amdgpu/psp_v14_0.c   | 25 +++++++++++++++----------
> > >   9 files changed, 107 insertions(+), 61 deletions(-)
> > Ok that is great you found the offending commit. Can you try if
> > applying 440cec4ca1c2 ("drm/amdgpu: Wait for bootloader after PSPv11
> > reset") fixes the issue?
> One thing: the commit won't apply cleanly pre 9888f73679b7
> ("drm/amdgpu: Add a noverbose flag to psp_wait_for") changes. So
> either test mainline at the commit and the previous comit to confirm
> the fix, and if possible then still with a backported variant.
>
> An attempt of it is attached here which should apply on top of
> 6.16.7-1.
>
> Regards,
> Salvatore

Thanks, the patch is working for me. I've applied it on top of v6.16.7 
(131e2001572b) from mainline. Is that what you meant?
I already reproduced the bug previously on v6.16.7, now with the patch 
applied, it is fixed.

Let me know if you want me to test it on top of any other commit as well.

Regards,
Niklas