Bug#1115168: nfsutils: FTBFS: exportfs.c:83:17: error: ignoring return value of ‘lockf’ declared with attribute ‘warn_unused_result’ [-Werror=unused-result]
Source: nfs-utils
Version: 1:2.8.3-1
Severity: important
Tags: ftbfs forky sid upstream fixed-upstream
Justification: fails to build from source
User: debian-glibc@lists.debian.org
Usertags: glibc-2.42
Control: forwarded -1 https://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commit;h=9f974046c37b7c28705d5558328759fff708b1cb
Dear maintainer,
During a rebuild of all packages in unstable with glibc 2.42 from
experimental, your package failed to build. Below you will find how the
build ends. If required, the full build log is available here:
https://people.debian.org/~aurel32/glibc-2.42/
The build failure is due to a missing check of the result of the call to
lockf(), so there is no guarantee that the file is correctly locked,
basically making this call useless. Fortunately the issue has already
been fixed upstream with the following patch:
https://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commit;h=9f974046c37b7c28705d5558328759fff708b1cb
About the archive rebuild: The build was made on virtual machines from
AWS, using sbuild, a reduced chroot with only build-essential packages
and glibc 2.42 from experimental.
Regards
Aurelien
--------------------------------------------------------------------------------
[...]
Making all in utils
make[2]: Entering directory '/<<PKGBUILDDIR>>/utils'
Making all in exportfs
make[3]: Entering directory '/<<PKGBUILDDIR>>/utils/exportfs'
gcc -DHAVE_CONFIG_H -I. -I../../support/include -I/usr/include/tirpc -I/usr/include/libxml2 -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -I../../support/reexport -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -pipe -Wall -Wextra -Werror=strict-prototypes -Werror=missing-prototypes -Werror=missing-declarations -Werror=format=2 -Werror=undef -Werror=missing-include-dirs -Werror=strict-aliasing=2 -Werror=init-self -Werror=implicit-function-declaration -Werror=return-type -Werror=switch -Werror=overflow -Werror=parentheses -Werror=aggregate-return -Werror=unused-result -fno-strict-aliasing -Werror=format-overflow=2 -Werror=int-conversion -Werror=incompatible-pointer-types -Werror=misleading-indentation -Wno-cast-function-type -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o exportfs-exportfs.o `test -f 'exportfs.c' || echo './'`exportfs.c
exportfs.c: In function ‘release_lockfile’:
exportfs.c:83:17: error: ignoring return value of ‘lockf’ declared with attribute ‘warn_unused_result’ [-Werror=unused-result]
83 | lockf(_lockfd, F_ULOCK, 0);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
exportfs.c: In function ‘grab_lockfile’:
exportfs.c:77:17: error: ignoring return value of ‘lockf’ declared with attribute ‘warn_unused_result’ [-Werror=unused-result]
77 | lockf(_lockfd, F_LOCK, 0);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [Makefile:573: exportfs-exportfs.o] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/utils/exportfs'
make[2]: *** [Makefile:480: all-recursive] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>/utils'
make[1]: *** [Makefile:504: all-recursive] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j2 returned exit code 2
make: *** [debian/rules:12: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
--------------------------------------------------------------------------------
Reply to: