[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#894906: linux-cpupower: provide a systemd service and a default config file



On Fri, 21 Mar 2025 13:17:52 +0100 Salvatore Bonaccorso wrote:

[...]
> Hope that helps you to start, feel free to as well CC the Debian bug
> so that (or at least point out when you have started the discussion
> upstream so that we can mark the bug forwarded).

Hello Salvatore,
it was not a short journey, but the (refined) patch has been accepted
upstream.

Now I would like to see it shipped in the Debian package, please...

It is already present in the Debian source package:

https://sources.debian.org/src/linux/6.16.3-1/tools/power/cpupower/cpupower.sh
https://sources.debian.org/src/linux/6.16.3-1/tools/power/cpupower/cpupower.service.in
https://sources.debian.org/src/linux/6.16.3-1/tools/power/cpupower/cpupower-service.conf

But the Debian binary package does not ship the files:

  $ dpkg -l | grep cpupower | cut -c 1-77
  ii  libcpupower1                    6.16.3-1                            amd64
  ii  linux-cpupower                  6.16.3-1                            amd64
  $ dpkg -S libexec/cpupower
  dpkg-query: no path found matching pattern *libexec/cpupower*
  $ dpkg -S cpupower.service
  dpkg-query: no path found matching pattern *cpupower.service*
  $ dpkg -S cpupower-service.conf
  dpkg-query: no path found matching pattern *cpupower-service.conf*


Please note that:

 * cpupower.sh should be installed to /usr/libexec/cpupower

 * cpupower.service.in should be transformed (with some sed editing)
   into /usr/lib/systemd/system/cpupower.service  (this systemd service
   unit is disabled by default)

 * cpupower-service.conf should be installed
   to /etc/cpupower-service.conf

All this is taken care of by the Makefile, see lines 310÷315 (and other
related lines):

https://sources.debian.org/src/linux/6.16.3-1/tools/power/cpupower/Makefile#L310


Please modify Debian binary package 'linux-cpupower', so that it
correctly ships the three above-mentioned files in the correct
destinations, with the systemd service unit disabled by default.


Looking forward to seeing this bug fixed once and for all.
Thanks for your time!



-- 
 http://www.inventati.org/frx/
 There's not a second to spare! To the laboratory!
..................................................... Francesco Poli .
 GnuPG key fpr == CA01 1147 9CD2 EFDF FB82  3925 3E1C 27E1 1F69 BFFE

Attachment: pgpf_j4yoamMt.pgp
Description: PGP signature


Reply to: