[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1108484: unblock: initramfs-tools/0.148.3



Package: release.debian.org
Severity: normal
X-Debbugs-Cc: initramfs-tools@packages.debian.org, debian-kernel@lists.debian.org
Control: affects -1 + src:initramfs-tools
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package initramfs-tools

[ Reason ]
An optimisation to avoid redundant initramfs updates turned out not to
be entirely correct.

[ Impact ]
The initramfs is not always updated after a package triggers an
update.  Depending on when this happenes, this could result in boot
failure, security updates not being applied to the initramfs, or
cosmetic changes missing.

[ Tests ]
Many boot configurations are covered by autopkgtests.  There isn't a
specific test for the operation of triggers.

[ Risks ]
This reverts trigger handling to the simpler version used in earlier
versions (including in bullseye and bookworm), so there is nothing new
being introduced.  The only risk I see is that some users or tests may
have started relying on the faster operation since v0.147.

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

[ Other info ]

unblock initramfs-tools/0.148.3
Binary files /var/tmp/PvhhGc6rjC/initramfs-tools-0.148.2/copy_file and /var/tmp/7djNuEGYrC/initramfs-tools-0.148.3/copy_file differ
diff -Nru initramfs-tools-0.148.2/debian/changelog initramfs-tools-0.148.3/debian/changelog
--- initramfs-tools-0.148.2/debian/changelog	2025-06-13 00:55:37.000000000 +0200
+++ initramfs-tools-0.148.3/debian/changelog	2025-06-29 14:08:36.000000000 +0200
@@ -1,3 +1,11 @@
+initramfs-tools (0.148.3) unstable; urgency=medium
+
+  [ Benjamin Drung ]
+  * [e3f4fb4] Revert "Avoid updating the initramfs twice for some cases"
+    (Closes: #1108204)
+
+ -- Ben Hutchings <benh@debian.org>  Sun, 29 Jun 2025 14:08:36 +0200
+
 initramfs-tools (0.148.2) unstable; urgency=medium
 
   [ Benjamin Drung ]
diff -Nru initramfs-tools-0.148.2/debian/initramfs-tools.postinst initramfs-tools-0.148.3/debian/initramfs-tools.postinst
--- initramfs-tools-0.148.2/debian/initramfs-tools.postinst	2025-05-13 05:22:04.000000000 +0200
+++ initramfs-tools-0.148.3/debian/initramfs-tools.postinst	2025-06-29 13:53:22.000000000 +0200
@@ -7,13 +7,8 @@
 	# this activates the trigger, if triggers are working
 	update-initramfs -u
 else
-	# The /run/update-initramfs.dpkg-trigger file is just a workaround.
-	# The timestamp should be provided directly by the dpkg trigger.
-	# See https://bugs.debian.org/1099136
-	timestamp=$(stat -c %Y /run/update-initramfs.dpkg-trigger 2>/dev/null || true)
-	# force it to actually happen (if not already updated since activation)
-	DPKG_MAINTSCRIPT_PACKAGE='' update-initramfs -u -s "$timestamp"
-	rm -f /run/update-initramfs.dpkg-trigger
+	# force it to actually happen
+	DPKG_MAINTSCRIPT_PACKAGE='' update-initramfs -u
 fi
 
 #DEBHELPER#
diff -Nru initramfs-tools-0.148.2/update-initramfs initramfs-tools-0.148.3/update-initramfs
--- initramfs-tools-0.148.2/update-initramfs	2025-05-13 05:22:04.000000000 +0200
+++ initramfs-tools-0.148.3/update-initramfs	2025-06-29 13:53:22.000000000 +0200
@@ -14,10 +14,6 @@
 if [ -n "$DPKG_MAINTSCRIPT_PACKAGE" ] && [ $# = 1 ] && [ "$1" = -u ]; then
 	if dpkg-trigger --no-await update-initramfs; then
 		echo "update-initramfs: deferring update (trigger activated)"
-		# The /run/update-initramfs.dpkg-trigger file is just a workaround.
-		# The timestamp should be provided directly by the dpkg trigger.
-		# See https://bugs.debian.org/1099136
-		touch /run/update-initramfs.dpkg-trigger
 		exit 0
 	fi
 fi

Reply to: