[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1098250: marked as done (linux-image-arm64: USB and PCIe broken on rk356x devices)

Your message dated Fri, 28 Feb 2025 11:50:21 +0000
with message-id <E1tnysn-006ryy-P3@fasolo.debian.org>
and subject line Bug#1095745: fixed in linux 6.13.5-1~exp1
has caused the Debian Bug report #1095745,
regarding linux-image-arm64: USB and PCIe broken on rk356x devices
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1095745: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095745
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: linux
Version: 6.12.8-1
Severity: important
Tags: upstream patch
X-Debbugs-Cc: debian-arm@lists.debian.org
User: debian-arm@lists.debian.org
Usertags: arm64

https://lore.kernel.org/linux-rockchip/df8e0ff8-355b-4c18-9349-0f04ae16e01b@kwiboo.se/:

  Upstream commit fbcbffbac994 ("phy: rockchip: naneng-combphy: fix phy reset")
  broke backwards compatibly with old DTs and has already been backported
  breaking i.e. PCIe and USB on Rockchip RK356x boards on stable and
  longterm kernels.

That thread is about a patch which fixes that backward compatibility.
Further down in that thread mentioned the following:

  Trying to boot into Linux v6.1.123+, v6.6.69+ and v6.12.8+ using the
  U-Boot bundled DT for RK356x boards now result in broken PCIe, SATA and
  USB

This issue results in the following kernel errors:

  [    6.075822] rockchip-naneng-combphy fe830000.phy: error -ENOENT: failed to get phy reset
  [    6.076599] rockchip-naneng-combphy fe830000.phy: probe with driver rockchip-naneng-combphy failed with error -2
  [    6.078649] rockchip-naneng-combphy fe840000.phy: error -ENOENT: failed to get phy reset
  [    6.079420] rockchip-naneng-combphy fe840000.phy: probe with driver rockchip-naneng-combphy failed with error -2

It doesn't affect kernel 6.13 (and higher) though.

The patch has been accepted by the upstream maintainer and can be found here:
https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git/log/?h=fixes
But it hasn't been sent 'further up the chain' just yet (right now).

This means that currently USB and PCIe is broken for rk356x devices for
both Stable/Bookworm and Testing/Trixie (and Sid).

Attached you'll find the commit from the linux-phy git repo.
I haven't added the 'fixed-upstream' tag as I wasn't sure if it needed
to be accepted 'further up the chain' for that.

HTH,
  Diederik


-- System Information:
Debian Release: trixie/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: arm64 (aarch64)

Kernel: Linux 6.12.8-arm64 (SMP w/4 CPU threads)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

From: Chukun Pan <amadeus@jmu.edu.cn>
Date: Mon, 6 Jan 2025 18:00:01 +0800
Subject: phy: rockchip: naneng-combphy: compatible reset with old DT
Origin: https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git/commit?id=3126ea9be66b53e607f87f067641ba724be24181

The device tree of RK3568 did not specify reset-names before.
So add fallback to old behaviour to be compatible with old DT.

Fixes: fbcbffbac994 ("phy: rockchip: naneng-combphy: fix phy reset")
Cc: Jianfeng Liu <liujianfeng1994@gmail.com>
Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
Reviewed-by: Jonas Karlman <jonas@kwiboo.se>
Link: https://lore.kernel.org/r/20250106100001.1344418-2-amadeus@jmu.edu.cn
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
 drivers/phy/rockchip/phy-rockchip-naneng-combphy.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
index a1532ef8bbe9..8c3ce57f8915 100644
--- a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
+++ b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
@@ -324,7 +324,10 @@ static int rockchip_combphy_parse_dt(struct device *dev, struct rockchip_combphy
 
 	priv->ext_refclk = device_property_present(dev, "rockchip,ext-refclk");
 
-	priv->phy_rst = devm_reset_control_get(dev, "phy");
+	priv->phy_rst = devm_reset_control_get_exclusive(dev, "phy");
+	/* fallback to old behaviour */
+	if (PTR_ERR(priv->phy_rst) == -ENOENT)
+		priv->phy_rst = devm_reset_control_array_get_exclusive(dev);
 	if (IS_ERR(priv->phy_rst))
 		return dev_err_probe(dev, PTR_ERR(priv->phy_rst), "failed to get phy reset\n");
 
-- 
2.47.2

--- End Message ---
--- Begin Message --- 
Source: linux
Source-Version: 6.13.5-1~exp1
Done: Salvatore Bonaccorso <carnil@debian.org>

We believe that the bug you reported is fixed in the latest version of
linux, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1095745@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Salvatore Bonaccorso <carnil@debian.org> (supplier of updated linux package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 28 Feb 2025 12:01:10 +0100
Source: linux
Architecture: source
Version: 6.13.5-1~exp1
Distribution: experimental
Urgency: medium
Maintainer: Debian Kernel Team <debian-kernel@lists.debian.org>
Changed-By: Salvatore Bonaccorso <carnil@debian.org>
Closes: 1095745 1098250 1098354 1098661 1098706
Changes:
 linux (6.13.5-1~exp1) experimental; urgency=medium
 .
   * New upstream stable update:
     https://www.kernel.org/pub/linux/kernel/v6.x/ChangeLog-6.13.5
 .
   [ Salvatore Bonaccorso ]
   * kbuild: Add Depends on pahole (Closes: #1098706)
   * [arm64] phy: rockchip: naneng-combphy: compatible reset with old DT
     (Closes: #1095745, #1098250, #1098354)
 .
   [ Uwe Kleine-König ]
   * Revert to disabled EFI_ZBOOT for the time being (Closes: #1098661)
 .
   [ Steev Klimaszewski ]
   * [arm64] Enable modules for Thinkpad X13s webcam
 .
   [ Alper Nebi Yasak ]
   * [arm64] Enable modules for Qualcomm SC7180 Chromebooks
     - Enable SC_GPUCC_7180 and INTERCONNECT_QCOM_SC7180 as modules
     - Enable SC_DISPCC_7180, SC_VIDEOCC_7180 and SC_CAMCC_7180 as modules
     - Enable SC_LPASS_CORECC_7180, SND_SOC_ADAU7002, SND_SOC_SC7180 as modules
     - Enable IIO_CROS_EC_SENSORS_LID_ANGLE and CROS_EC_MKBP_PROXIMITY as modules
     - Enable EDAC_QCOM and SPI_QCOM_QSPI as modules
   * [arm64] udeb: Add modules fo Qualcomm SC7180 Chromebooks
     - Add gcc-sc7180 and qnoc-sc7180 to kernel-image
     - Add dispcc-sc7180 and gpucc-sc7180 to fb-modules
   * [arm64] Enable SC_LPASSCC_7280 as module
Checksums-Sha1:
 daec89a06060ea4b212b19a1b35c0bb16587231d 200434 linux_6.13.5-1~exp1.dsc
 ff5d6ed5ccdeed6283bd6a3b0211890b515a0120 151523160 linux_6.13.5.orig.tar.xz
 49e3853e618ac504f30f4dce95d883b9478fe680 1543564 linux_6.13.5-1~exp1.debian.tar.xz
 64ac723f70823bf20cb7f55ccfd6b99fdbf3b9f3 7099 linux_6.13.5-1~exp1_source.buildinfo
Checksums-Sha256:
 7219920f09719e232d00b0d5b17d5a170f0ee92d10a1f20bd1d265e6a3192284 200434 linux_6.13.5-1~exp1.dsc
 187814a473a3323aef7175a32f6b0b668de271cd381ba55b9d2d71ad48b2891b 151523160 linux_6.13.5.orig.tar.xz
 c32a5060f1c9eca8baaf6babb508dc5eca90247e963be559ad3e314b209d12c4 1543564 linux_6.13.5-1~exp1.debian.tar.xz
 cb2380d5a9f210572d69bf7180c410a6030352ae8de885a0873bc941d55d1168 7099 linux_6.13.5-1~exp1_source.buildinfo
Files:
 8de277f66a522505044629c60ceb3ffb 200434 kernel optional linux_6.13.5-1~exp1.dsc
 26210f36181d46d7c93f7b4f5b15b872 151523160 kernel optional linux_6.13.5.orig.tar.xz
 8acbacaf4e018e8aa18deeae712e0834 1543564 kernel optional linux_6.13.5-1~exp1.debian.tar.xz
 db598fb4567e6aa4e3207148803e0df3 7099 kernel optional linux_6.13.5-1~exp1_source.buildinfo


-----BEGIN PGP SIGNATURE-----

iQKmBAEBCgCQFiEERkRAmAjBceBVMd3uBUy48xNDz0QFAmfBmCFfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDQ2
NDQ0MDk4MDhDMTcxRTA1NTMxRERFRTA1NENCOEYzMTM0M0NGNDQSHGNhcm5pbEBk
ZWJpYW4ub3JnAAoJEAVMuPMTQ89EMYQP/1L30CBjzkeIUhkqJH5Lbs7zYZcEmsSJ
z7pzOTof5ZfbUlectDj5hTFZJlFqHoPeZkEDRe3b/G/0BnIBNyctQmyveldy3uSj
CNQynGZsB9DXywgiESAVACQa15r+71v2PIIxZW1rzTo2YA4UVyjnLHFUx4e5IxKF
VPRnzhEymQlLSD2KA0crlW5BP8mwyuip7dCFyf03V1ZIrdGtp7qVvdouQGgLoI0F
5LoOzx6lK0CBsgz49YW+tlWnL3rMqGIdl9s/InwniUXcUDe3Lvmfs4BiXAnW+1y6
4kvv8RAbUIehbXyhz7ADWT2VNRQfx6fk4fe/ggNyQT3pALDXIuiVUXEwV7vq2MfE
mWj67V1Ph2jUdlqfG6P/4azP5gXwPZrS65hhzRYifmLKY3OgLf6yFW1XVk/n6jFF
6a99fHmszA3PleTeOH9l8ZPfYn75zl3a24kYXoAFrdvo4VvHJoL+/Nlq/LLniyaO
D/kU+GsmGiXO1icGHtJM9nJqpJvfdYL+vBpfCllUQItljstj/N4C7gO2jDrqf79q
rIZW6i3oOX74ORPg7AdRZZLuLZy8/sILo1hY4B0olRDRCfNSuP+DWEGIw7Er+fwj
kI7PvfTkq/XIixCAf/HS/d5p0rrH0iqmYOr6nIVjbHVRYLltEE6YB+3vBvBvks9X
g3Rket7mBb6f
=1MaJ
-----END PGP SIGNATURE-----

Attachment: pgpvp1MJlkXVE.pgp
Description: PGP signature


--- End Message ---
Reply to: