[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1040738: marked as done (linux: Please review firmware related Debian patches)

Your message dated Wed, 19 Jun 2024 15:00:12 +0000
with message-id <E1sJwnE-0063cs-Eg@fasolo.debian.org>
and subject line Bug#1040738: fixed in linux 6.9.2-1~exp1
has caused the Debian Bug report #1040738,
regarding linux: Please review firmware related Debian patches
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1040738: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1040738
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: linux
Version: 6.4.1-1~exp1
Severity: wishlist

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

While working on building/testing a Debian kernel for the PineTab2 I
noticed that I got a firmware (related) *error* in `dmesg`, while that
was not the case on a kernel with a Debian (based) config and the
upstream kernel source. Neither was it reported as an error in the OOTB
provided image/kernel (ALARM).
In both other cases it was reported as a *warning*.

When I build a new Debian kernel with the "firmware_class: Log every
success and failure against given device" patch removed (and adjusted
`d/patches/debian/firmware_class-refer-to-debian-wiki-firmware-page.patch`
to fix the resulting issue), then that same firmware related message was
reported as a warning too.

Before:  
```
root@pinetab2:~# dmesg --level emerg,alert,crit,err
[    0.000000] clk: failed to reparent gpll to clk_rtc32k_frac: -22
[    0.000000] clk: failed to reparent gpll to clk_rtc32k_frac: -22
[   23.391432] spi-nor spi4.0: unrecognized JEDEC id bytes: 00 00 00 00 00 00
[   23.466581] ov5648 2-0036: failed to find 168000000 clk rate in endpoint link-frequencies
[   23.513593] Goodix-TS 1-005d: firmware: failed to load goodix_911_cfg.bin (-2)
[   23.513603] firmware_class: See https://wiki.debian.org/Firmware for information about missing firmware
[   23.513640] Goodix-TS 1-005d: firmware: failed to load goodix_911_cfg.bin (-2)
```

After:  
```
root@pinetab2:~# dmesg --level emerg,alert,crit,err
[    0.000000] clk: failed to reparent gpll to clk_rtc32k_frac: -22
[    0.000000] clk: failed to reparent gpll to clk_rtc32k_frac: -22
[   32.571259] firmware_class: See https://wiki.debian.org/Firmware for information about missing firmware
[   32.589465] ov5648 2-0036: failed to find 168000000 clk rate in endpoint link-frequencies
```
Note: The `spi-nor` msg already disappeared on a reboot, but is
irrelevant anyway. And looks like my patch (removal) wasn't complete,
but that also seems irrelevant.

I really don't like ignoring errors I see in `dmesg`. But this isn't the
first instance where I was inclined to do exactly that as the
Debian patch(es) 'upgrade' an upstream warning to an error.
And IIUC/IIRC I've also seen that several times when triaging Debian
kernel bugs, f.e. with an issue which 'rhymes' with yolo-debug.

So hereby a request to review the firmware related Debian patches to see
whether they still are the best way to solve the (initial) problem and
if not, improve on them so they will.

Cheers,
  Diederik

- -- System Information:
Debian Release: trixie/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (500, 'testing'), (500, 'oldstable'), (101, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.3.0-2-amd64 (SMP w/16 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

-----BEGIN PGP SIGNATURE-----

iHUEARYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZKsmVQAKCRDXblvOeH7b
bg0LAP43Zo91VX1KK8d7/Icsl3JerHPBmNAOskhTvGv3NkT5yAD+Obg69navr+Rw
sNgU43OHquxKFhGhlBOo1UWN+M9XNAg=
=9ctN
-----END PGP SIGNATURE-----

--- End Message ---
--- Begin Message --- 
Source: linux
Source-Version: 6.9.2-1~exp1
Done: Ben Hutchings <benh@debian.org>

We believe that the bug you reported is fixed in the latest version of
linux, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1040738@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ben Hutchings <benh@debian.org> (supplier of updated linux package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 19 Jun 2024 15:34:34 +0200
Source: linux
Architecture: source
Version: 6.9.2-1~exp1
Distribution: experimental
Urgency: medium
Maintainer: Debian Kernel Team <debian-kernel@lists.debian.org>
Changed-By: Ben Hutchings <benh@debian.org>
Closes: 857198 966218 1040738 1071551
Changes:
 linux (6.9.2-1~exp1) experimental; urgency=medium
 .
   * New upstream release: https://kernelnewbies.org/Linux_6.9
   * New upstream stable update:
     https://www.kernel.org/pub/linux/kernel/v6.x/ChangeLog-6.9.1
     https://www.kernel.org/pub/linux/kernel/v6.x/ChangeLog-6.9.2
 .
   [ Johannes Schauer Marin Rodrigues ]
   * New target in debian/rules: "clean-generated" cleans up all auto-generated
     files inside the ./debian directory
 .
   [ Diederik de Haas ]
   * [arm64,riscv64] drivers/leds/rgb: Enable LEDS_GROUP_MULTICOLOR as module
   * [arm64] drivers/leds/rgb: Enable LEDS_PWM_MULTICOLOR as module
   * [arm*,riscv64] drivers/pps/clients: Enable PPS_CLIENT_GPIO as module
   * Update to 6.9.2:
     - Drop patches:
       - "ntfs: mark it as broken"; ntfs driver removed upstream
     - Drop patches applied upstream:
       - "ARM64: Dynamically allocate cpumasks and increase supported CPUs to
         512"
       - "tipc: fix UAF in error path"
       - "tipc: fix a possible memleak in tipc_buf_append"
     - Refresh patches:
       - Adjust context in "video: Remove nvidiafb and rivafb"
       - Adjust context in "Export symbols needed by Android drivers"
       - Adjust context in "Documentation: Drop sphinx version check"
       - Adjust context in "firmware_class: Log every success and failure
         against given device"
       - Adjust context in "firmware: Remove redundant log messages from drivers"
       - Adjust context in "af_802154: Disable auto-loading as mitigation
         against local exploits"
       - Adjust context in "intel-iommu: Add Kconfig option to exclude iGPU by
         default"
       - Adjust context in "x86: Make x32 syscall support conditional on a
         kernel parameter"
       - Adjust context in "efi: Lock down the kernel if booted in secure boot
         mode"
       - Adjust context in "Revert 'perf build: Fix libunwind feature detection
         on 32-bit x86'"
   * tools/rtla: Restore option to set VERSION var to VERSION file's contents
   * d/rules.d: rtla: Update Makefile for upstream restructuring
   * d/config: Update with the help of kconfigeditor2:
     - [x86] arch/x86: Rename RETPOLINE to MITIGATION_RETPOLINE
     - [amd64] arch/x86: Rename SLS to MITIGATION_SLS
     - [x86] drivers/acpi: Remove ACPI_CUSTOM_METHOD
     - drivers/mtd/maps: Remove MTD_INTEL_VR_NOR
     - drivers/staging/board: Remove STAGING_BOARD
     - fs/ntfs: Remove NTFS_FS
     - lib/Kconfig.debug: Rename TEST_STRING_HELPERS to STRING_HELPERS_KUNIT_TEST
     - net/bluetooth: Remove BT_HS
     - net/ipv4/netfilter: Remove IP_NF_ARPTABLES
     - net/sched: Remove NET_ACT_IPT
   * [rt] Update to 6.9-rt5
   * [rt] pinctrl: renesas: rzg2l: use spin_{lock,unlock}_irq{save,restore}
 .
   [ Ben Hutchings ]
   * d/signing_templates/rules.real: Consistently define REAL_VERSION variable
   * d/signing_templates: Define BUILD_DIR and STAMPS_DIR, and clean those dirs
   * d/signing_templates/rules.real: Use an intermediate install directory
   * Revert "Revert "Run dh_movetousr also in signed images."", as this now
     works
   * firmware_loader: Remove most Debian-specific logging changes
     (Closes: #1040738):
     - Revert "firmware_class: Refer to Debian wiki page when logging missing
       firmware"
     - Revert "firmware: Remove redundant log messages from drivers"
     - Revert "firmware_class: Log every success and failure against given
       device" (Closes: #857198, #966218)
     - firmware_loader: Log direct loading failures as info for d-i
   * d/rules.d/tools/tracing/rtla: Delete redundant sed command
 .
   [ Macpaul Lin ]
   * [arm64] Enable support for various MediaTek SoCs:
     - Enable COMMON_CLK_MT8188 and related clocks, COMMON_CLK_MT8365 and
       related clocks, and COMMON_CLK_MT8195_IPESYS as modules
     - Enable pin controllers for MT2712, MT6765, MT6779, MT6795, MT6797,
       MT7622, MT7981, MT7986, MT8167, MT8186, MT8188, MT8192, MT8365,
       MT8516, MT6397
     - Enable REGULATOR_MT6357, REGULATOR_MT6360 as modules
     - Enable CHARGER_MT6360 and TYPEC_MT6360 as modules
     - Enable REALTEK_PHY, DWMAC_MEDIATEK as modules
     - Enable MTK_DEVAPC as a module
 .
   [ Alper Nebi Yasak ]
   * [arm64] Merge and document MediaTek-related changes by Macpaul Lin:
     - Resolve conflicts with merge requests merged earlier
     - Clean up config with the help of kconfigeditor2
     - Change COMMON_CLK_MT8188, COMMON_CLK_MT8365 to be modules
   * [arm64] Enable more clock drivers for various MediaTek SoCs:
     - Enable COMMON_CLK_MT2712, COMMON_CLK_MT6779, COMMON_CLK_MT6795,
       COMMON_CLK_MT7622, COMMON_CLK_MT7986, COMMON_CLK_MT8167,
       COMMON_CLK_MT8186, COMMON_CLK_MT8192, COMMON_CLK_MT8516,
       and all their related clocks as modules
     - Enable COMMON_CLK_MT6765, COMMON_CLK_MT6797, COMMON_CLK_MT7981 as
       built-in (no module choice) and enable all their related clocks as
       modules
 .
   [ Vincent Blut ]
   * [x86] drivers/pinctrl/intel: Enable PINCTRL_METEORLAKE and
     PINCTRL_METEORPOINT as modules (Closes: #1071551)
 .
   [ Aurelien Jarno ]
   * [riscv64] Improve support for StarFive VisionFive 2:
     - Enable SIFIVE_CCACHE
     - Enable USB_CDNS_SUPPORT, USB_CDNS3, USB_CDNS3_STARFIVE as modules and
       enable CDNS3_GADGET and CDNS3_HOST options
     - Enable USB_GADGET as module
 .
   [ Sebastian Andrzej Siewior ]
   * linux-image: postrm: Remove modules.weakdep on purge.
Checksums-Sha1:
 20ae1f4fa1e8636229ecb68a1c82f99055343917 224561 linux_6.9.2-1~exp1.dsc
 4d779991dd08a5cc9457ea45c7beefd0ae2385c3 146820268 linux_6.9.2.orig.tar.xz
 67ba60a9f6d9d158bfd83a50ffc6317c69d6eed3 1542748 linux_6.9.2-1~exp1.debian.tar.xz
 ada20cfecaf6acb041035f5c483ea258db98f9c5 7805 linux_6.9.2-1~exp1_source.buildinfo
Checksums-Sha256:
 8d9d9a224975fb0dcebb4a1023eb6a1b2a5fab3012038f17af43ac430697494b 224561 linux_6.9.2-1~exp1.dsc
 61657b2772570c5c77bb4fadbae8cbfc7f1e9e0477d0a8849157de2c73359fb1 146820268 linux_6.9.2.orig.tar.xz
 7ef2da53391fd21aa339605c0ae9b9d6eac252710a1c0dbb07713fd979039f66 1542748 linux_6.9.2-1~exp1.debian.tar.xz
 f741a01f86efc579fffcddbbc1eae491ccbab41c0a1c71c79e55701fdd44f21e 7805 linux_6.9.2-1~exp1_source.buildinfo
Files:
 cc06b1178bfb43eb1d85cb0bdcd7886b 224561 kernel optional linux_6.9.2-1~exp1.dsc
 6d4c4aad39e103918033f84b646575db 146820268 kernel optional linux_6.9.2.orig.tar.xz
 d412ab148cbcab5e3cdf5e0491ae0494 1542748 kernel optional linux_6.9.2-1~exp1.debian.tar.xz
 453977639c26874d840b968fc9ae3ac4 7805 kernel optional linux_6.9.2-1~exp1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAmZy3xAACgkQ57/I7JWG
EQm1HA//TFEfluc2WJxmzHEceIcJvhRUVjzWvunPtbU/1xSyxBsIRGepyF2VPJKo
bS/ciQZUQEoQ6GbmAFsV8qHT/7CWrjMLf3Ql7wbzWwnKLXHjXGpBSjECu9taWOvE
aac1OkUO9i2lajpXEABikhlNVycwOmp5E+Ufh5irvuvp8HtsL04azYKurLytIz+0
Vml3ndzo/YZVkLa2v6MZm2IGDm/iSLSwSpc9WAYfOyP7xs6E8PCaAiaCdsOdYeRc
8WurVI9tjaLycE3A8Ntys80JVe1wPkUVvjNuP3o6PiO/p4/7D/eJT9uT3T+I6scU
JlYy5d9wKPcbikoKhJWVEMCnzi3rhBxFl4NFjKrbG9qF6b6kwjx1BH8qms2dLC56
X0awLQAttcp0V0vWqLqoQnuBMUeo6kCReRp0/6v9qm+U+ohYj1JzkXqT7epfJVxW
RiFgv4oEXthEg5cz3U2wmQXRjcqGO5T0NTG66jLpFMUWGwQOAUEYmiC0kJyclF45
4J7hnK45AUGOhMjSYHcYKoqfRLES3K08lOtIQxZPrb0S6clJQfKAVdekymTcuGY8
G1ex493E9cpMZCiYsE9iEXbeL0Do6hx+/52n4f/Cv4auW6XzPsU+wTNFDmeY7q7v
aiiZwAqU4nzW/Om8OnZ5Z4im2/1ePyVpdU9F+a/rS4PYguBF9/Y=
=SWVV
-----END PGP SIGNATURE-----

Attachment: pgptGKe92gUnm.pgp
Description: PGP signature


--- End Message ---
Reply to: