[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1069082: linux-image-6.1.0-20-amd64: USB ethernet AX88179 device name eth0



Hi Salvatore!

On Di, 16 Apr 2024, Salvatore Bonaccorso wrote:

> > Maybe it has to do with the following commit from
> > https://cdn.kernel.org/pub/linux/kernel/v6.x/ChangeLog-6.1.85
> > 
> > commit fc77240f6316d17fc58a8881927c3732b1d75d51
> > Author: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
> > Date:   Wed Apr 3 15:21:58 2024 +0200
> > 
> >     net: usb: ax88179_178a: avoid the interface always configured as random address
> >     
> >     commit 2e91bb99b9d4f756e92e83c4453f894dda220f09 upstream.
> >     
> >     After the commit d2689b6a86b9 ("net: usb: ax88179_178a: avoid two
> >     consecutive device resets"), reset is not executed from bind operation and
> >     mac address is not read from the device registers or the devicetree at that
> >     moment. Since the check to configure if the assigned mac address is random
> >     or not for the interface, happens after the bind operation from
> >     usbnet_probe, the interface keeps configured as random address, although the
> >     address is correctly read and set during open operation (the only reset
> >     now).
> >     
> >     In order to keep only one reset for the device and to avoid the interface
> >     always configured as random address, after reset, configure correctly the
> >     suitable field from the driver, if the mac address is read successfully from
> >     the device registers or the devicetree. Take into account if a locally
> >     administered address (random) was previously stored.
> >     
> >     cc: stable@vger.kernel.org # 6.6+
> >     Fixes: d2689b6a86b9 ("net: usb: ax88179_178a: avoid two consecutive device resets")
> >     Reported-by: Dave Stevenson  <dave.stevenson@raspberrypi.com>
> >     Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
> >     Reviewed-by: Simon Horman <horms@kernel.org>
> >     Link: https://lore.kernel.org/r/20240403132158.344838-1-jtornosm@redhat.com
> >     Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> >     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > 
> > Seems, that I'm not alone with this issue, there are also reports in
> > https://www.reddit.com/r/debian/comments/1c304xn/linuximageamd64_61851_usb_link_interface_names/
> > and https://infosec.space/@topher/112276500329020316
> > 
> > 
> > All other (pci based) network interfaces still use there static names
> > (enp0s25, enp2s0, enp3s0), only the usb ethernet name is broken with
> > the new kernel.

> If you revert that commit, does that fix your issue? Note that it
> opens up again as well the referenced issue, but it would be helpfull
> for reporting as regression if we know that's the case.

I didn't try this out myself, but according to
https://unix.stackexchange.com/questions/774594/debian-12-all-of-sudden-my-usb3-lan-adapter-get-assigned-random-mac-address-ea
the root cause comes from the following patch:

https://mirrors.edge.kernel.org/pub/linux/kernel/v6.x/ChangeLog-6.1.77
commit 5c4cbec5106d2f3c055ad138165e60a73f5b355c
Author: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
Date:   Mon Nov 20 13:11:41 2023 +0100

    net: usb: ax88179_178a: avoid two consecutive device resets
    
    [ Upstream commit d2689b6a86b9d23574bd4b654bf770b6034e2c7e ]
    
    The device is always reset two consecutive times (ax88179_reset is called
    twice), one from usbnet_probe during the device binding and the other from
    usbnet_open.
    
    Remove the non-necessary reset during the device binding and let the reset
    operation from open to keep the normal behavior (tested with generic ASIX
    Electronics Corp. AX88179 Gigabit Ethernet device).
    
    Reported-by: Herb Wei <weihao.bj@ieisystem.com>
    Tested-by: Herb Wei <weihao.bj@ieisystem.com>
    Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
    Link: https://lore.kernel.org/r/20231120121239.54504-1-jtornosm@redhat.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>


A.B says on stackexchange, that both patches have to be reverted to
make this working again.

I did not yet try this out myself, because I use precompiled kernels
for ages and have to re-learn again how to patch and build a kernel.

Greetings
Roland


Reply to: