Bug#1036543: [PATCH 5.10 076/529] crypto: ccp: Use the stack for small SEV command buffers
- To: Ben Hutchings <ben@decadent.org.uk>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
- Cc: stable@vger.kernel.org, patches@lists.linux.dev, Sean Christopherson <seanjc@google.com>, Brijesh Singh <brijesh.singh@amd.com>, Tom Lendacky <thomas.lendacky@amd.com>, Paolo Bonzini <pbonzini@redhat.com>, Sasha Levin <sashal@kernel.org>, Julien Cristau <jcristau@debian.org>, 1036543@bugs.debian.org
- Subject: Bug#1036543: [PATCH 5.10 076/529] crypto: ccp: Use the stack for small SEV command buffers
- From: "Adam D. Barratt" <adam@adam-barratt.org.uk>
- Date: Fri, 18 Aug 2023 21:26:09 +0100
- Message-id: <[🔎] 413120de0cd467cc5dfe87045d8750e3223a368b.camel@adam-barratt.org.uk>
- Reply-to: "Adam D. Barratt" <adam@adam-barratt.org.uk>, 1036543@bugs.debian.org
- In-reply-to: <c83138f6c2b65d0b51868af537ba03533f724cf8.camel@decadent.org.uk>
- References: <20230310133804.978589368@linuxfoundation.org> <20230310133808.495306749@linuxfoundation.org> <80d3ba7a1b8b7d65713f66ca3562a5ec4971c5ee.camel@decadent.org.uk> <2023051720-studied-plutonium-7fa8@gregkh> <2023051729-jumbo-uncolored-05c1@gregkh> <c83138f6c2b65d0b51868af537ba03533f724cf8.camel@decadent.org.uk> <ZGssRWZLuhHtfCUD@carotte>
Control: close -1 5.10.191-1
On Fri, 2023-05-26 at 17:36 +0200, Ben Hutchings wrote:
> On Wed, 2023-05-17 at 16:06 +0200, Greg Kroah-Hartman wrote:
> > On Wed, May 17, 2023 at 04:02:35PM +0200, Greg Kroah-Hartman wrote:
> > > On Wed, May 17, 2023 at 02:56:21PM +0200, Ben Hutchings wrote:
[..]
> > > Julien Cristau reported a regression in ccp - the
> > > > WARN_ON_ONCE(!virt_addr_valid(data)) is now being triggered. I
> > > > believe
> > > > this was introduced by the above commit, which depends on:
> > > >
> > > > commit 8347b99473a313be6549a5b940bc3c56a71be81c
> > > > Author: Sean Christopherson <seanjc@google.com>
> > > > Date: Tue Apr 6 15:49:48 2021 -0700
> > > >
> > > > crypto: ccp: Play nice with vmalloc'd memory for SEV
> > > > command structs
> > > >
> > > > Ben.
> > > >
> > >
> > > Thanks for letting me know, now queued up.
> >
> > Nope, now dropped, it breaks the build :(
>
> I've now looked further and found that we need both:
>
> d5760dee127b crypto: ccp: Reject SEV commands with mismatching
> command buffer
> 8347b99473a3 crypto: ccp: Play nice with vmalloc'd memory for SEV
> command structs
>
> (Not yet tested; I'll ask Julien if he can do that.)
>
Having just upgraded several affected debian.org nodes, I'm happy to
confirm that the 5.10.191-1 kernel resolves the issue for us.
Regards,
Adam
Reply to: