[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1035840: marked as done (nfs-utils: nfs-idmapd startup race condition due to missing systemd dependency)

Your message dated Tue, 01 Aug 2023 13:19:48 +0000
with message-id <E1qQpHw-0014fF-0D@fasolo.debian.org>
and subject line Bug#1035840: fixed in nfs-utils 1:2.6.3-3
has caused the Debian Bug report #1035840,
regarding nfs-utils: nfs-idmapd startup race condition due to missing systemd dependency
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1035840: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1035840
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: nfs-common
Version: 1:1.3.4-6
Severity: important
Tags: upstream
X-Debbugs-Cc: debian@aram.nubmail.ca

Dear Maintainer,

The nfs-idmapd.service included in nfs-utils does not wait for the
network to start. If DNS resolution is not yet available, and no domain
is explicitly set up in the config file, then due to
the behavior of libnfsidmap, the NFSv4 domain reverts to the default
"localdomain", which breaks id mapping, and thus any export that needs
it.

nfs-server.service already has Wants= and After=network-online.target,
but nfs-idmapd.service starts after it, potentially before the network
is up. Given that nfs-idmapd needs the network, DNS specifically, the same
should probably be added to its systemd service.

It's worth noting that in my case, adding this did not completely
resolve the race condition (i.e., DNS still came up after), but it did
reduce the amount of delay I needed to add to nfs-idmapd.service startup
to have id mapping start correctly.

This issue exists in the upstream nfs-utils source.

Part of the problem needs to be addressed in libnfsidmap: if the
DNS lookup of the hostname fails, it fallsback to "localdomain", but
it could instead use the domain part of the hostname, if it exists. I
will create a separate bug report for that.

I sent an email about this to the nfs mailing list with more info about
the race overall as well as the context, but got no responses (see https://marc.info/?l=linux-nfs&m=167834665013860&w=2).
I'm hoping someone on the Debian team can point me in the right direction in terms of whether this fix is
appropriate and how to submit a patch upstream.

Thanks,

Aram

-- Package-specific info:
-- rpcinfo --

-- System Information:
Debian Release: 11.4
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-16-amd64 (SMP w/4 CPU threads)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages nfs-common depends on:
ii  adduser             3.118
ii  keyutils            1.6.1-2
ii  libc6               2.31-13+deb11u3
ii  libcap2             1:2.44-1
ii  libcom-err2         1.46.2-2
ii  libdevmapper1.02.1  2:1.02.175-2.1
ii  libevent-2.1-7      2.1.12-stable-1
ii  libgssapi-krb5-2    1.18.3-6+deb11u1
ii  libkeyutils1        1.6.1-2
ii  libkrb5-3           1.18.3-6+deb11u1
ii  libmount1           2.36.1-8+deb11u1
ii  libnfsidmap2        0.25-6
ii  libtirpc3           1.3.1-1+deb11u1
ii  libwrap0            7.6.q-31
ii  lsb-base            11.1.0
ii  rpcbind             1.2.5-9
ii  ucf                 3.0043

Versions of packages nfs-common recommends:
ii  python3  3.9.2-3

Versions of packages nfs-common suggests:
pn  open-iscsi  <none>
pn  watchdog    <none>

Versions of packages nfs-kernel-server depends on:
ii  keyutils      1.6.1-2
ii  libblkid1     2.36.1-8+deb11u1
ii  libc6         2.31-13+deb11u3
ii  libcap2       1:2.44-1
ii  libsqlite3-0  3.34.1-3
ii  libtirpc3     1.3.1-1+deb11u1
ii  libwrap0      7.6.q-31
ii  lsb-base      11.1.0
ii  netbase       6.3
ii  ucf           3.0043

-- Configuration Files:
/etc/default/nfs-common changed [not included]

-- no debconf information

--- End Message ---
--- Begin Message --- 
Source: nfs-utils
Source-Version: 1:2.6.3-3
Done: Salvatore Bonaccorso <carnil@debian.org>

We believe that the bug you reported is fixed in the latest version of
nfs-utils, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1035840@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Salvatore Bonaccorso <carnil@debian.org> (supplier of updated nfs-utils package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 01 Aug 2023 15:10:41 +0200
Source: nfs-utils
Architecture: source
Version: 1:2.6.3-3
Distribution: unstable
Urgency: medium
Maintainer: Debian kernel team <debian-kernel@lists.debian.org>
Changed-By: Salvatore Bonaccorso <carnil@debian.org>
Closes: 1035840
Changes:
 nfs-utils (1:2.6.3-3) unstable; urgency=medium
 .
   * nfs-idmapd.service: add network-online.target to Wants= and After=
     (Closes: #1035840)
   * libnfsidmap: try to get the domain directly from hostname if the DNS
     lookup fails and always show the log message if the domain can't be
     determined
Checksums-Sha1: 
 ce6ff4614e60df4d302543d26a94db59251d1bde 2554 nfs-utils_2.6.3-3.dsc
 b1106f28b9bc542a55932db5db7044628a37e10f 49784 nfs-utils_2.6.3-3.debian.tar.xz
Checksums-Sha256: 
 952fbcbef705adc0a2dfeafb73482d40a4dcb290cc51400fa4b7b6374bdd5757 2554 nfs-utils_2.6.3-3.dsc
 8e1e918875cee085e24a93beb64044bd5249fa820b5a34fb8f527ee5777250b0 49784 nfs-utils_2.6.3-3.debian.tar.xz
Files: 
 20d6a1a59febdc9c0aff76a97ac2c78a 2554 net optional nfs-utils_2.6.3-3.dsc
 fb0b8b7776b050fbb6a3c540f9cdf4e9 49784 net optional nfs-utils_2.6.3-3.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQKmBAEBCgCQFiEERkRAmAjBceBVMd3uBUy48xNDz0QFAmTJBPJfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDQ2
NDQ0MDk4MDhDMTcxRTA1NTMxRERFRTA1NENCOEYzMTM0M0NGNDQSHGNhcm5pbEBk
ZWJpYW4ub3JnAAoJEAVMuPMTQ89Ekl8P/3UR90BHi6oMfXyR2rxR/TVAuQoXTEXR
nOAX2q2y0ynyyLFCJASy/aGJZyO1Ax9+taVB+qo1mpuQwPD/C6OH9UHea3lbvuKS
RrirXuntr2Wh6eI59mIZinT5LyIkPz+3HWPFUHrfY69WEX88QoitrXkIPU39fizQ
EbEXIUEQsHNfiKqSMVAK6Wxq5G//RfjthmjU0PqB4M1fiN7OQeMWZIfh/Zy+Ldkm
99GO063+nkhtOLcf8++GN0Eji8dp2zQ6ZySIs150vMV5DF1//A5wC08CxSYY/Aa+
r2gqH9DG9Hrp1Fnp7kLY8tLeMKzUF1MOEybYPGqZccbNBlFG40vkZRXM8D+3E3sg
zgiVKcptVzOVKGjl/DgWHDzu0fc0wdwvqClzONs95S+P73kP5lqXTAOHGp8yGaKp
zMh7oCoBZ/+jjWR8HFTpJ9S9h2xVLGE7GV796GF7i6Q9wzUt2sYUazoEyS2NnaKq
GbsvXbdh2/vIY0mcnGbzLHB6nLfD86Dnw/A6/5gmuKuPXWKuoeIK4OkdL1IhPFjG
WQE/z4utkBaCNXe0Cu9Yg9QjAdUCtqzoFndB0Eu4nbaau2ShhfvHGDhz3ZYZNqat
isy/EQeAf5vhtjkcOHfvVKZlRLEV4tZ2tUKKY72UfOQpgQjR5E9Ao0S2l+Y76nfV
v17N8h8VFU/N
=wrkP
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: