Bug#1029356: Thinkpad AMD: amd_pmc module is required for correct s0ix (Windows mode) suspend
Control: tags -1 + moreinfo
Hi Didier,
(Adding Mario to CC, I guess he is fine with it, given as well
involved in Debian).
On Sat, Jan 21, 2023 at 05:54:26PM +0100, Didier 'OdyX' Raboud wrote:
> Control: tags -1 +patch -help
> Control: clone -1 -2
> Control: retitle -2 Thinkpad AMD: amd_pmc module is required for correct s0ix (Windows mode) suspend
> Control: severity -2 important
>
> Hello there,
>
> My understanding is that there are two distinct bugs here; hereby splitting
> to make this clearer.
The answer here is probably "maybe".
> * Original bug, as retitled by Salvatore; S3 suspend is broken on some AMD
> Ryzens. This is fixed by this patch queue, also attached.
> https://gitlab.freedesktop.org/superm1/linux/-/commits/mlimonci/rhbz-2162013-gitlab-2357-v4/
>
> In the BIOS, "S3" is "Linux mode" for suspend.
This is one clear bug, which has now patches submitted upstream for
review, hopefully for inclusion and then tickle in in 6.1.y.
> * While investigating this; it turns out modern kernels can also suspend
> on s0ix "Windows mode", but this _requires_ the `amd_pmc` module, which
> is not loaded automatically, but it really should. This doesn't look
> like an upstream bug, but rather a Debian one.
>
> As this only shows on Laptops with a "Windows mode" BIOS configuration
> (in a box that also shows "Linux mode"), I think it's reasonable to see
> this as a bug of only "important" level (even though not resuming from
> suspend is _bad_).
>
> I don't think we have seen a patch to fix this one yet though.
I asked explicitly again here upstream, but I think there might be a
missunderstanding of each other's side. I asked upstream what can help
identify why the module is not autoloading, in the thread
https://lore.kernel.org/lkml/Y81Ja5Y%2FtgPXk5FA@eldamar.lan/#t .
Unfortunately the replies from Mario are not archived. But his final
reply was:
> Salvatore,
>
> I don't think we have a bug here. The reporters said it's working
> for s0ix.
>
> It will only load by default when the system is set to Modern
> Standby/s2idle mode in BIOS. On Lenovo systems they call this
> "Windows" sleep mode for some systems.
Didier, in my undestanding of your comments on upstream issue, you did
that actually, correct? I.e. setting to Modern Standby/s2idle mode in
BIOS, but amd_pmc was still *not* autoloading?
Regards,
Salvatore
Reply to: