[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1006149: linux-image-5.16.0-1-686: Fails to boot on T41 Thinkpads



On 3/9/22 06:03, Petra R.-P. wrote:
> Hello,
> 
> I am the "OP" with the T41 Thinkpads.
> 
> On Tue 08 Mar 2022 at 05:58:53 +0900  Damien Le Moal <damien.lemoal@opensource.wdc.com> wrote:
> 
>> Could you try taking a video of the boot messages ?
> 
> You can find my first attempt (only ≈12MB) here: https://prp.in-berlin.de/MAQ01257.MP4
> I will leave it there for 2 weeks.

This was quite readable, but unfortunately, does not tell much at all.
There are no errors but boot get stuck after sd_read_cache_type() in
sd_revalidate(), after ata scan completed. So not sure what is going on
here.

Could you try this patch:

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 62eb9921cc94..525ce40b524d 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -3320,6 +3320,7 @@ static int sd_revalidate_disk(struct gendisk *disk)
                        sd_read_block_limits(sdkp);
                        sd_read_block_characteristics(sdkp);
                        sd_zbc_read_zones(sdkp, buffer);
+                       sd_read_cpr(sdkp);
                }

                sd_print_capacity(sdkp, old_capacity);
@@ -3329,7 +3330,6 @@ static int sd_revalidate_disk(struct gendisk *disk)
                sd_read_app_tag_own(sdkp, buffer);
                sd_read_write_same(sdkp, buffer);
                sd_read_security(sdkp, buffer);
-               sd_read_cpr(sdkp);
        }

        /*

Not sure if it will help, especially if you have a clean boot with 5.15
? If you do, could you also send me the full dmesg of a boot with 5.15
kernel ? No video, dmesg output :)

I suspect that my patch that increases the timeout for read log may be
the cause for the "hang", but the root cause is that the laptop drive
does not like read log commands (there are some drives like that).
Before the patch, the failure was faster and somehow ignored. I would
like to see if dmesg shows the failures with 5.15.

> 
> Not sure if I got the loglevel right and whether the image is
> clear enough.
> 
> BTW:  This is really a T41 Thinkpad; I'm using it with an
> external monitor because its display is broken.
> 
>    Best regards,
>        Petra
> 


-- 
Damien Le Moal
Western Digital Research


Reply to: