[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#712449: marked as done (linux-image: Marvell Gigabit Ethernet sky2 driver panics on unplug re-plug, found a fix)

Your message dated Sun, 18 Apr 2021 17:34:54 +0200
with message-id <YHxRnkKUnVuDZ/mq@eldamar.lan>
and subject line Re: Bug#712449: linux-image: Marvell Gigabit Ethernet sky2 driver panics on unplug re-plug, found a fix
has caused the Debian Bug report #712449,
regarding linux-image: Marvell Gigabit Ethernet sky2 driver panics on unplug re-plug, found a fix
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
712449: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=712449
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: linux-image-3.9.5
Version: 3.9.5-3
Severity: important
Tags: patch

I get "kernel panic - not syncing: Exception occurred in interrupt"
about 25% of time when I unplug or I turn off any device plugged into
my "Marvell Technology" which uses sky2 driver. Mostly what this card
is hooked into my Playstaion 3 that frequently turns on and off 1-3
times a day. I have 2 identical "Marvell Technology" cards with both
having the same problem. I tried several different linux-image
version, linux-image-3.2.0-4-amd64 and linux-image-3.8-2-amd64, and
linux-image-3.9.5, all have same problem, until I edit sky2.c which
appears to fix the problem.


In linux source kernel, what I changed in sky2.c appears to no longer
panics any more. Before my fix it will kernal panic about 1 to 5 times
of unplug and plug-ins. After my fix it no longer panics after
unplugging and plugging in over 50 times, while at the same time the
links goes up sooner after plugging in with my fix.


I remove 2 lines (starts with "//----") in
linux-3.9.5/drivers/net/ethernet/marvell/sky2.c. With both lines
removed, my cards continues to work fine unplugging and plugging in
all my 1000 and 100-only devices, now without seeing no more kernel
panics with my fix.

static void sky2_link_down(struct sky2_port *sky2)
{
    struct sky2_hw *hw = sky2->hw;
    unsigned port = sky2->port;
    u16 reg;

//---- gm_phy_write(hw, port, PHY_MARV_INT_MASK, 0);

    reg = gma_read16(hw, port, GM_GP_CTRL);
    reg &= ~(GM_GPCR_RX_ENA | GM_GPCR_TX_ENA);
    gma_write16(hw, port, GM_GP_CTRL, reg);

    netif_carrier_off(sky2->netdev);

/* Turn off link LED */
    sky2_write8(hw, SK_REG(port, LNK_LED_REG), LINKLED_OFF);

    netif_info(sky2, link, sky2->netdev, "Link is down\n");

//---- sky2_phy_init(hw, port);
}



On my linux system is 5 ethernet (4 cards + 1 on board), and a
wireless card which is used with hostap. 4 of my ethernet plus my
wireless are all bridged as br0. The system is AMD FX-4100 black
edition CPU, with Asus M5-A97-R2.0 motherboard. My linux uses testing
"jessie" for nearly all packages, but "sid" for linux-image and
firmware.

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (1010, 'testing'), (100, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.9-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

linux-image-3.9.5 depends on no packages.

linux-image-3.9.5 recommends no packages.

Versions of packages linux-image-3.9.5 suggests:
pn  linux-firmware-image  <none>

-- no debconf information


lspci -nn
00:00.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD/ATI]
RD890 PCI to PCI bridge (external gfx0 port B) [1002:5a14] (rev 02)
00:02.0 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD/ATI]
RD890 PCI to PCI bridge (PCI express gpp port B) [1002:5a16]
00:04.0 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD/ATI]
RD890 PCI to PCI bridge (PCI express gpp port D) [1002:5a18]
00:05.0 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD/ATI]
RD890 PCI to PCI bridge (PCI express gpp port E) [1002:5a19]
00:07.0 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD/ATI]
RD890 PCI to PCI bridge (PCI express gpp port G) [1002:5a1b]
00:09.0 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD/ATI]
RD890 PCI to PCI bridge (PCI express gpp port H) [1002:5a1c]
00:0a.0 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD/ATI]
RD890 PCI to PCI bridge (external gfx1 port A) [1002:5a1d]
00:11.0 SATA controller [0106]: Advanced Micro Devices, Inc. [AMD/ATI]
SB7x0/SB8x0/SB9x0 SATA Controller [AHCI mode] [1002:4391] (rev 40)
00:12.0 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI]
SB7x0/SB8x0/SB9x0 USB OHCI0 Controller [1002:4397]
00:12.2 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI]
SB7x0/SB8x0/SB9x0 USB EHCI Controller [1002:4396]
00:13.0 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI]
SB7x0/SB8x0/SB9x0 USB OHCI0 Controller [1002:4397]
00:13.2 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI]
SB7x0/SB8x0/SB9x0 USB EHCI Controller [1002:4396]
00:14.0 SMBus [0c05]: Advanced Micro Devices, Inc. [AMD/ATI] SBx00
SMBus Controller [1002:4385] (rev 42)
00:14.2 Audio device [0403]: Advanced Micro Devices, Inc. [AMD/ATI]
SBx00 Azalia (Intel HDA) [1002:4383] (rev 40)
00:14.3 ISA bridge [0601]: Advanced Micro Devices, Inc. [AMD/ATI]
SB7x0/SB8x0/SB9x0 LPC host controller [1002:439d] (rev 40)
00:14.4 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD/ATI]
SBx00 PCI to PCI Bridge [1002:4384] (rev 40)
00:14.5 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI]
SB7x0/SB8x0/SB9x0 USB OHCI2 Controller [1002:4399]
00:15.0 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD/ATI]
SB700/SB800/SB900 PCI to PCI bridge (PCIE port 0) [1002:43a0]
00:16.0 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI]
SB7x0/SB8x0/SB9x0 USB OHCI0 Controller [1002:4397]
00:16.2 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD/ATI]
SB7x0/SB8x0/SB9x0 USB EHCI Controller [1002:4396]
00:18.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Family
15h Processor Function 0 [1022:1600]
00:18.1 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Family
15h Processor Function 1 [1022:1601]
00:18.2 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Family
15h Processor Function 2 [1022:1602]
00:18.3 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Family
15h Processor Function 3 [1022:1603]
00:18.4 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Family
15h Processor Function 4 [1022:1604]
00:18.5 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Family
15h Processor Function 5 [1022:1605]
01:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc.
[AMD/ATI] Cedar [Radeon HD 7350] [1002:68fa]
01:00.1 Audio device [0403]: Advanced Micro Devices, Inc. [AMD/ATI]
Cedar HDMI Audio [Radeon HD 5400/6300 Series] [1002:aa68]
02:00.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd.
RTL8111/8168 PCI Express Gigabit Ethernet controller [10ec:8168] (rev
09)
03:00.0 USB controller [0c03]: ASMedia Technology Inc. ASM1042
SuperSpeed USB Host Controller [1b21:1042]
04:00.0 USB controller [0c03]: ASMedia Technology Inc. ASM1042
SuperSpeed USB Host Controller [1b21:1042]
05:00.0 Network controller [0280]: Ralink corp. RT2790 Wireless
802.11n 1T/2R PCIe [1814:0781]
06:00.0 Ethernet controller [0200]: Marvell Technology Group Ltd.
88E8053 PCI-E Gigabit Ethernet Controller [11ab:4362] (rev 20)
07:05.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd.
RTL-8139/8139C/8139C+ [10ec:8139] (rev 10)
07:06.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd.
RTL-8139/8139C/8139C+ [10ec:8139] (rev 10)
08:00.0 Ethernet controller [0200]: Marvell Technology Group Ltd.
88E8053 PCI-E Gigabit Ethernet Controller [11ab:4362] (rev 20)

--- End Message ---
--- Begin Message --- 
Hi,

I'm closing this bugreport as it was reported against a now anyway
unsuported version. If the issue still persist please do reopen the
bug and add a found version.

Regards,
Salvatore

--- End Message ---
Reply to: