Bug#997709: initramfs-tools: FTBFS: shellcheck errors

[Lucas Nussbaum <lucas@debian.org>]

Source: initramfs-tools
Version: 0.140
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs
User: lucas@debian.org
Usertags: ftbfs-20211023 ftbfs-bookworm

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> shellcheck -e SC1090,SC1091 -s dash hook-functions $(find hooks scripts -type f) $({ find . -maxdepth 1 -type f -executable; find debian -maxdepth 1 -type f; find docs kernel -type f; } | xargs grep -l '^#!/bin/sh')
> 
> In scripts/nfs line 42:
> 	if [ "x${NFSROOT}" = "xauto" ]; then
>              ^-----------^ SC2268: Avoid x-prefix in comparisons as it no longer serves a purpose.
> 
> Did you mean: 
> 	if [ "${NFSROOT}" = "auto" ]; then
> 
> 
> In ./init line 170:
> 		[ "x$debug" = "xy" ] && log_output=/dev/kmsg
>                   ^-------^ SC2268: Avoid x-prefix in comparisons as it no longer serves a purpose.
> 
> Did you mean: 
> 		[ "$debug" = "y" ] && log_output=/dev/kmsg
> 
> 
> In ./update-initramfs line 14:
> if [ -n "$DPKG_MAINTSCRIPT_PACKAGE" ] && [ $# = 1 ] && [ x"$1" = x-u ]; then
>                                                          ^---^ SC2268: Avoid x-prefix in comparisons as it no longer serves a purpose.
> 
> Did you mean: 
> if [ -n "$DPKG_MAINTSCRIPT_PACKAGE" ] && [ $# = 1 ] && [ "$1" = -u ]; then
> 
> 
> In ./unmkinitramfs line 115:
> 			if [ -n "$dir" ]; then
>                                  ^--^ SC2030: Modification of dir is local (to subshell caused by (..) group).
> 
> 
> In ./unmkinitramfs line 130:
> 		xcpio "$subarchive" "${dir:+$dir/main}" -i "$@"
>                                      ^---------------^ SC2031: dir was modified in a subshell. That change might be lost.
>                                             ^--^ SC2031: dir was modified in a subshell. That change might be lost.
> 
> 
> In ./unmkinitramfs line 133:
> 		xcpio "$initramfs" "$dir" -i "$@"
>                                     ^--^ SC2031: dir was modified in a subshell. That change might be lost.
> 
> 
> In debian/initramfs-tools-core.postrm line 5:
> if [ "x${1}" = "xpurge" ]; then
>      ^-----^ SC2268: Avoid x-prefix in comparisons as it no longer serves a purpose.
> 
> Did you mean: 
> if [ "${1}" = "purge" ]; then
> 
> For more information:
>   https://www.shellcheck.net/wiki/SC2030 -- Modification of dir is local (to ...
>   https://www.shellcheck.net/wiki/SC2031 -- dir was modified in a subshell. T...
>   https://www.shellcheck.net/wiki/SC2268 -- Avoid x-prefix in comparisons as ...
> make[1]: *** [debian/rules:28: override_dh_auto_test] Error 1


The full build log is available from:
http://qa-logs.debian.net/2021/10/23/initramfs-tools_0.140_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.