[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#962545: marked as done (Invalid serial console blocks system boot)

Your message dated Fri, 11 Sep 2020 20:36:04 +0000
with message-id <E1kGpm8-000IoH-2Y@fasolo.debian.org>
and subject line Bug#960355: fixed in initramfs-tools 0.138
has caused the Debian Bug report #960355,
regarding Invalid serial console blocks system boot
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
960355: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=960355
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: initramfs-tools
Version: 0.137
Followup-For: Bug #960355

Hi Ben and Jonas, I was reporting a similar bug and found this one, thanks
to reportbug!

So, I think this is indeed a bug. The problem was vastly debugged in a
recent Launchpad issue [0], I'll give a summary here.
Currently, _log_msg() is like a void-typed function, with no return. If the
parameter "quiet" is not provided, there's a printf and then the function
returns, which in shell language means the printf return is carried over
to the caller of _log_msg().

Problem is: checkfs() makes use of error log functions, which in the end
rely on _log_msg(). If "quiet" is not supplied, and the filesystem is not
set to fsck on boot (i.e., fsck is not included in the initrd), when the
bad console is provided, an error message on checkfs_once() will eventually
reach the printf on _log_msg(), causing checkfs_once() to "inherit" the bad
return from printf.
The big issue comes now: checkfs() runs a loop, and given in this corner
case checkfs_once() returns an error state, the loop goes on forever,
effectively preventing the boot.

I consider this a bug specially because we had reports of cases in which
the serial console was working...but after a (virtual) HW update the
serial port changed, hence introducing such boot loop.

I've proposed a really simple fix in the following merge request:
salsa.debian.org/kernel-team/initramfs-tools/-/merge_requests/30

One could argue the problem is on checkfs() and we could fix there.
I disagree, I think in no way an error log message should prevent boot or
induce such errors by carrying over a bad result due to invalid console.
Also, we could rethink printf returning error in case of bad console,
but this is/will be a long-term discussion, no quick fix will outcome
from there, so I'd rather have it fixed now if possible.

Cheers,


Guilherme


[0] bugs.launchpad.net/bugs/1573095


-- System Information:
Debian Release: stretch/sid
Architecture: amd64 (x86_64)

--- End Message ---
--- Begin Message --- 
Source: initramfs-tools
Source-Version: 0.138
Done: Ben Hutchings <benh@debian.org>

We believe that the bug you reported is fixed in the latest version of
initramfs-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 960355@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ben Hutchings <benh@debian.org> (supplier of updated initramfs-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 11 Sep 2020 20:37:29 +0100
Source: initramfs-tools
Architecture: source
Version: 0.138
Distribution: unstable
Urgency: medium
Maintainer: Debian kernel team <debian-kernel@lists.debian.org>
Changed-By: Ben Hutchings <benh@debian.org>
Closes: 857054 923400 955469 959768 960355
Changes:
 initramfs-tools (0.138) unstable; urgency=medium
 .
   [ Ben Hutchings ]
   * [0b034b4] docs/maintainer-notes.md: Delete the horizontal rules
   * [ba883cb] docs/maintainer-notes.md: Use Gitlab markup for table of contents
   * [5284a00] docs/maintainer-notes.md: Use Gitlab markup for definition table
   * [a469b7e] docs/maintainer-notes.md: Use archive.org URL for Daniel Baumann
     doc
   * [424260e] debian/control, docs/maintainer-notes.md: Use my @debian.org
     address
   * [181a35c] update-initramfs: Remove test for direct invocation from kernel
     package
   * [6ebe41b] Remove obsolete update-initramfs state in
     /var/lib/initramfs-tools
   * [2f2ad0d] hook-functions: copy_exec: Copy libgcc_s.so with any soversion up
     to 9 (Closes: #959768)
   * [0f24cc1] Add CI configuration for salsa.debian.org
   * [9877542] initramfs.conf: Delete "NFS Section" comment
   * [4309c3b] Add FSTYPE config parameter to allow overriding filesystem type
     detection (Closes: #923400)
   * [6300aa1] Change "panic" parameter handling to work more like the kernel
   * [90d64bd] debian/tests: Add common test preparation code
   * [3dd2984] debian/tests: Add basic test for amd64 using klibc and not
     busybox
   * [69240b1] debian/tests: Add basic test for amd64 using busybox
   * [3d834c8] debian/tests: Add basic tests for amd64 with only ata/virtio
     driver
   * [c14b760] debian/tests: Add test for separate /usr device
   * [6b3b361] debian/tests: Add test of the panic shell and parameter handling
 .
   [ Vagrant Cascadian ]
   * [482897b] hook-functions: Add modules needed for Pinebook LCD display.
 .
   [ Guilherme G. Piccoli ]
   * [c3cbf35] scripts/functions: Prevents printf error carry over if wrong
     console is set (Closes: #960355)
 .
   [ Unit 193 ]
   * [3b82099] When overriding configured compressor, warn the user.
 .
   [ Norbert Lange ]
   * [e94f410] un-,mkinitramfs: add support for zstd (Closes: #955469)
 .
   [ Jann Horn ]
   * [a7718dc] Add firmware for built-in drivers (Closes: #857054)
Checksums-Sha1:
 34a50d294cf32e46c82e59592b948ef19dc0e8d6 1923 initramfs-tools_0.138.dsc
 db92434b29dd061ec01ff112c721f02c1b0f1d04 94668 initramfs-tools_0.138.tar.xz
 df9dfe47a5013cb3d9e001ba9954d7d644221277 5970 initramfs-tools_0.138_source.buildinfo
Checksums-Sha256:
 cdd45f17e853f38b6ff73c42259efce66403b4448b3ed938ad7a31fed8c4330f 1923 initramfs-tools_0.138.dsc
 5bb142353d8d4438f213f8dc3bc155884420785553263b2b50008ec30eb2dfb0 94668 initramfs-tools_0.138.tar.xz
 82c2e1a752a1f1306f786978da1a8e7ac9973476173a8ca4e15ad5556c8214e2 5970 initramfs-tools_0.138_source.buildinfo
Files:
 304fb7af1dd552e701dd44470a6e9d94 1923 utils optional initramfs-tools_0.138.dsc
 47056fd475d71447dcbc49fb678257ea 94668 utils optional initramfs-tools_0.138.tar.xz
 e13c7f7fccea38f044016afcbe12a62e 5970 utils optional initramfs-tools_0.138_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAl9b2O0ACgkQ57/I7JWG
EQmzMg//er6SVEJA1MAPY/tX5OoQ94YhMmZL7OROIEmYFjqLomIVUM749DUb0uU1
jyosbywPa8PKa26GvJIH0lRpTjPNWK35FBtpRcaZBpOszYDIrprh1EOxFAK/p0Fz
jjllRna7RitvHi4cy+qcF0dwk5u4Ap8vCp23ZQBC1mTJMzRWL0ScxEIgzpYzsxTM
xGpfhNTch0ErBXrd3+HEY8jjb2KfsDQTJsZH5BJYpzPnCNvjZ3uKx4d9JPCPw9Bu
5CP4WPiTbDL7Znw68OGY3RtMz3ehnZC+FbKczJeVoC/nk5wBSVzvVIAuEavY0o2P
oOSXO5LBNIVCla5VBrQIUhIbttyPxJn165Tz9FzRr9cTTadYRmZ9wx1jnFOOTk6a
9/dCrnymSzcGCB67H13PWL2OjD8Lg02PNBKD4Nu5L8j6UV+Ro/y45bSv9JwKzoBm
LE1Face5gZn+hE2rTj0hBr9zlchcLZiC/CW235UFmm6xx94EiX6GzkWwceWpQqh6
/kdzTfnjjvh3iCtK6M05d0L7bIGVOlRhnE/JYstyRiKzLhlESEL8cVbG0aTFhDL1
ZcXPlxu5QMeyUgqsXaa4pFolFB/DASgtgMhdu5WQzwsA13VB29SXw1hYRVnd+zrt
uBRDSE+47anirgoY5NDVgYgAiGpVPjCdE/87KhBij5fHRGifLqo=
=7UYp
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: