[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#958851: marked as done (initramfs-tools: autopkgtest needs update for new version of shellcheck: SC2086: Double quote to prevent globbing and word splitting.)

Your message dated Tue, 28 Apr 2020 17:33:36 +0000
with message-id <E1jTU6y-000BBR-NA@fasolo.debian.org>
and subject line Bug#958851: fixed in initramfs-tools 0.137
has caused the Debian Bug report #958851,
regarding initramfs-tools: autopkgtest needs update for new version of shellcheck: SC2086: Double quote to prevent globbing and word splitting.
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
958851: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=958851
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: initramfs-tools
Version: 0.136
Severity: serious
X-Debbugs-CC: debian-ci@lists.debian.org, shellcheck@packages.debian.org
Tags: sid bullseye
User: debian-ci@lists.debian.org
Usertags: needs-update
Control: affects -1 src:shellcheck

Dear maintainer(s),

With a recent upload of shellcheck the autopkgtest of initramfs-tools
fails in testing when that autopkgtest is run with the binary packages
of shellcheck from unstable. It passes when run with only packages from
testing. In tabular form:

                       pass            fail
shellcheck             from testing    0.7.1-1
initramfs-tools        from testing    0.136
all others             from testing    from testing

I copied some of the output at the bottom of this report.

Currently this regression is blocking the migration of shellcheck to
testing [1]. Of course, shellcheck shouldn't just break your autopkgtest
(or even worse, your package), but it seems to me that the change in
shellcheck was intended and your package needs to update to the new
situation.

If this is a real problem in your package (and not only in your
autopkgtest), the right binary package(s) from shellcheck should really
add a versioned Breaks on the unfixed version of (one of your)
package(s). Note: the Breaks is nice even if the issue is only in the
autopkgtest as it helps the migration software to figure out the right
versions to combine in the tests.

More information about this bug and the reason for filing it can be found on
https://wiki.debian.org/ContinuousIntegration/RegressionEmailInformation

Paul

[1] https://qa.debian.org/excuses.php?package=shellcheck

https://ci.debian.net/data/autopkgtest/testing/amd64/i/initramfs-tools/5145819/log.gz

autopkgtest [21:50:34]: test shellcheck: [-----------------------

In /usr/share/initramfs-tools/init line 227:
	sleep $ROOTDELAY
              ^--------^ SC2086: Double quote to prevent globbing and
word splitting.

Did you mean:
	sleep "$ROOTDELAY"


In /usr/sbin/update-initramfs line 176:
		run-parts --arg=${version} --arg=${initramfs} \
                                ^--------^ SC2086: Double quote to
prevent globbing and word splitting.

Did you mean:
		run-parts --arg="${version}" --arg=${initramfs} \


In /usr/share/initramfs-tools/scripts/functions line 393:
		logsave -a -s $FSCK_LOGFILE fsck $spinner $force $fix -V -t "$TYPE" "$DEV"
                                                          ^----^ SC2086:
Double quote to prevent globbing and word splitting.

Did you mean:
		logsave -a -s $FSCK_LOGFILE fsck $spinner "$force" $fix -V -t "$TYPE"
"$DEV"


In /usr/share/initramfs-tools/scripts/functions line 398:
		logsave -a -s $FSCK_LOGFILE fsck $spinner $force $fix -T -t "$TYPE" "$DEV"
                                                          ^----^ SC2086:
Double quote to prevent globbing and word splitting.

Did you mean:
		logsave -a -s $FSCK_LOGFILE fsck $spinner "$force" $fix -T -t "$TYPE"
"$DEV"

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent
globbing ...
autopkgtest [21:50:38]: test shellcheck: -----------------------]

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
--- Begin Message --- 
Source: initramfs-tools
Source-Version: 0.137
Done: Ben Hutchings <benh@debian.org>

We believe that the bug you reported is fixed in the latest version of
initramfs-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 958851@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ben Hutchings <benh@debian.org> (supplier of updated initramfs-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 28 Apr 2020 04:56:17 +0100
Source: initramfs-tools
Architecture: source
Version: 0.137
Distribution: unstable
Urgency: medium
Maintainer: Debian kernel team <debian-kernel@lists.debian.org>
Changed-By: Ben Hutchings <benh@debian.org>
Closes: 950254 955347 956663 958851
Changes:
 initramfs-tools (0.137) unstable; urgency=medium
 .
   [ Ben Hutchings ]
   * [1b28d25] Document copy_exec as usable for shared libraries
   * [f2ac13e] hook-functions: copy_exec: Copy libgcc_s.so.1 along with
     libpthread.so.* (Closes: #950254)
   * [d96228a] hook-functions: copy_exec: Correct verbose log message for
     symlinks
   * [dd5fb36] hook-functions: Factor out device class walking into a function
   * [14a00af] hook-functions: Don't add backlight modules if we have generic
     fb device (Closes: #955347)
   * [f6133e1] Fix new shellcheck warnings around unquoted parameter expansion
     (Closes: #958851)
 .
   [ AP ]
   * [857042c] hook-functions: Search for firmware under /lib/firmware/updates
     (Closes: #956663)
Checksums-Sha1:
 acd33330a982a67cad4d40efb9385b6fb45f0695 1839 initramfs-tools_0.137.dsc
 48528fad1c4f943fec68f69977e2c551c354b0bb 92108 initramfs-tools_0.137.tar.xz
 545ef2ee4e4072f9c1f614b12c6bcf202b5bc9d7 6668 initramfs-tools_0.137_source.buildinfo
Checksums-Sha256:
 1c4d31bc83df9cb1ae90547778ed3cccb06f6b13866fd9fdc87e9b157c22bf2a 1839 initramfs-tools_0.137.dsc
 ec1faba93b08e20d1e0ea82d3041196b1e9228d06e908fd046281b2088af1604 92108 initramfs-tools_0.137.tar.xz
 3e62191f13ce44a421acae60d3242a024f666367afd6b42b7d3281cedaf55319 6668 initramfs-tools_0.137_source.buildinfo
Files:
 ffbaf7605598974cfed141c376559613 1839 utils optional initramfs-tools_0.137.dsc
 8efb9dcf33783021ca123289cff36eef 92108 utils optional initramfs-tools_0.137.tar.xz
 05ff70cdfd8edf22987f7122d34b6d55 6668 utils optional initramfs-tools_0.137_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAl6oZzkACgkQ57/I7JWG
EQnpUA/9GbEa2CUu6YPfbRUX0zNMGXJO9Nq3aSIWkxYt6dz60jSPMlrjD/Gjm8Vs
I8eqaDTSJgMWX34nrrkETZSER3mkWrYtEISYZu88cthd5sxbSy/J6qTfy0ub8rqe
BuRnU8bOwBuKrruLi2afYr/4HYNB13hoLPLYDeP8/qje86Pz48rFONkLQvfnRCnf
UtSyWVih/XX+iK9USFvPfCPq/T0QQo1updY2/TUpSYP52UsEF65E2G6UGegPFjpm
4wAlxx6WWSIw5ULTpAjjx9ic/ECBHMdGyewuZblLt2RZevkQyvMeQ363Ti+bNsVD
geqBu0YJP5+7CeDzmeE2JRUHsgUZKhlQG4oEHSZHoidboezxgD44LsIuAOVWUM1W
peukFcaqzzBmncqDBToflcVN5Kdms9Yqtq472uh2tbuAInKHVsP8faOtSXaeA/JI
oug/ppnn2DMfqXPQ3DgP2vselPnYcThnzivGTYWAcqXAa3tS4UD91D3vP+LbYa1w
Xveq2PC78qYbroOOz0kEh/lxDypz69/zrrWwUAEYGwZYOGzC8F1P3dFGedTzrL/4
OAksu5Ns1xlqJ9KS+TjXWnrSnHOLauTnPuDV4QZbRGoRkNLyY3U0RTJZTdwYVgk1
QWL1aO05Ba0TNRKn42ZwwmeLs6Q0hAQTd7fx0ticaJRTkD42gU0=
=flr9
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: