Re: libbpf distro packaging
- To: Julia Kartseva <hex@fb.com>
- Cc: Alexei Starovoitov <ast@fb.com>, Andrii Nakryiko <andrii.nakryiko@gmail.com>, "labbott@redhat.com" <labbott@redhat.com>, "acme@kernel.org" <acme@kernel.org>, "debian-kernel@lists.debian.org" <debian-kernel@lists.debian.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, Andrey Ignatov <rdna@fb.com>, Yonghong Song <yhs@fb.com>, "jolsa@kernel.org" <jolsa@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, "md@linux.it" <md@linux.it>, Cestmir Kalina <ckalina@redhat.com>
- Subject: Re: libbpf distro packaging
- From: Jiri Olsa <jolsa@redhat.com>
- Date: Tue, 10 Mar 2020 18:49:38 +0100
- Message-id: <[🔎] 20200310174938.GC167617@krava>
- In-reply-to: <8552eef5-5bb8-5298-d0ab-f3c05c73c448@fb.com>
- References: <040A8497-C388-4B65-9562-6DB95D72BE0F@fb.com> <20191008073958.GA10009@krava> <AAB8D5C3-807A-4EE3-B57C-C7D53F7E057D@fb.com> <20191016100145.GA15580@krava> <824912a1-048e-9e95-f6be-fd2b481a8cfc@fb.com> <20191220135811.GF17348@krava> <c1b6a5b1-bbc8-2186-edcf-4c4780c6f836@fb.com> <[🔎] 20200305141812.GH168640@krava> <[🔎] 20200310145717.GB167617@krava> <8552eef5-5bb8-5298-d0ab-f3c05c73c448@fb.com>
On Tue, Mar 10, 2020 at 10:18:12AM -0700, Julia Kartseva wrote:
>
>
> On 3/10/20 7:57 AM, Jiri Olsa wrote:
> > On Thu, Mar 05, 2020 at 03:18:12PM +0100, Jiri Olsa wrote:
> >
> > so I did some more checking and libbpf is automatically pulled into
> > centos 8, it's just at the moment there's some bug preventing that..
> > it is going to be fixed shortly ;-)
> >
> > as for centos 7, what is the target user there? which version of libbpf
> > would you need in there?
> >
> > jirka
> >
> Hi, that's great news!
> Nothing prevents us from having the latest v0.0.7 [1] in CentOS 7 :)
that's just half true.. while libbpf is ok, libbpf-devel needs uapi
headers to define all the stuff that's used in libbpf's headers
Example:
$ echo "#include <bpf/xsk.h>" | gcc -x c -
In file included from <stdin>:1:
/usr/include/bpf/xsk.h: In function ‘xsk_ring_prod__needs_wakeup’:
/usr/include/bpf/xsk.h:82:21: error: ‘XDP_RING_NEED_WAKEUP’ undeclared (first use in this function)
82 | return *r->flags & XDP_RING_NEED_WAKEUP;
| ^~~~~~~~~~~~~~~~~~~~
/usr/include/bpf/xsk.h:82:21: note: each undeclared identifier is reported only once for each function it appears in
/usr/include/bpf/xsk.h: In function ‘xsk_umem__extract_addr’:
/usr/include/bpf/xsk.h:173:16: error: ‘XSK_UNALIGNED_BUF_ADDR_MASK’ undeclared (first use in this function)
173 | return addr & XSK_UNALIGNED_BUF_ADDR_MASK;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/bpf/xsk.h: In function ‘xsk_umem__extract_offset’:
/usr/include/bpf/xsk.h:178:17: error: ‘XSK_UNALIGNED_BUF_OFFSET_SHIFT’ undeclared (first use in this function)
178 | return addr >> XSK_UNALIGNED_BUF_OFFSET_SHIFT;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I'll need to check the state of rhel7 kernel headers, but that was
very early backport and I think headers are far behind
jirka
> Can updates for CentOS 7 and 8 be synced so the have the same libbpf version?
>
> [1] https://github.com/libbpf/libbpf/releases/tag/v0.0.7
>
Reply to: