Re: [PATCH v2] deb-pkg: generate correct build dependencies
Hi Riku,
On Wed, Jan 2, 2019 at 6:28 PM <riku.voipio@linaro.org> wrote:
>
> From: Riku Voipio <riku.voipio@linaro.org>
>
> bison/flex is now needed always for building for kconfig. Some build
> dependencies depend on kernel configuration, enable them as needed:
>
> - libelf-dev when UNWINDER_ORC is set
> - libssl-dev for SYSTEM_TRUSTED_KEYRING
>
> Since the libssl-dev is needed for extract_cert binary, denote with
> :native to install the libssl-dev for the build machines architecture,
> rather than for the architecture of the kernel being built.
>
> Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> ---
> v2: commit message updated
> ---
$ make defconfig && make bindeb-pkg
worked for me, but
$ make allnoconfig && make bindeb-pkg
failed with
dpkg-checkbuilddeps: error: Unmet build dependencies: flex
I do not know why.
The relevant line in debian/control looks as follows,
but I am not sure if trailing commas are causing the problem.
Build-Depends: bc, kmod, cpio, bison, flex , ,
> scripts/package/mkdebian | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian
> index edcad61fe3cd..c858abf4569e 100755
> --- a/scripts/package/mkdebian
> +++ b/scripts/package/mkdebian
> @@ -134,6 +134,8 @@ fi
>
> mkdir -p debian/
> echo $debarch > debian/arch
> +extra_build_depends=", $(if_enabled_echo UNWINDER_ORC libelf-dev)"
> +extra_build_depends="$extra_build_depends, $(if_enabled_echo SYSTEM_TRUSTED_KEYRING libssl-dev:native)"
>
> # Generate a simple changelog template
> cat <<EOF > debian/changelog
> @@ -170,7 +172,7 @@ Source: $sourcename
> Section: kernel
> Priority: optional
> Maintainer: $maintainer
> -Build-Depends: bc, kmod, cpio
> +Build-Depends: bc, kmod, cpio, bison, flex $extra_build_depends
> Homepage: http://www.kernel.org/
>
> Package: $packagename
> --
> 2.19.2
>
--
Best Regards
Masahiro Yamada
Reply to: