Re: libbpf-devel rpm uapi headers
- To: Jiri Olsa <jolsa@redhat.com>
- Cc: Julia Kartseva <hex@fb.com>, Yonghong Song <yhs@fb.com>, "debian-kernel@lists.debian.org" <debian-kernel@lists.debian.org>, "md@linux.it" <md@linux.it>, Alexei Starovoitov <ast@fb.com>, Andrii Nakryiko <andrii.nakryiko@gmail.com>, "labbott@redhat.com" <labbott@redhat.com>, "acme@kernel.org" <acme@kernel.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, Andrey Ignatov <rdna@fb.com>, "jolsa@kernel.org" <jolsa@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, Jesper Dangaard Brouer <brouer@redhat.com>, Toke Høiland-Jørgensen <toke@redhat.com>, iovisor-dev@lists.iovisor.org
- Subject: Re: libbpf-devel rpm uapi headers
- From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
- Date: Wed, 2 Oct 2019 11:43:17 -0700
- Message-id: <[🔎] 20191002184315.zl5xpfhsaspllaix@ast-mbp.dhcp.thefacebook.com>
- In-reply-to: <[🔎] 20191002174331.GA13941@krava>
- References: <[🔎] 20191002174331.GA13941@krava>
On Wed, Oct 02, 2019 at 07:43:31PM +0200, Jiri Olsa wrote:
> hi,
> we'd like to have bcc linked with libbpf instead of the
> github submodule, initial change is discussed in here:
> https://github.com/iovisor/bcc/pull/2535
>
> In order to do that, we need to have access to uapi headers
> compatible with libbpf rpm, bcc is attaching and using them
> during compilation.
>
> I added them in the fedora spec below (not submitted yet),
> so libbpf would carry those headers.
>
> Thoughts? thanks,
I think it may break a bunch of people who rely on bcc being a single library.
What is the main motiviation to use libbpf as a shared library in libbcc?
I think we can have both options. libbpf as git submodule and as shared.
In practice git submodule is so much simpler to use and a lot less headaches.
Reply to: