Bug#823485: kernel: brcmsmac bcma0:1: START: tid 1 is not agg'able

[Darsey Litzenberger <dlitz@dlitz.net>]

I'm seeing the same thing on a MacBookAir5,2 device with this hardware:

02:00.0 Network controller [0280]: Broadcom Limited BCM43224 802.11a/b/g/n [14e4:4353] (rev 01)
       Subsystem: Apple Inc. AirPort Extreme [106b:00e9]
       Flags: bus master, fast devsel, latency 0, IRQ 17
       Memory at a0400000 (64-bit, non-prefetchable) [size=16K]
       Capabilities: [40] Power Management version 3
       Capabilities: [58] Vendor Specific Information: Len=78 <?>
       Capabilities: [48] MSI: Enable- Count=1/1 Maskable- 64bit+
       Capabilities: [d0] Express Endpoint, MSI 00
       Capabilities: [100] Advanced Error Reporting
       Capabilities: [13c] Virtual Channel
       Capabilities: [160] Device Serial Number 7a-79-c3-ff-ff-da-7c-d1
       Capabilities: [16c] Power Budgeting <?>
       Kernel driver in use: bcma-pci-bridge
       Kernel modules: bcma

The device seems to work fine (I'm filling out this bug report over ssh) 
but this spams the kernel log multiple times per second.  This patch 
from wireless-drivers-next looks like it could help:

https://patchwork.kernel.org/patch/10653373/
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=96fca788e5788b7ea3b0050eb35a343637e0a465

commit 96fca788e5788b7ea3b0050eb35a343637e0a465
Author: Ali MJ Al-Nasrawy <alimjalnasrawy@gmail.com>
Date:   Tue Oct 23 19:12:35 2018 +0300

   brcmsmac: never log "tid x is not agg'able" by default

   This message greatly spams the log under heavy Tx of frames with BK access
   class which is especially true when operating as AP. It is also not informative
   as the "agg'ablity" of TIDs are set once and never change.
   Fix this by logging only in debug mode.

   Signed-off-by: Ali MJ Al-Nasrawy <alimjalnasrawy@gmail.com>
   Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c
index 81ff558046a8..6188275b17e5 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c
@@ -846,8 +846,8 @@ brcms_ops_ampdu_action(struct ieee80211_hw *hw,
               status = brcms_c_aggregatable(wl->wlc, tid);
               spin_unlock_bh(&wl->lock);
               if (!status) {
-                       brcms_err(wl->wlc->hw->d11core,
-                                 "START: tid %d is not agg\'able\n", tid);
+                       brcms_dbg_ht(wl->wlc->hw->d11core,
+                                    "START: tid %d is not agg\'able\n", tid);
                       return -EINVAL;
               }
               ieee80211_start_tx_ba_cb_irqsafe(vif, sta->addr, tid);