[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#764574: marked as done (please backport commit a28a9178e8 from v3.8)

Your message dated Sun, 01 Jul 2018 01:33:56 +0100
with message-id <c3343cde986b2550f77fc704babd31666621f92a.camel@decadent.org.uk>
and subject line Re: please backport commit a28a9178e8 from v3.8
has caused the Debian Bug report #764574,
regarding please backport commit a28a9178e8 from v3.8
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
764574: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=764574
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: src:linux
Version: 3.2.63-2
Severity: wishlist

I'm using Apache TrafficServer on wheezy, and I get the following in
dmesg once per day:

[28050.283707] EXT4-fs (dm-0): Unaligned AIO/DIO on inode 7734855 by [ET_NET 4]; performance will be poor.
[50104.515999] EXT4-fs (dm-0): Unaligned AIO/DIO on inode 7734855 by [ET_NET 5]; performance will be poor.
[79848.128273] EXT4-fs (dm-0): Unaligned AIO/DIO on inode 7734855 by [ET_NET 0]; performance will be poor.

This warning isn't very useful, and it looks like it was removed from
the kernel in v3.8 by commit a28a9178e8, it would be great if you could
apply a similar change to the Debian sources (the upstream patch doesn't
cherry-pick cleanly on top of v3.2.63).

commit a28a9178e8fcd9b94f7333184ce78e816c8cb2af
Author: Eric Sandeen <sandeen@redhat.com>
Date:   Tue Dec 25 13:33:13 2012 -0500

    ext4: remove unaligned AIO warning printk
    
    Although I put this in, I now think it was a bad decision.  For most
    users, there is very little to be done in this case.  They get the
    message, once per day, with no real context or proposed action.  TBH,
    it generates support calls when it probably does not need to; the
    message sounds more dire than the situation really is.
    
    Just nuke it.  Normal investigation via blktrace or whatnot can
    reveal poor IO patterns if bad performance is encountered.
    
    Signed-off-by: Eric Sandeen <sandeen@redhat.com>
    Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>

diff --git a/fs/ext4/file.c b/fs/ext4/file.c
index b64a60b..1c0aad7 100644
--- a/fs/ext4/file.c
+++ b/fs/ext4/file.c
@@ -108,14 +108,6 @@ ext4_file_dio_write(struct kiocb *iocb, const struct iovec *iov,
 
 	/* Unaligned direct AIO must be serialized; see comment above */
 	if (unaligned_aio) {
-		static unsigned long unaligned_warn_time;
-
-		/* Warn about this once per day */
-		if (printk_timed_ratelimit(&unaligned_warn_time, 60*60*24*HZ))
-			ext4_msg(inode->i_sb, KERN_WARNING,
-				 "Unaligned AIO/DIO on inode %ld by %s; "
-				 "performance will be poor.",
-				 inode->i_ino, current->comm);
 		mutex_lock(ext4_aio_mutex(inode));
 		ext4_unwritten_wait(inode);
 	}

Thanks,
-- 
Romain Francoise <rfrancoise@debian.org>
http://people.debian.org/~rfrancoise/

--- End Message ---
--- Begin Message --- 
Closing since support for Debian 7 "wheezy" has ended.

Ben.
 
-- 
Ben Hutchings
Q.  Which is the greater problem in the world today,
    ignorance or apathy?
A.  I don't know and I couldn't care less.

Attachment: signature.asc
Description: This is a digitally signed message part


--- End Message ---
Reply to: