Bug#898087: linux debian.py change breaks "+" in changelog revision_other

[Ben Caradoc-Davies <ben@transient.nz>]

Package: linux-image-amd64
Version: 4.16+93
Severity: normal

Dear Maintainer,

until recent changes in debian/lib/python/debian_linux/debian.py,
changelog versions like 4.16.5-1+revert+crng+ready for local test
builds were accepted with "+" part as the revision_other Python
symbolic group name.

After this change:
https://salsa.debian.org/kernel-
team/linux/commit/f4dbf1aa828f18a7e3d9fd7158166b8cedbac0ce

I get:

$ fakeroot debian/rules clean
md5sum --check debian/control.md5sum --status || \
        /usr/bin/make -f debian/rules debian/control-real
make[1]: Entering directory '/home/ben/tmp/debian/linux-4.16.5'
PYTHONHASHSEED=0 debian/bin/gencontrol.py
Traceback (most recent call last):
  File "debian/bin/gencontrol.py", line 601, in <module>
    Gencontrol()()
  File "debian/bin/gencontrol.py", line 57, in __init__
    VersionLinux)
  File "debian/lib/python/debian_linux/gencontrol.py", line 83, in __init__
    self.changelog = Changelog(version=version)
  File "debian/lib/python/debian_linux/debian.py", line 60, in __init__
    self._parse(version, f)
  File "debian/lib/python/debian_linux/debian.py", line 76, in _parse
    v = version(top_match.group('version'))
  File "debian/lib/python/debian_linux/debian.py", line 196, in __init__
    raise RuntimeError(u"Invalid debian linux version")
RuntimeError: Invalid debian linux version
make[1]: *** [debian/rules:104: debian/control-real] Error 1
make[1]: Leaving directory '/home/ben/tmp/debian/linux-4.16.5'
make: *** [debian/rules:95: debian/control] Error 2

Please either fix this change to support names like 4.16.5-1+revert+crng+ready
or recommend a naming convention for custom test builds.

Kind regards,
Ben.



-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.16.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8), LANGUAGE=en_GB:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages linux-image-amd64 depends on:
ii  linux-image-4.16.0-1-amd64  4.16.5-1

linux-image-amd64 recommends no packages.

linux-image-amd64 suggests no packages.

-- no debconf information