[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#870185: armel/marvell kernel size



On Tue, 2017-08-22 at 01:22 +0900, Roger Shimizu wrote:
> Control: tag -1 +pending
> 
> On Mon, Aug 21, 2017 at 9:28 AM, Roger Shimizu <rogershimizu@gmail.com> wrote:
> > On Mon, Aug 21, 2017 at 12:43 AM, Ben Hutchings <ben@decadent.org.uk> wrote:
> > > 
> > > OK, then try using 4.11.6 source and bisecting the Debian config
> > > changes.
> > 
> > Result:
> > 0905519af414d339f615d7aac974f9a9163cdbd3 is the first bad commit
> 
> So I confirmed the only problem is CONFIG_STRICT_KERNEL_RWX
> Added a commit to disable STRICT_KERNEL_RWX for armel.
> After cherry-pick this commit to 4.11.6-1 and 4.12.6-1, I confirmed
> the kernel boot again on my linkstation device.

Oh I see, that adds section (1 MiB) alignment in several places. 
Surprisingly, the padding isn't completely zero-filled, so it inflates
the compressed image size too.

> Added another commit on branch rosh/check-size2, that check the
> decompressed image size.
> I confirmed it works. Please kindly review. Thank you!

Please choose a more meaningful name than 'image2' e.g. 'uncompressed-
image'.

For the size check, you're mostly duplicating the existing check_size()
function.  It would be preferable to have a single function with some
extra parameters so that it can do both compressed and uncompressed
size checks.

Ben.

-- 
Ben Hutchings
Make three consecutive correct guesses and you will be considered an
expert.

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: