[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#847681: 847681



On Tue, 13 Dec 2016 22:09:07 +0100 Andreas Henriksson <andreas@fatal.se> wrote:
> On Tue, Dec 13, 2016 at 09:52:10PM +0100, Daniel Pocock wrote:


>> Even if you are not sure, simply spending 10 - 15 minutes hunting for
>> an example in another project and adding the links to the bug report
>> can give another developer a head-start when they are ready to work on
>> the bug. We are a community project and every contribution, no matter
>> how small, can be helpful.
>
> I would suggest tagging these both as wontfix. Adding even more options
> to the broken concept of /etc/default just adds to the maintenance burden
> of having to carry this over via the nfs-utils_env.sh bridge.

"/etc/default/" isn't broken. It is/was broken
_in_Debian_for_certain_packages_ because a service can/could be
disabled with a variable there.

It's a legitimate and useful way to customize daemon startup.


> Both /etc/default/nfs-kernel-server and the init script are conffiles.
> Edit them directly as you see fit to suite your installation if you're
> still using this old stuff. They will not be overwritten on upgrades.
>
> On systemd there's a better concept of overriding settings so you don't
> need to (and should avoid to) deal with /etc/default anymore.

NFS has so many settings and so many sysvrc/systemd startup files that
editing them or creating overrides/drop-ins is a PitA. Especially
since an admin can check with

root@localhost ~ # egrep -v '^#|^$|NEED' /etc/default/nfs-*
/etc/default/nfs-common:STATDOPTS="--port 32765 --outgoing-port 32766"
/etc/default/nfs-kernel-server:RPCNFSDCOUNT="8 --no-nfs-version 2
--no-nfs-version 3"
/etc/default/nfs-kernel-server:RPCNFSDPRIORITY=0
/etc/default/nfs-kernel-server:RPCMOUNTDOPTS="--manage-gids
--no-nfs-version 2 --no-nfs-version 3 --port 32767"
/etc/default/nfs-kernel-server:RPCSVCGSSDOPTS="-v -k /root/test.keytab
-p /run/rpc_pipefs"
root@localhost ~ #

what's being passed to the nfs units.

The url below is the nfs upstream systemd units

http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=tree;f=systemd;hb=HEAD

where steved is Steve Dickson, an RH developer who's a systemd happy
camper. If upstream and RHEL are happy to use "/etc/sysconfig/" (the
RH "/etc/default/"), I don't see why Debian should be "plus royaliste
que le roi" and get rid of "/etc/default/" for nfs.

Ubuntu's packaged the upstream units and adapted them to the
Ubuntu/Debian setup so whoever's packaging nfs for Debian might only
need to copy the relevant "./debian/" files to the Debian source
package.


Reply to: