Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm
- To: Adam Borowski <kilobyte@angband.pl>
- Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>, Michal Marek <mmarek@suse.com>, Ben Hutchings <ben@decadent.org.uk>, Debian kernel maintainers <debian-kernel@lists.debian.org>, "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>, Arnd Bergmann <arnd@arndb.de>, Ingo Molnar <mingo@kernel.org>, Nicholas Piggin <npiggin@gmail.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
- Subject: Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm
- From: Linus Torvalds <torvalds@linux-foundation.org>
- Date: Tue, 29 Nov 2016 07:27:12 -0800
- Message-id: <[🔎] CA+55aFyZiB4YkwvqzrXO=HD8bcnc2xHkAYrek2QHVnhVvAi3Fw@mail.gmail.com>
- In-reply-to: <[🔎] 20161129135118.24696-1-kilobyte@angband.pl>
- References: <[🔎] 20161129131922.GA31466@angband.pl> <[🔎] 20161129135118.24696-1-kilobyte@angband.pl>
On Nov 29, 2016 5:51 AM, "Adam Borowski" <kilobyte@angband.pl> wrote:
>
> >
> > (a) tested
>
> By many people.
No.
I've tested the build *without* this, and it works fine.
> > (b) explains it
>
> The actual logic is in 4efca4ed0. It wants C prototypes defined in
> asm/asm-prototypes.h that lists symbols defined in assembly -- genksyms
> knows only how to read C code.
See above. I'm not taking more random patches that "fix" this when it's not broken for me. Not without very explicit explanations of why that patch is still needed for others.
I suspect one of the other patches already fixed is for x86.
Linus
Reply to: