[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#825840: localechooser: image display inverts red and blue color



Mathieu Malaterre, on Tue 06 Sep 2016 08:03:53 +0200, wrote:
> On Tue, Sep 6, 2016 at 2:32 AM, Samuel Thibault <sthibault@debian.org> wrote:
> > I really don't think it's a bterm bug, its only change of behavior is
> > when type or visual changes, which is not the case. It however does
> > use FBIOPUTCMAP, whose implementation does seem suspicious in offb for
> > RockHo.
> 
> I did initially look into that direction (see the early bug report).
> However when I realized that other TERM did not have the color
> inversion I suspected that bterm was assuming BGR instead of RGB.

What happens is that other terms do not use FBIOPUTCMAP.

There is no risk that bogl gets RGB wrong in there, it just fills a
struct fb_cmap, which has explicit "red", "green", and "blue" field
names :)

> I will try your suggested patch, but I fear it will break every single
> other TERM out there (at least in assumption of color organisation).

They don't use it, so they don't risk breaking.

Samuel


Reply to: