[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#804990: nfs-common: Please drop versioned dependency on initscripts package



Control: tag -1 patch

biebl@debian.org [2015-11-13  8:48 +0100]:
> your package nfs-common declares a versioned dependency on the
> initscripts package. Most likely, it was added for the
> /run-transition in wheezy.

git archeology shows that this was introduced in 2007 for ensuring a
recent enough /etc/init.d/mountnfs:

  http://anonscm.debian.org/cgit/kernel/nfs-utils.git/commit/?id=b81d81eb57

and bumped in 2011 for the /run transition:

  http://anonscm.debian.org/cgit/kernel/nfs-utils.git/commit/?id=9ac1a6fef

Both reasons are long-obsolete now, so this can indeed be dropped.
nfs-common uses sendsigs.omit, but sysvinit-core depends on
initscripts (so it's available there) and sendsigs.service is masked
under systemd so it won't do anything there anyway.

Attaching corresponding patch against current packaging git.

Thanks,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
From b056c044de251a7e72d2be5eb233a7ecbbc3e8cb Mon Sep 17 00:00:00 2001
From: Martin Pitt <martin.pitt@ubuntu.com>
Date: Wed, 22 Jun 2016 16:04:54 +0200
Subject: [PATCH] Drop obsolete versioned initscripts dependency

It was introduced in 2007 for ensuring a recent enough /etc/init.d/mountnfs
(commit b81d81eb57) and bumped in 2011 for the /run transition (commit
9ac1a6fef).

Closes: #804990
---
 debian/changelog | 4 ++++
 debian/control   | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index 618d70d..42e73ec 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,7 +1,11 @@
 nfs-utils (1:1.2.8-10) UNRELEASED; urgency=medium
 
+  [ Ben Hutchings ]
   * Update debian/watch
 
+  [ Martin Pitt ]
+  * Drop obsolete versioned initscripts dependency. (Closes: #804990)
+
  -- Ben Hutchings <ben@decadent.org.uk>  Mon, 23 Mar 2015 16:33:59 +0000
 
 nfs-utils (1:1.2.8-9) unstable; urgency=medium
diff --git a/debian/control b/debian/control
index 51b1a11..24ec0cc 100644
--- a/debian/control
+++ b/debian/control
@@ -32,7 +32,7 @@ Homepage: http://nfs.sourceforge.net/
 
 Package: nfs-common
 Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, rpcbind, adduser, ucf, lsb-base (>= 1.3-9ubuntu3), initscripts (>= 2.88dsf-13.3), libtirpc1 (>= 0.2.4)
+Depends: ${shlibs:Depends}, ${misc:Depends}, rpcbind, adduser, ucf, lsb-base (>= 1.3-9ubuntu3), libtirpc1 (>= 0.2.4)
 Recommends: python
 Suggests: open-iscsi, watchdog
 Provides: nfs-client
-- 
2.8.1

Attachment: signature.asc
Description: PGP signature


Reply to: