[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#767471: marked as done ([initramfs-tools] / formatted as ext3 but mounted as ext4 not fsck-able)



Your message dated Thu, 11 Feb 2016 04:30:08 +0000
with message-id <E1aTitM-0005i2-8Z@franck.debian.org>
and subject line Bug#767471: fixed in initramfs-tools 0.123
has caused the Debian Bug report #767471,
regarding [initramfs-tools] / formatted as ext3 but mounted as ext4 not fsck-able
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
767471: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=767471
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: initramfs-tools
Version: 0.118
Severity: normal

--- Please enter the report below this line. ---

I have a ext3 formatted / which in /etc/fstab is mounted with ext4. This does not cope well with the logic in hooks/fsck which assumes that fsck.$fs will work with a filesystem entry $fs in /etc/fstab. So at boot the initramfs warns that fsck.ext3 is missing and cannot do the check on /. This may not be a common case but still a fsck error or warning at boot for / it's annoying.
I've attached an untested patch with a tentative fix.


--- System information. ---
Architecture: i386
Kernel:       Linux 3.16.6

Debian Release: jessie/sid
  500 unstable        ftp.de.debian.org
    1 experimental    ftp.de.debian.org

--- Package information. ---
Depends                 (Version) | Installed
=================================-+-============
klibc-utils           (>= 2.0-1~) | 2.0.4-2
cpio                              | 2.11+dfsg-2
kmod                              | 18-3
 OR module-init-tools             | 18-3
udev                              | 215-5+b1


Recommends                 (Version) | Installed
====================================-+-===============
busybox               (>= 1:1.01-3)  | 1:1.22.0-9
 OR busybox-initramfs                |
 OR busybox-static                   |


Suggests             (Version) | Installed
==============================-+-===========
bash-completion                |



--- Output from package bug script ---
-- initramfs sizes
-rw-r--r-- 1 root root 4,9M ago 13 12:02 /boot/initrd.img-3.14.16
-rw-r--r-- 1 root root 4,9M ott  6 12:07 /boot/initrd.img-3.16.4
-rw-r--r-- 1 root root 5,4M ott 27 11:39 /boot/initrd.img-3.16.5
-rw-r--r-- 1 root root 4,7M ott 28 11:31 /boot/initrd.img-3.16.6
-- /proc/cmdline
BOOT_IMAGE=/boot/vmlinuz-3.16.6 root=UUID=770e4e60-f57b-4299-a18d-ed558a68d750 ro quiet acpi_backlight=vendor

-- resume
RESUME=/dev/sda3
-- /proc/filesystems
	ext3
	ext2
	ext4
	fuseblk

-- lsmod
Module                  Size  Used by
dm_mod                 79494  0
iptable_filter          1762  0
ip_tables              15195  1 iptable_filter
x_tables               21829  2 ip_tables,iptable_filter
ctr                     3857  1
ccm                     7451  1
cpufreq_stats           3136  0
bnep                   10410  2
bluetooth             241284  5 bnep
uinput                  7665  1
ipv6                  316592  26
cuse                    6277  0
fuse                   75002  2 cuse
joydev                  8792  0
loop                   17367  0
uvcvideo               64359  0
videobuf2_vmalloc       2968  1 uvcvideo
videobuf2_memops        2410  1 videobuf2_vmalloc
videobuf2_core         25764  1 uvcvideo
v4l2_common             6110  1 videobuf2_core
videodev              129098  3 uvcvideo,v4l2_common,videobuf2_core
i915                  797927  3
fbcon                  34821  71
bitblit                 4640  1 fbcon
iTCO_wdt                5736  0
softcursor              1349  1 bitblit
arc4                    2072  2
sdhci_pci              11598  0
iwldvm                110824  0
mac80211              450072  1 iwldvm
cfbfillrect             3317  1 i915
cfbimgblt               2296  1 i915
i2c_algo_bit            5374  1 i915
sdhci                  24389  1 sdhci_pci
snd_hda_codec_hdmi     34683  2
mmc_core               97042  1 sdhci
snd_hda_codec_realtek    58964  1
snd_hda_codec_generic    48330  1 snd_hda_codec_realtek
pcspkr                  2054  0
font                    8131  1 fbcon
tileblit                2239  1 fbcon
samsung_laptop          9075  0
coretemp                5905  0
cfbcopyarea             3017  1 i915
psmouse                59351  0
e1000e                147839  0
evdev                  10197  23
snd_hda_intel          20239  6
iwlwifi                88968  1 iwldvm
snd_hda_controller     20981  1 snd_hda_intel
snd_hda_codec 115704 5 snd_hda_codec_realtek,snd_hda_codec_hdmi,snd_hda_codec_generic,snd_hda_intel,snd_hda_controller
yenta_socket           20471  0
pcmcia_rsrc             1301  1 yenta_socket
cfg80211              464686  3 iwlwifi,mac80211,iwldvm
snd_hwdep               6187  1 snd_hda_codec
pcmcia_core            15627  1 yenta_socket
snd_pcm 86549 4 snd_hda_codec_hdmi,snd_hda_codec,snd_hda_intel,snd_hda_controller
serio_raw               4666  0
drm_kms_helper         41936  1 i915
lpc_ich                13821  0
drm                   276323  5 i915,drm_kms_helper
mfd_core                3603  1 lpc_ich
snd_timer              19153  1 snd_pcm
thermal                 9844  0
i2c_i801                9223  0
i2c_core 43251 7 drm,i915,i2c_i801,drm_kms_helper,i2c_algo_bit,v4l2_common,videodev
battery                10068  0
fan                     2914  0
acpi_cpufreq            7317  1
snd 66690 20 snd_hda_codec_realtek,snd_hwdep,snd_timer,snd_hda_codec_hdmi,snd_pcm,snd_hda_codec_generic,snd_hda_codec,snd_hda_intel
uhci_hcd               20007  0
ptp                    11299  1 e1000e
fb 53541 6 i915,fbcon,drm_kms_helper,softcursor,tileblit,bitblit
video                  14778  2 i915,samsung_laptop
processor              27061  3 acpi_cpufreq
soundcore               6676  2 snd,snd_hda_codec
ehci_pci                3650  0
ehci_hcd               37716  1 ehci_pci
backlight               8165  3 i915,video,samsung_laptop
fbdev                   1065  2 fb,fbcon
ac                      3973  0
button                  5583  1 i915
pps_core                7345  1 ptp
intel_agp              11368  0
thermal_sys            22339  4 fan,video,thermal,processor
intel_gtt              12812  3 i915,intel_agp

-- /etc/initramfs-tools/modules

-- /etc/kernel-img.conf
# Kernel image management overrides
# See kernel-img.conf(5) for details
do_symlinks = yes
relative_links = yes
do_bootloader = no
do_bootfloppy = no
do_initrd = yes
link_in_boot = no

-- /etc/initramfs-tools/initramfs.conf
MODULES=most
BUSYBOX=y
KEYMAP=n
COMPRESS=gzip
DEVICE=
NFSROOT=auto

-- /etc/initramfs-tools/update-initramfs.conf
update_initramfs=yes
backup_initramfs=no

-- mkinitramfs hooks
/etc/initramfs-tools/hooks/:

/usr/share/initramfs-tools/hooks:
btrfs
busybox
dmsetup
fsck
fuse
intel_microcode
keymap
klibc
kmod
lvm2
mountall
ntfs_3g
plymouth
resume
thermal
udev
uswsusp
zz-busybox

diff --git a/hooks/fsck b/hooks/fsck
index cc860b5..d8efa58 100755
--- a/hooks/fsck
+++ b/hooks/fsck
@@ -77,6 +77,20 @@ get_fstypes() {
 	get_fstype /usr
 }
 
+copy_fsck_prog() {
+	fstype=$1
+	prog="/sbin/fsck.${fstype}"
+	if [ -h "$prog" ]; then
+		link=$(readlink -f "$prog")
+		copy_exec "$link"
+		ln -s "$link" "${DESTDIR}/$prog"
+	elif [ -x "$prog" ] ; then
+		copy_exec "$prog"
+	else
+		echo "Warning: /sbin/fsck.${fstype} doesn't exist, can't install to initramfs, ignoring."
+	fi
+}
+
 case $1 in
 prereqs)
 	prereqs
@@ -114,14 +128,10 @@ for type in $(get_fstypes | sort | uniq); do
 		continue
 	fi
 
-	prog="/sbin/fsck.${type}"
-	if [ -h "$prog" ]; then
-		link=$(readlink -f "$prog")
-		copy_exec "$link"
-		ln -s "$link" "${DESTDIR}/$prog"
-	elif [ -x "$prog" ] ; then
-		copy_exec "$prog"
-	else
-		echo "Warning: /sbin/fsck.${type} doesn't exist, can't install to initramfs, ignoring."
+	copy_fsck_prog "$type"
+	# ext4 can mount ext3 filesystems but even when mount with ext4, the ext3 fsck would
+	# be called by e2fsck. So copy ext3 to be sure. Better safe than sorry
+	if [ "$type" = 'ext4' ] ; then
+		copy_fsck_prog 'ext3'
 	fi
 done

--- End Message ---
--- Begin Message ---
Source: initramfs-tools
Source-Version: 0.123

We believe that the bug you reported is fixed in the latest version of
initramfs-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 767471@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ben Hutchings <ben@decadent.org.uk> (supplier of updated initramfs-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 11 Feb 2016 02:13:23 +0000
Source: initramfs-tools
Binary: initramfs-tools initramfs-tools-core
Architecture: source
Version: 0.123
Distribution: unstable
Urgency: medium
Maintainer: Debian kernel team <debian-kernel@lists.debian.org>
Changed-By: Ben Hutchings <ben@decadent.org.uk>
Description:
 initramfs-tools - generic modular initramfs generator (automation)
 initramfs-tools-core - generic modular initramfs generator (core tools)
Closes: 512679 588770 639876 767471 768913 792910 804071 807527 809206 809740 810154 812404 813229 814345
Changes:
 initramfs-tools (0.123) unstable; urgency=medium
 .
   [ Ben Hutchings ]
   * [3084929] debian/control: Remove redundant dependency on
     klibc-utils|busybox
   * [913a861] debian/control: Recommend the right busybox packages for the
     target distribution
   * [d4febbd] Remove busybox hook in favour of busybox's own (Closes: #810154)
   * [b5303a1] Update TODO for removal of busybox hook
   * [6cc3d85] hook-functions: Include any modular RTC drivers in the initramfs
   * [ceff05e] hooks/fsck: Stop setting e2fsck broken_system_clock option
     (Closes: #804071)
   * [9c105f0] Assume blkid is always installed, and remove fallbacks
   * [aaba4cb] hooks/fsck: Use get_fstype rather than blkid to probe filesystem
     type
   * [a8ed874] hooks/fsck: Always use get_fstype to probe type of root
     filesystem (Closes: #767471)
   * [e798629] Pass filesystem type from /etc/fstab to fsck when checking /usr
   * [55e075c] hook-functions: Include drivers for all keyboards when
     MODULES=dep (Closes: #639876)
   * [704bfa5] scripts/functions: Explicitly load keyboard drivers only at
     break=top
   * [c5b54ae] scripts/functions: Use more sensible modprobe options at
     break=top
   * [39e90c8] scripts/functions: Load more USB host controllers drivers on
     break=top
   * [8c437f5] scripts/functions: Load HID drivers at break=top
   * [619f2ca] scripts/functions: Connect panic shell to normal tty device
     (Closes: #512679)
   * [8b8b28c] hook-functions: Clean up split between dep_add_modules and
     dep_add_modules_mount
   * [5f34b94] hook-functions: Include modules for resume partition when
     MODULES=dep (Closes: #588770)
   * [31ab487] hook-functions: Stop force-loading drivers found through sysfs
     when MODULES=dep (Closes: #792910)
   * [07f2c88] kernel/postinst.d: Make test for update-initramfs consistent with
     invocation (Closes: #768913)
   * [e5476bf] copy_file: Skip duplicating symlink if it points to the target
     file (Closes: #812404)
   * [d0f4d06] initramfs-tools: Include empty /etc/initramfs-tools/conf.d
     directory (Closes: #809206)
   * [245d584] initramfs-tools.8: Update list of variables exported to hook
     scripts
   * [941429d] initramfs-tools.8: Add a new section for the general description
     of scripts
   * [3ff5d57] initramfs-tools.8: Add brief description of configuration hooks
     and files (Closes: #807527)
   * [c17a21a] Remove klibc hook in favour of klibc's own
   * [ea7e02d] bash-completion: Simplify by using _get_comp_words_by_ref
   * [9e23444] init: Use "case" rather than loop to look for "quiet" parameter
   * [49e4a05] init: Remove fallback from devtmpfs to tmpfs
   * [ab91306] init: Take over handling of rootdelay parameter from udev boot
     script (Closes: #809740)
   * [56dfe39] bash-completion: Rename our completion script so that it works
     again
   * [ac6d31f] mkinitramfs: Delete or report temporary files on failure
     (Closes: #814345)
   * [c8c932d] Move initramfs.conf around in maintainer scripts to avoid it
     being 'obsolete' (Closes: #813229)
   * [138af73] hook-functions: Dereference links when looking up block device
     number
 .
   [ Andy Whitcroft ]
   * [7774fa3] Don't display "Loading, please wait..." message when 'quiet' is
     in /proc/cmdline.
   * [c4ea209] Mount /dev with the default tmpfs size rather than sourcing
     udev.conf.
   * [b418ad4] Sync the mount options for /run from /lib/init/fstab
     (LP: #1152744)
   * [c44df0c] init: Mount /dev with "nosuid". Thanks to Daniel (LP: #1450960)
Checksums-Sha1:
 04ba47b72545885859efbd5c82c4a16abe1d31b5 1811 initramfs-tools_0.123.dsc
 24be51cd493c96640e34d80ae164c0f855826eb7 84040 initramfs-tools_0.123.tar.xz
Checksums-Sha256:
 4472617459414c9402b654d4e2adb20c175c79f371adf6489c87af1a7e6e3606 1811 initramfs-tools_0.123.dsc
 84f57262b3208b14d36a7758b24380a4c27475e5e1ef69868aaba22f98ea5ac8 84040 initramfs-tools_0.123.tar.xz
Files:
 499f42df5ff1573b9abab071e728227f 1811 utils optional initramfs-tools_0.123.dsc
 e181fd51440cb4b767524bdc95b25745 84040 utils optional initramfs-tools_0.123.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIVAwUBVrvxnue/yOyVhhEJAQrgjBAAihP2c3a/kP8NeNKOG2Z4q09U0vZqNSRW
YR+I4EdAngQVfYgv96Cn8BH9c4pz7Cs3/LSKxoOzPMl055wuD2adLr5tugeFhqSv
+wqoV/IIX9xsqE41iWCHS2lmlY4QPUqwz9D5cTnQBeF8Gc6e0UM5q6Nt7m4NBKho
oYdiCSN8EG7ggWO5gpopOsLSl7J+Af8m/41uiuV6cQDwTU9sHUjQjFVGZ+1Z4h54
MPYyNnnDI9aFlK8/gs7iyyiJgxwangmmVaV8dbEwI6UGcAq6Xi6QeuNqRTeF7iGS
dhtfeYZ+KJv7RjTnKSFSXLx9EDXFlC32oW2t8B+yTfiEuX4+x4vyalEaUCAxMOEy
I9DkeH9VdBE/+vW08heYo9LznopqmWRj1uTyni2rQyAttsir9OToSQcRzrMMXEsR
mfpneVvIbF9VVaCnN1kgenaukfTg41iCX6r7rpPPJGPHCn2QddUI1YjCuMCp4p8B
GC5FPTdQCTbBQNVDF8jD0M94zUxzn/0LnUSke2feze4WZ7EKn43uEFgr0Vy6uoLz
L9cMd3aBcN4938s7BBvvjpPsDJqgXCoJwPIrefXDANKnKSPCIHoEkyNix80BhbK/
rF2yDTtjsVlTwrs1KiMWsv7NiQMQKy402T7ZsjozvQjW336OlBg8cHT3hML/YSE0
+bYohGrV3i4=
=6L3y
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: