[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#828826: nfs-common: move of rpc_pipefs mountpoint to /run breaks blkmapd



On Tue, Jul 12, 2016 at 11:16:42PM +0200, Michael Biebl wrote:
> Control: severity -1 serious
> 
> On Tue, 28 Jun 2016 09:21:44 +0200 Christoph Hellwig <hch@lst.de> wrote:
> > Package: nfs-common
> > Version: 1:1.2.8-9
> > Severity: important
> > Tags: patch
> > 
> > Dear Maintainer,
> > 
> > commit ba649fa4 ("Migrate the rpc_pipefs mount out of /var/lib to /run, to
> > better support /var on NFS.") in the Debian packaging repo completely
> > broke blkmapd, which still looks for rpc_pipefs in the old place.
> > >From looking in the BTS gssd also seems to have the same problem (#632141).
> > 
> > diff --git a/utils/blkmapd/device-discovery.c b/utils/blkmapd/device-discovery.c
> > index 69f00fa..7b00c90 100644
> > --- a/utils/blkmapd/device-discovery.c
> > +++ b/utils/blkmapd/device-discovery.c
> > @@ -55,9 +55,9 @@
> >  #define EVENT_SIZE (sizeof(struct inotify_event))
> >  #define EVENT_BUFSIZE (1024 * EVENT_SIZE)
> >  
> > -#define BL_PIPE_FILE	"/var/lib/nfs/rpc_pipefs/nfs/blocklayout"
> > -#define NFSPIPE_DIR	"/var/lib/nfs/rpc_pipefs/nfs"
> > -#define RPCPIPE_DIR	"/var/lib/nfs/rpc_pipefs"
> > +#define BL_PIPE_FILE	"/run/rpc_pipefs/nfs/blocklayout"
> > +#define NFSPIPE_DIR	"/run/rpc_pipefs/nfs"
> > +#define RPCPIPE_DIR	"/run/rpc_pipefs"
> >  #define PID_FILE	"/run/blkmapd.pid"
> >  
> 
> Looks to me like this should be RC, i.e. needs to be fixed for the next
> Debian release.
> Thus bumping the severity.

FYI I think there's a fix for this (or atleast something similar) in
the remaining ubuntu delta for this package. As already mentioned
would be useful to investigate the remaining delta and pull in
the useful parts. This is however not a new issue and should
already affect the version of the package in Debian Jessie/Stable.

Regards,
Andreas Henriksson


Reply to: