[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] [arm64] including missing headers



On Tue, 2016-04-19 at 00:13 -0300, Ricardo Salveti wrote:
> Including missing arm header references from the arm64 headers:
> asm/opcodes.h:#include <../../arm/include/asm/opcodes.h>
> asm/xen/hypervisor.h:#include <../../arm/include/asm/xen/hypervisor.h>
> asm/xen/page.h:#include <../../arm/include/asm/xen/page.h>
> asm/xen/page-coherent.h:#include <../../arm/include/asm/xen/page-coherent.h>
> asm/xen/hypercall.h:#include <../../arm/include/asm/xen/hypercall.h>
> asm/xen/interface.h:#include <../../arm/include/asm/xen/interface.h>

Yuck.  I don't really want to add a special case for this.

I wonder whether it would make more sense to make linux-headers-
<abiname>-common arch-independent, which I kind of wanted to do anyway.
That would expand the installed size by about 35-60% depending on which
architecture we compare with. What do you think?

Ben.

> Signed-off-by: Ricardo Salveti <ricardo.salveti@linaro.org>
> ---
>  debian/rules.real | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/debian/rules.real b/debian/rules.real
> index c9b44a2..e6d3ace 100644
> --- a/debian/rules.real
> +++ b/debian/rules.real
> @@ -269,6 +269,17 @@ install-headers_$(ARCH)_$(FEATURESET): $(STAMPS_DIR)/source_$(FEATURESET)
>  	) \
>  	| \
>  	cpio -pd --preserve-modification-time '$(CURDIR)/$(DIR)'
> +# arm64 headers references arch/arm
> +ifneq ($(filter arm64,$(ARCH)),)
> +	set -o pipefail; \
> +	cd $(SOURCE_DIR); \
> +	( \
> +	  find arch/arm/include -name 'opcodes.h' -print; \
> +	  find $$(find arch/arm/include -name xen -type d -print) -print; \
> +	) \
> +	| \
> +	cpio -pd --preserve-modification-time '$(CURDIR)/$(DIR)'
> +endif
>  
>  	dh_link /usr/lib/$(PACKAGE_NAME_KBUILD)/scripts $(BASE_DIR)/scripts
>  
-- 
Ben Hutchings
Usenet is essentially a HUGE group of people passing notes in class.
                      - Rachel Kadel, `A Quick Guide to Newsgroup Etiquette'

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: