Bug#815476: linux: [armhf] udeb: Add modules needed on Firefly-RK3288.

[Ben Hutchings <ben@decadent.org.uk>]

Control: tag -1 moreinfo

On Sun, 2016-02-21 at 12:24 -0800, Vagrant Cascadian wrote:
> Source: linux
> Version: 4.4.2-2
> Severity: normal
> Tags: patch
> 
> The following modules are needed in order to support ethernet, USB,
> and MMC on Firefly-RK3288 in debian-installer.
> 
> Please consider enabling them!
> 
> live well,
>   vagrant
> 
> 
> commit 60653f57a9eac67bfde342604fb0adf5b4e2d359
> Author: Vagrant Cascadian <vagrant@debian.org>
> Date:   Sun Feb 21 12:08:28 2016 -0800
> 
>     [armhf] udeb: Add modules needed on Firefly-RK3288.
>     - Add act8865-regulator to core-modules
>     - Add dw_mmc-rockchip to mmc-modules
>     - Add phy-rockchip-usb to usb-modules
> 
> diff --git a/debian/installer/armhf/modules/armhf-armmp/core-modules b/debian/installer/armhf/modules/armhf-armmp/core-modules
> index 7ea5f6d..3128393 100644
> --- a/debian/installer/armhf/modules/armhf-armmp/core-modules
> +++ b/debian/installer/armhf/modules/armhf-armmp/core-modules
> @@ -14,6 +14,7 @@ phy-omap-control ?
>  phy-ti-pipe3 ?
>  
>  # Regulators
> +act8865-regulator ?
>  anatop-regulator ?
>  axp20x-regulator ?
>  da9052-regulator ?
> diff --git a/debian/installer/armhf/modules/armhf-armmp/mmc-modules b/debian/installer/armhf/modules/armhf-armmp/mmc-modules
> index 287ff3f..6bdda66 100644
> --- a/debian/installer/armhf/modules/armhf-armmp/mmc-modules
> +++ b/debian/installer/armhf/modules/armhf-armmp/mmc-modules
> @@ -5,4 +5,5 @@ mmci
>  omap_hsmmc
>  sunxi-mmc
>  dw_mmc-exynos
> +dw_mmc-rockchip
>  sdhci-bcm2835

Would it make sense to replace this list with a wildcard in the default
mmc-modules file:

    drivers/mmc/host/**

> diff --git a/debian/installer/armhf/modules/armhf-armmp/usb-modules b/debian/installer/armhf/modules/armhf-armmp/usb-modules
> index 663e915..454e77d 100644
> --- a/debian/installer/armhf/modules/armhf-armmp/usb-modules
> +++ b/debian/installer/armhf/modules/armhf-armmp/usb-modules
> @@ -18,6 +18,7 @@ phy-exynos5-usbdrd ?
>  phy-generic ?
>  phy-mxs-usb
>  phy-omap-usb2
> +phy-rockchip-usb
>  phy-sun4i-usb
>  phy-sun9i-usb ?
>  phy-tegra-usb ?

Would it make sense to replace this list with wildcards in the default
usb-modules file:

    drivers/phy/phy-*-usb ?
    drivers/usb/phy/* ?

Ben.

-- 
Ben Hutchings
Time is nature's way of making sure that everything doesn't happen at once.

Attachment: signature.asc
Description: This is a digitally signed message part