Bug#797881: QNAP TS-219P II: qcontrol no longer works after upgrading to linux-image-4.1.0-0.bpo.1-kirkwood
On Sun, 2015-10-04 at 22:21 +0100, Ben Hutchings wrote:
> On Sun, 2015-10-04 at 14:04 +0100, Ian Campbell wrote:
> > On Thu, 2015-09-03 at 12:20 +0200, Robert Schlabbach wrote:
> > > Package: linux-image-4.1.0-0.bpo.1-kirkwood
> > > Version: 4.1.3-1~bpo8+1
> > >
> > > After installing this Linux kernel on my QNAP TS-219P II, qcontrol no
> > > longer works:
> > >
> > > 1. The status LED remains in red/green blink mode (as set by the boot
> > > loader). It should be set to solid green when the kernel is loaded.
> > > 2. The buzzer does not buzz. It should buzz when the kernel is loaded
> > > and when the kernel is shutting down.
> > >
> > > Removing and reinstalling the qcontrol package did not help.
> >
> > I suspect this is due to the device path for the input node changing
> > from /dev/input/by-path/platform-gpio_keys-event to /dev/input/by
> > -path/platform-gpio-keys-event. With the version of qcontrol in Jessie
> > it won't even start if it can't find the device, even though it can do
> > many of its core things without it (the node is for button input only).
>
> The change seems to have been in the other direction.
Right.
> > This is fixed by qcontrol 0.5.4-4 in testing (both looking for old and
> > new names, as well as not treating failure to find either as a
> > catastrophe), but for Jessie you can just edit the path in
> > /etc/qcontrol.conf.
> >
> > If that works for you then it might be worth uploading an updated
> > qcontrol to backports.
>
> I think the name change in the kernel should be reverted (not just in
> Debian, but upstream) since it broke existing userland.
I agree, I did mention this upstream at the time this was first
discovered[0] and the consensus seemed to be that this would be hard to fix
(or at least no one knew how).
> Presumably that would be:
I don't think DTB node names generally have any actual meaning and the
gpio_keys is the module name (which the kernel has normalised with "tr -
_", like it generally does), compared with the older board file based stuff
which was, I suppose, non-modular or otherwise hard coded somewhere.
It happened enough releases ago now that I think it is unlikely to change
back :-/. I probably should have chased harder at the time.
Ian.
[0] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-January/2237
91.html and some relevant replies:
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-January/224933.html
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-January/225917.html
>
> --- a/arch/arm/boot/dts/kirkwood-ts219-6281.dts
> +++ b/arch/arm/boot/dts/kirkwood-ts219-6281.dts
> @@ -32,7 +32,7 @@
> };
> };
>
> - gpio_keys {
> + gpio-keys {
> compatible = "gpio-keys";
> #address-cells = <1>;
> #size-cells = <0>;
> --- a/arch/arm/boot/dts/kirkwood-ts219-6282.dts
> +++ b/arch/arm/boot/dts/kirkwood-ts219-6282.dts
> @@ -42,7 +42,7 @@
> };
> };
>
> - gpio_keys {
> + gpio-keys {
> compatible = "gpio-keys";
> #address-cells = <1>;
> #size-cells = <0>;
> --- END ---
>
> Ben.
>
Reply to: