[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#797361: marked as done (initramfs-tools: hooks/fsck includes too many tools)



Your message dated Sun, 27 Dec 2015 23:00:16 +0000
with message-id <E1aDKIS-0001n8-QG@franck.debian.org>
and subject line Bug#797361: fixed in initramfs-tools 0.121~rc2
has caused the Debian Bug report #797361,
regarding initramfs-tools: hooks/fsck includes too many tools
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
797361: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=797361
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: initramfs-tools
Severity: normal
Version: 0.120
Tags: patch

Hello,

Initramfs tools hooks/fsck includes fsck utils for / and /usr, but it
doesn't take `pass' field into account, specifically when it's not set
or set to 0 (as per fstab(5) fsck should not be run against those
filesystems. Specifically one would set that to zero for filesystems
that don't require fsck to be run, like btrfs and xfs.

See attached proposed patch.

>From 3ebe2c4c3c7df2fddb2e15b438363e8f95d80962 Mon Sep 17 00:00:00 2001
From: Dimitri John Ledkov <dimitri.j.ledkov@intel.com>
Date: Sat, 29 Aug 2015 23:59:07 +0100
Subject: [PATCH] Do not include fsck tools for fstab entries with empty or 0
 pass field.

Those fstab entries request not to have fsck run against them, e.g. btrfs & xfs.
---
 hooks/fsck | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/hooks/fsck b/hooks/fsck
index 6c90996..4483e3b 100755
--- a/hooks/fsck
+++ b/hooks/fsck
@@ -27,6 +27,11 @@ _read_fstab_entry () {
 	fstab_files | while read file; do
 		if [ -f "$file" ]; then
 			while read MNT_FSNAME MNT_DIR MNT_TYPE MNT_OPTS MNT_FREQ MNT_PASS MNT_JUNK; do
+				case "$MNT_PASS" in
+				  ""|"0")
+					continue;
+					;;
+				esac
 				case "$MNT_FSNAME" in
 				  ""|\#*)
 					continue;
-- 
2.5.0

Regards,

Dimitri.

--- End Message ---
--- Begin Message ---
Source: initramfs-tools
Source-Version: 0.121~rc2

We believe that the bug you reported is fixed in the latest version of
initramfs-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 797361@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ben Hutchings <ben@decadent.org.uk> (supplier of updated initramfs-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 22 Dec 2015 22:07:42 +0000
Source: initramfs-tools
Binary: initramfs-tools initramfs-tools-core
Architecture: all source
Version: 0.121~rc2
Distribution: experimental
Urgency: medium
Maintainer: Debian kernel team <debian-kernel@lists.debian.org>
Changed-By: Ben Hutchings <ben@decadent.org.uk>
Closes: 588452 602331 620814 633582 696632 697017 747871 766920 770394 782641 783291 783410 783620 784234 785147 785564 790095 791754 792557 793786 795831 795832 795837 795839 797361 799443 801154 807000 807004 807256
Description: 
 initramfs-tools-core - generic modular initramfs generator (core tools)
 initramfs-tools - generic modular initramfs generator (automation)
Changes:
 initramfs-tools (0.121~rc2) experimental; urgency=medium
 .
   * Upload to experimental, not unstable
 .
 initramfs-tools (0.121~rc1) unstable; urgency=medium
 .
   [ Ben Hutchings ]
   * [da2159f] Add .gitignore files to exclude generated and backup files
   * [8ad7317] bash-completion: Install using dh_bash-completion
   * [31d21d6] Rename lintian override file so dh_lintian installs it
     automatically
   * [9d45599] debian/control: Update and shorten description
   * [2bf8c27] Split initramfs-tools binary packages into core and automation
     hooks
   * [6562e1b] debian/control,debian/copyright: Use canonical HTTP-S URLs for
     Alioth git repos
   * [76dab5a] hook-functions: Include soft-dependencies of all kernel modules
     (Closes: #588452)
   * [7285ffb] hooks/busybox: Fail if busybox is wanted but not found
     (Closes: #785564)
   * [852b9ab] scripts/functions: Use shell to create stamp file instead of
     'touch' (Closes: #783291)
   * [9aea31d] sripts/local: Remove obsolete hint about ATA device renaming
   * [e0c8d03] hook-functions: Always use /proc/mounts, avoiding mangling of
     /dev/root (Closes: #766920)
   * [728f534] hook-functions: Fold sys_walk_modalias into sys_walk_mod_add
   * [d122ab6] hook-functions: Split block device sysfs lookup into a separate
     function
   * [aff5209] hook-functions: Remove loop-aes support
   * [3cb744c] hook-functions: Rewrite block device sysfs lookup to be generic
     (Closes: #747871, #785147, #807004, #807256)
   * [8ac52dc] hook-functions: Include modules for all components of a
     multi-disk device (Closes: #620814)
   * [c69313d] parse_numeric: Tighten check for whether 'root' parameter is a
     number (Closes: #697017)
   * [8062189] parse_numeric: Add support for 20-bit minor numbers in 'root'
     parameter
   * [88f98b5] parse_numeric: Replace numeric root with canonical device name
   * [28e5a0a] update-initramfs: Use linux-version command to sort versions
     (Closes: #770394, #795837)
   * [4b4e578] lsinitramfs.8: Update the BUGS section to note fix for #717805
     (Closes: #790095)
   * [fa82bf1] hooks/fsck: Stop copying sulogin, which is no longer used
   * [95beada] Only run fsck if enabled in /etc/fstab (pass != 0)
     (Closes: #797361)
   * [371221b] hooks/fsck: Use 'command' to find fsck.<type> (Closes: #784234)
   * [e352b94] scripts/functions: Use blkid to resolve LABEL= and UUID= block
     device IDs
   * [7469eee] scripts/functions: Handle PARTLABEL= and PARTUUID= block device
     IDs using blkid (Closes: #801154)
   * [fe30453] hook-functions: Include drivers/nvme in block driver modules
     (Closes: #807000)
   * [fa1985b] update-initramfs: Run 'sync' after writing the initramfs
     (Closes: #783620)
   * [6a40a89] hook-functions: Introduce copy_file function
   * [a7fc630] Use copy_file to copy config files and firmware, instead of
     copy_exec
   * [52ae50c] hook-functions: Use copy_file to install modules
   * [b215c18] Support multiple break points using a comma delimiter
     (Closes: #795832)
   * [b2dfbeb] Set emacs local variables to implement our shell coding style
   * [b1dc049] hook-functions: Preserve symlinks when copying files
     (Closes: #799443)
   * [319b141] hooks/fsck: Simplify by letting copy_exec handle symlinks
   * [143b9ef] maintainer-notes.html: Update changelog command lines to use
     'gbp dch'
   * [f01cdd4] debian/control: Ensure lockstep upgrade of initramfs-tools and
     -core
   * [88f7bb6] debian/TODO: Update for released and pending changes
   * [d136f22] scripts/local: Remove residual support for separate /etc
     filesystem
   * [14913b2] scripts/local: Name parameters to local_device_setup
   * [3080087] Defer resolving block device IDs to local_device_setup
   * [3574b56] scripts/functions: Stop resolving symlinks in resolve_device
     (Closes: #791754)
 .
   [ Laurent Bigonville ]
   * [27405fc] Support fsck.mode= and fsck.repair= parameters as known by
     systemd-fsck (Closes: #783410, #792557)
   * [8a2f298] Run new panic scripts just before dropping to a shell
     (Closes: #602331)
 .
   [ Boris Egorov ]
   * [c14d661] mkinitramfs: fix bashism in script (Closes: #633582)
 .
   [ Salvatore Bonaccorso ]
   * [f78c9a9] scripts/nfs: Check return value from nfs_mount_root_impl
     (Closes: #782641)
 .
   [ Roger Shimizu ]
   * [50aa8e2] advance the timing of insmod netconsole
   * [3acddcc] redirect debug info to netconsole (Closes: #793786)
 .
   [ Andy Whitcroft ]
   * [4ba741b] Add 2>&1 to the run-init line (Closes: #795831)
   * [1f5c193] When adding i8042 also add psmouse as some keyboards are behind
     the mouse (Closes: #795839)
 .
   [ Roger Leigh ]
   * [6a8d18b] init: Always migrate /run to the rootfs (Closes: #696632)
Checksums-Sha1: 
 637879afd5e58783b459e5d143925c36e6b3fd38 1827 initramfs-tools_0.121~rc2.dsc
 ae8241178fec79ee313b7047b895d11cb7841678 81796 initramfs-tools_0.121~rc2.tar.xz
 ca77d0e7dcee3156cfa17068d6d5b141c1cd8c19 91304 initramfs-tools-core_0.121~rc2_all.deb
 5c816122c238ea6c85e536dbd146e5bf42e1277d 61984 initramfs-tools_0.121~rc2_all.deb
Checksums-Sha256: 
 a843f037d009a716a05608e53358a91882acfee5abecd34d8b05370e6a75f60c 1827 initramfs-tools_0.121~rc2.dsc
 692f46cdb3d98463a39a24b3d6b73e90e1f8644f47898c42c9dfe421b0e17e1a 81796 initramfs-tools_0.121~rc2.tar.xz
 136b2361c60146f48473c074e0ab9322bb985fead530b7ff5c2047c2f37ad9f2 91304 initramfs-tools-core_0.121~rc2_all.deb
 0c95877a21a1d8518218e7790d90840f2fa1a8acf71c7862a49e10645852db0e 61984 initramfs-tools_0.121~rc2_all.deb
Files: 
 5a088b0402a552cb25a3d526b378b298 1827 utils optional initramfs-tools_0.121~rc2.dsc
 ee04e46be524b9dabe82422373e4f69d 81796 utils optional initramfs-tools_0.121~rc2.tar.xz
 4a5f88c08bca7db8f3bea5a2a0654042 91304 utils optional initramfs-tools-core_0.121~rc2_all.deb
 ba9a71555f1e2695e933984954f05946 61984 utils optional initramfs-tools_0.121~rc2_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIVAwUBVnnV7+e/yOyVhhEJAQoBJhAAkjSQFmokaADTzpf6tOlHsw1Zr9xOUV/T
hiOxn7eAP1Az/HfMSs5FQtZfoP8FN89/vcGc0+2uAe7YGNRNPR3QM5ryWU1aGDL6
RaAaoUoFqUAGasH05b0/6O7UD8w5ZGBzj5V6sQgSXO5R+nzOsU90K7/XehLLwEWH
iccC8jl3zK+CEF8klqXuAMG4/pFb+Dr7bE29V/K7ST90EdOKIggXaUkp5KXMuIbA
p6QJcgVQFxJ4FIYko5N42oqb78p5BqsA2BLe8d7u1DO+YboLOpDG40w8GPRFAgyF
e7lb62nwayIN8zdSrLwdwvxYftyMz1SdH3//cybWbZ0+O+MvBwvg5Tq+fkpD2j7V
USxL+WHpoMO8bhGao/Dp6XYrr+dU1vYWIgwarbObqynAtj9WLzAfzNnovr//qKvc
VzNYvplo3T0YYSwK0vBx7Vte4N/FJarFkbiTiGQYZyZ/ok9irphqy2tVoJ2m9Wb3
QbqjV7ujBzXSgFShm09uAMxpGZrrUZMrpsRM6CvRBe+ZmUXh3+r8TiNjoT1/XEEd
xXrHGyexLqVzHmQsvnBL7JyF3iigKMO9URNiZIbWGIiNyq3wDL7/u0u//iARO9aQ
ii+oJfi+eR8HrrEAlmrMCTFz0RRM559hEG/zK6tevtGyezXSy04gRm/TCHuEeltR
sUFVzGtDzn8=
=0u0e
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: